Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp496269rdb; Thu, 30 Nov 2023 10:02:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IEQh01p3dnP/Or+y4CmIEEEQVEJY4pF0n6b2tEalZNwGtVbSTrCnjjYNH351C/jY5IQLWpt X-Received: by 2002:a05:6a20:e112:b0:187:bc51:de6e with SMTP id kr18-20020a056a20e11200b00187bc51de6emr28657287pzb.26.1701367332106; Thu, 30 Nov 2023 10:02:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701367332; cv=none; d=google.com; s=arc-20160816; b=Kg9nrvUFAXetqgZVMWFlDvf6oK24asYLFw7/qHuQfZl41KwvyfDO0p/vhXcNYz2+Wk /uJe9SHLyZmkCxlb0FD0SDClb4zD8v2HJOJiP+Osoo23mdVEpny1xnP7pbwBTm5wb2qG B4rn6gvEioii2ZJZkUkx8U0NN6YqXmq9MXxc1jQyDMoQpaBY8UUFF4kgVl/TwhyWspv/ Y27vylgACybZl4dzY7dpEOME6CQcjXO71jkZ7AGE/1TmfZdSuVY19IZTOKSrhg15U5Nf /1UnFoVRf7DdonX3XqqrdM3qmmnMahi40TPE+5n56pMUZOSe0M9cjXjcXkvd42c3u4Zu waxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=vtj5kjLYnXhJa4R359vhMbG5wNq0XbfrEdrllY9xCH8=; fh=uSoMUSvsbzqPbYLOh1z/rcEkG9VKZ008GOIFsH80sMI=; b=rRvmApUBi+5CxYnT06LoUze7bhrYMkLrHt9NjPHOmb55DlNvIGxlWvMRudpmRbrNeN lLIevBwiCwzvZQMDn75K/xN7Isw+vta30vYYTTPt0/cXVU0knlGGlx72TRcvQVSi6EaV oEYIekz39ABTY8Bf8eaRyuzfG9yRVWvxLKJ+6HzTBUp4OqflTpykuqGSos1g36xV/Y3Z /wigGio/Ho0pppwSZJdcEbmHGtyOsq8cMpecT/GKTN444hG7CfSH4UbzhZnt5IKeaz2v hrq4/cPzuvAG6rRbmzo7dCbTAJl5WV/8oJvvT0OjjgW9SdMxKvjQHWpUBF+BFt+g7Mhm KUqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Pbnp6Xui; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id a2-20020a056a000c8200b006cdf615b690si560338pfv.149.2023.11.30.10.02.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 10:02:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Pbnp6Xui; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 334D084EAC46; Thu, 30 Nov 2023 10:02:07 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231959AbjK3SBx (ORCPT + 99 others); Thu, 30 Nov 2023 13:01:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230030AbjK3SBw (ORCPT ); Thu, 30 Nov 2023 13:01:52 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D371D103; Thu, 30 Nov 2023 10:01:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701367318; x=1732903318; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=54gTn1gRLLouIJlaQjeLN+mpwCM7NSqeeWXZaSfmCkI=; b=Pbnp6Xui6iOEZqHhAfc75E8BI4oPE2oVtIjEkeTe6mdaUOkzhz75GEkv 96YjddWgKqQoFkjrwbi0Y0DWWQwfW3MXCVOOvPX4wJOu5dvOXLGtGBZ1m LGAPWOPhnkSUX8vyCbAf53g9DPTu/D0p9ptSMADRCj0n6XHPUWik9hQGj NPs2FU6tGBzNTjLJKrxHhKDc+YsjKGPo0gZCguQ9hxquYKJF6dmV5fpTc riXqoQVix+BYIL7N8a3tXH1cQeGJbdEda96u+Bw20r8Rw4di6LT1Ont2D WeU7Q0wyC6ky389PGr2j1pUwHzXFdu6Vh63+YPCR4j7YE2WmvP33nf/6q A==; X-IronPort-AV: E=McAfee;i="6600,9927,10910"; a="479568783" X-IronPort-AV: E=Sophos;i="6.04,239,1695711600"; d="scan'208";a="479568783" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2023 10:01:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10910"; a="762811323" X-IronPort-AV: E=Sophos;i="6.04,239,1695711600"; d="scan'208";a="762811323" Received: from agluck-desk3.sc.intel.com (HELO agluck-desk3) ([172.25.222.74]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2023 10:01:46 -0800 Date: Thu, 30 Nov 2023 10:01:45 -0800 From: Tony Luck To: Kai Huang Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, x86@kernel.org, dave.hansen@intel.com, kirill.shutemov@linux.intel.com, peterz@infradead.org, tglx@linutronix.de, bp@alien8.de, mingo@redhat.com, hpa@zytor.com, seanjc@google.com, pbonzini@redhat.com, rafael@kernel.org, david@redhat.com, dan.j.williams@intel.com, len.brown@intel.com, ak@linux.intel.com, isaku.yamahata@intel.com, ying.huang@intel.com, chao.gao@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, nik.borisov@suse.com, bagasdotme@gmail.com, sagis@google.com, imammedo@redhat.com Subject: Re: [PATCH v15 22/23] x86/mce: Improve error log of kernel space TDX #MC due to erratum Message-ID: References: <9e80873fac878aa5d697cbcd4d456d01e1009d1f.1699527082.git.kai.huang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9e80873fac878aa5d697cbcd4d456d01e1009d1f.1699527082.git.kai.huang@intel.com> X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 30 Nov 2023 10:02:07 -0800 (PST) On Fri, Nov 10, 2023 at 12:55:59AM +1300, Kai Huang wrote: > Instead of modifying above error log, improve the error log by printing > additional TDX related message to make the log like: > > ... > [...] mce: [Hardware Error]: Machine check: Data load in unrecoverable area of kernel > [...] mce: [Hardware Error]: Machine Check: TDX private memory error. Possible kernel bug. This seems a reasonable addition. > arch/x86/kernel/cpu/mce/core.c | 33 +++++++++++ Reviewed-by: Tony Luck [I only reviewed the hooks into mce/core.c I don't feel qualified to dig through the TDX bits that determine this is a TD private page] -Tony