Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
MIME-Version: 1.0
References: <20231120104152.13740-1-bp@alien8.de> <20231120104152.13740-2-bp@alien8.de>
 <dc3835e3-0731-4230-bbb9-336bbe3d042b@amd.com> <20231130171316.GLZWjCrHGHl+VVp724@fat_crate.local>
In-Reply-To: <20231130171316.GLZWjCrHGHl+VVp724@fat_crate.local>
From:   Brian Gerst <brgerst@gmail.com>
Date:   Thu, 30 Nov 2023 12:30:57 -0500
Message-ID: <CAMzpN2j+4gUmUSghPjUDrQBLMn70FVT0cAAbZLkjk90y3L1jBQ@mail.gmail.com>
Subject: Re: [PATCH 01/13] x86/CPU/AMD: Add ZenX generations flags
To:     Borislav Petkov <bp@alien8.de>
Cc:     Tom Lendacky <thomas.lendacky@amd.com>, X86 ML <x86@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Nov 30, 2023 at 12:14=E2=80=AFPM Borislav Petkov <bp@alien8.de> wro=
te:
>
> On Thu, Nov 30, 2023 at 11:05:14AM -0600, Tom Lendacky wrote:
> > Previously just being family 17h or 19h would get X86_FEATURE_ZEN set. =
With
> > this, if the model check doesn't match, you won't get any X86_FEATURE_Z=
EN*
> > set. Should you do set X86_FEATURE_ZEN here, e.g. lowest common denomin=
ator
> > for the family?
>
> My assumption/expectation is that those WARNs should never happen
> because they will be caught early enough in enablement and I will get
> patches.
>
> Besides, X86_FEATURE_ZEN means only Zen1 now.

It should be renamed to X86_FEATURE_ZEN1 for clarity.

Brian Gerst