Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp511263rdb; Thu, 30 Nov 2023 10:23:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IEiEdn862zIEC+RGw6YjWFLKFyebYM/I9960MJtqG5isoiJQMhKaZLK04EBWTPsvs83ogka X-Received: by 2002:a17:90b:1d0f:b0:285:a2af:31aa with SMTP id on15-20020a17090b1d0f00b00285a2af31aamr17313442pjb.37.1701368632582; Thu, 30 Nov 2023 10:23:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701368632; cv=none; d=google.com; s=arc-20160816; b=ZtOyKj5GWrL3B4gKV7YjRBDRs9SVlOgIK44jZENOzYZ/DF0VJbtJU57J0fXU6WPsPx pu7wMxQeD/HBprdesFcQC+VbBquWN4C5ppxIMvTC5CkuI3+AjaXjQnnMeE010n6919g6 R8iRk9smxsWCpAKwktb4uY2jMH14Eblzsknicf9Z59M1IjjnHLlYlqKpxVOhMXxt+GD5 WmYtfgR8O0gw8exq7pydoOkrn9AtnWl38LtpiusA0N5X5yuJIiG4neD2WOrREqZBanS8 6jkIN7QRIBxKZ+TyBS36zDymbVGfXSB38f1Ee2KBz0CT/ZEYKHNFPm1MJGtcgvf9NGnB VIHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=2WFn+oi+4PTh8i8CQjcAUIIm5rTPhtRHcNddda3hr14=; fh=NZLVU7bL8ZskgxD/Yz4WQnewX4m61X2A3qTFpPktUGU=; b=VAgEhAQetWaC1Hxg/kfJ1rjJ/3We3ENpCBPPQKs3wIxy35hOcVSHFaGql792O8ZpUY Yw5CrRfQU8+U6SfsasS0TX9VSyX7LThGdECDq4v/DUPohpeHMS3mjQ3T3HHSa24Rt+TH uuPEoxDSltcx391YKRgpgRV8wiOEoTwkBikUbCNwIO20QMJDzDhtPCGYlj/JVBcDt4MZ ZInVpI+7fPqp+Ts7w7saBGVdEkZnuupHXONrKitmev+IXEtgosBvTJT/c33t8vL5G9j8 pGZGNOAlaLbJnJ+UPYFBWprXpK+3kXikJxtz+lHyhMj7Iw7Ziyl5PRhNkWb4cSyZcJdf gFsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FzZZ8kZR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id d21-20020a17090ab31500b00285a8cd2d33si4126753pjr.172.2023.11.30.10.23.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 10:23:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FzZZ8kZR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 2EDA88028A55; Thu, 30 Nov 2023 10:23:50 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231313AbjK3SXh (ORCPT + 99 others); Thu, 30 Nov 2023 13:23:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230030AbjK3SXg (ORCPT ); Thu, 30 Nov 2023 13:23:36 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39825D1 for ; Thu, 30 Nov 2023 10:23:43 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8E830C433C8; Thu, 30 Nov 2023 18:23:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701368622; bh=qQlf1wlM46DStT6SsBHk1Ov4ohMfBkiHcFw/hbSHDzA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FzZZ8kZRdJ6pu6uovrGlCvcsYD7x7XChrvYhQtmCH0KuYQqvn11bWG96iotfj+n7p dXhzk7H2K0gpbPETqyRcS6ISPZgn6eN27zEvbY9g8OqigiikY0TfTmeveUjN7p3AZj ZTIj+dyREsWw7HRSoo/fVNdWUnKXjScHmJe01yqK7BWZIMbnZbohkkmltCJidBGLIG kVHBqFoNIAnqmJybMFjnBDFeTWHdLBlspwKVOVZGBsd5gdmGtjCBJBNgEhw1o7PfGG Tlxlf3Ib/rtxu0Q3rdlAOswSiIGZ/kBdBDHKSkxjCfnfrZZFwmdUYhjBaYbbnweOSv rdwpPyoHj9o1A== Date: Thu, 30 Nov 2023 18:23:38 +0000 From: Simon Horman To: Dan Carpenter Cc: Shinas Rasheed , Veerasenareddy Burru , Sathesh Edara , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH net-next] octeon_ep: Fix error code in probe() Message-ID: <20231130182338.GM32077@kernel.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 30 Nov 2023 10:23:50 -0800 (PST) On Tue, Nov 28, 2023 at 04:13:19PM +0300, Dan Carpenter wrote: > Set the error code if octep_ctrl_net_get_mtu() fails. Currently the code > returns success. > > Fixes: 0a5f8534e398 ("octeon_ep: get max rx packet length from firmware") > Signed-off-by: Dan Carpenter > --- > drivers/net/ethernet/marvell/octeon_ep/octep_main.c | 1 + > 1 file changed, 1 insertion(+) Thanks Dan, I had noticed this one too. Reviewed-by: Simon Horman ...