Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
MIME-Version: 1.0
References: <20231127220902.1315692-1-irogers@google.com> <20231127220902.1315692-9-irogers@google.com>
 <CAM9d7cjpYHN_Q63sW70vTCisdW=-SzjsrryUUJjgtZ3+9jdxfA@mail.gmail.com>
In-Reply-To: <CAM9d7cjpYHN_Q63sW70vTCisdW=-SzjsrryUUJjgtZ3+9jdxfA@mail.gmail.com>
From:   Ian Rogers <irogers@google.com>
Date:   Thu, 30 Nov 2023 10:29:30 -0800
Message-ID: <CAP-5=fXjReF38T_GKohtWd7_7fZjYVnKBj-Fwt+agi1vSWAEdQ@mail.gmail.com>
Subject: Re: [PATCH v5 08/50] perf record: Be lazier in allocating lost
 samples buffer
To:     Namhyung Kim <namhyung@kernel.org>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Nick Terrell <terrelln@fb.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Kajol Jain <kjain@linux.ibm.com>,
        Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
        Huacai Chen <chenhuacai@kernel.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Vincent Whitchurch <vincent.whitchurch@axis.com>,
        "Steinar H. Gunderson" <sesse@google.com>,
        Liam Howlett <liam.howlett@oracle.com>,
        Miguel Ojeda <ojeda@kernel.org>,
        Colin Ian King <colin.i.king@gmail.com>,
        Dmitrii Dolgov <9erthalion6@gmail.com>,
        Yang Jihong <yangjihong1@huawei.com>,
        Ming Wang <wangming01@loongson.cn>,
        James Clark <james.clark@arm.com>,
        K Prateek Nayak <kprateek.nayak@amd.com>,
        Sean Christopherson <seanjc@google.com>,
        Leo Yan <leo.yan@linaro.org>,
        Ravi Bangoria <ravi.bangoria@amd.com>,
        German Gomez <german.gomez@arm.com>,
        Changbin Du <changbin.du@huawei.com>,
        Paolo Bonzini <pbonzini@redhat.com>, Li Dong <lidong@vivo.com>,
        Sandipan Das <sandipan.das@amd.com>,
        liuwenyu <liuwenyu7@huawei.com>, linux-kernel@vger.kernel.org,
        linux-perf-users@vger.kernel.org,
        Guilherme Amadio <amadio@gentoo.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Nov 29, 2023 at 6:09=E2=80=AFPM Namhyung Kim <namhyung@kernel.org> =
wrote:
>
> On Mon, Nov 27, 2023 at 2:09=E2=80=AFPM Ian Rogers <irogers@google.com> w=
rote:
> >
> > Wait until a lost sample occurs to allocate the lost samples buffer,
> > often the buffer isn't necessary. This saves a 64kb allocation and
> > 5.3kb of peak memory consumption.
> >
> > Signed-off-by: Ian Rogers <irogers@google.com>
> > ---
> >  tools/perf/builtin-record.c | 29 +++++++++++++++++++----------
> >  1 file changed, 19 insertions(+), 10 deletions(-)
> >
> > diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> > index 9b4f3805ca92..b6c8c1371b39 100644
> > --- a/tools/perf/builtin-record.c
> > +++ b/tools/perf/builtin-record.c
> > @@ -1924,21 +1924,13 @@ static void __record__save_lost_samples(struct =
record *rec, struct evsel *evsel,
> >  static void record__read_lost_samples(struct record *rec)
> >  {
> >         struct perf_session *session =3D rec->session;
> > -       struct perf_record_lost_samples *lost;
> > +       struct perf_record_lost_samples *lost =3D NULL;
> >         struct evsel *evsel;
> >
> >         /* there was an error during record__open */
> >         if (session->evlist =3D=3D NULL)
> >                 return;
> >
> > -       lost =3D zalloc(PERF_SAMPLE_MAX_SIZE);
>
> To minimize the allocation size, this can be
> sizeof(*lost) + session->machines.host.id_hdr_size
> instead of PERF_SAMPLE_MAX_SIZE.

Sounds good, should probably be a follow up. The current size is
PERF_SAMPLE_MAX_SIZE.

Thanks,
Ian

> Thanks,
> Namhyung
>
>
> > -       if (lost =3D=3D NULL) {
> > -               pr_debug("Memory allocation failed\n");
> > -               return;
> > -       }
> > -
> > -       lost->header.type =3D PERF_RECORD_LOST_SAMPLES;
> > -
> >         evlist__for_each_entry(session->evlist, evsel) {
> >                 struct xyarray *xy =3D evsel->core.sample_id;
> >                 u64 lost_count;
> > @@ -1961,6 +1953,14 @@ static void record__read_lost_samples(struct rec=
ord *rec)
> >                                 }
> >
> >                                 if (count.lost) {
> > +                                       if (!lost) {
> > +                                               lost =3D zalloc(PERF_SA=
MPLE_MAX_SIZE);
> > +                                               if (!lost) {
> > +                                                       pr_debug("Memor=
y allocation failed\n");
> > +                                                       return;
> > +                                               }
> > +                                               lost->header.type =3D P=
ERF_RECORD_LOST_SAMPLES;
> > +                                       }
> >                                         __record__save_lost_samples(rec=
, evsel, lost,
> >                                                                     x, =
y, count.lost, 0);
> >                                 }
> > @@ -1968,9 +1968,18 @@ static void record__read_lost_samples(struct rec=
ord *rec)
> >                 }
> >
> >                 lost_count =3D perf_bpf_filter__lost_count(evsel);
> > -               if (lost_count)
> > +               if (lost_count) {
> > +                       if (!lost) {
> > +                               lost =3D zalloc(PERF_SAMPLE_MAX_SIZE);
> > +                               if (!lost) {
> > +                                       pr_debug("Memory allocation fai=
led\n");
> > +                                       return;
> > +                               }
> > +                               lost->header.type =3D PERF_RECORD_LOST_=
SAMPLES;
> > +                       }
> >                         __record__save_lost_samples(rec, evsel, lost, 0=
, 0, lost_count,
> >                                                     PERF_RECORD_MISC_LO=
ST_SAMPLES_BPF);
> > +               }
> >         }
> >  out:
> >         free(lost);
> > --
> > 2.43.0.rc1.413.gea7ed67945-goog
> >