Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
MIME-Version: 1.0
References: <20231130140330.55de96cd@canb.auug.org.au> <6d11b95a-c5a5-47ca-b3da-d78f2ef9f5bc@infradead.org>
In-Reply-To: <6d11b95a-c5a5-47ca-b3da-d78f2ef9f5bc@infradead.org>
From:   Nhat Pham <nphamcs@gmail.com>
Date:   Thu, 30 Nov 2023 10:51:56 -0800
Message-ID: <CAKEwX=NCzMQzJxOTOsOZzGe4TeC6hzEUaw1HGHQLCc2bBTisNg@mail.gmail.com>
Subject: Re: linux-next: Tree for Nov 30 (mm/zswap.c)
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     Stephen Rothwell <sfr@canb.auug.org.au>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-mm <linux-mm@kvack.org>,
        Seth Jennings <sjenning@redhat.com>,
        Dan Streetman <ddstreet@ieee.org>,
        Vitaly Wool <vitaly.wool@konsulko.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Nov 30, 2023 at 9:16=E2=80=AFAM Randy Dunlap <rdunlap@infradead.org=
> wrote:
>
>
>
> On 11/29/23 19:03, Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20231129:
> >
>
> on i386, loongarch, ppc64, riscv32:
> when CONFIG_MEMCG is not set.
>
>
> ../mm/zswap.c: In function 'mem_cgroup_from_entry':
> ../mm/zswap.c:313:31: error: implicit declaration of function 'obj_cgroup=
_memcg'; did you mean 'obj_cgroup_put'? [-Werror=3Dimplicit-function-declar=
ation]
>   313 |         return entry->objcg ? obj_cgroup_memcg(entry->objcg) : NU=
LL;
>       |                               ^~~~~~~~~~~~~~~~
>       |                               obj_cgroup_put
> ../mm/zswap.c:313:62: warning: pointer/integer type mismatch in condition=
al expression
>   313 |         return entry->objcg ? obj_cgroup_memcg(entry->objcg) : NU=
LL;
>       |                                                              ^
> ../mm/zswap.c: In function 'shrink_worker':
> ../mm/zswap.c:984:31: error: invalid use of undefined type 'struct mem_cg=
roup'
>   984 |                 css_get(&memcg->css);
>       |                               ^~
>
>
>
> --
> ~Randy
>

Thanks for the report, Randy! I'm fixing this for the !CONFIG_MEMCG
case. A new version of this patch series should be sent out in a short
while.