Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <c5b46d5f-8a8c-f949-43da-943c86c0634a@quicinc.com>
Date:   Fri, 1 Dec 2023 00:46:23 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH 3/3] firmware: arm_scmi: Increase the maximum opp count
Content-Language: en-US
To:     Cristian Marussi <cristian.marussi@arm.com>
CC:     <sudeep.holla@arm.com>, <linux-arm-msm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <quic_mdtipton@quicinc.com>,
        <linux-arm-kernel@lists.infradead.org>, <quic_asartor@quicinc.com>,
        <quic_lingutla@quicinc.com>
References: <20231129065748.19871-1-quic_sibis@quicinc.com>
 <20231129065748.19871-4-quic_sibis@quicinc.com> <ZWiHUt-N8GvG5z_O@pluto>
From:   Sibi Sankar <quic_sibis@quicinc.com>
In-Reply-To: <ZWiHUt-N8GvG5z_O@pluto>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 11/30/23 18:30, Cristian Marussi wrote:
> On Wed, Nov 29, 2023 at 12:27:48PM +0530, Sibi Sankar wrote:
>> The number of opps on certain variants of the X1E80100 SoC are greater
>> than current maximum, so increase the MAX_OPP count to the next log level
>> to accommodate that.
>>
> 
> Hi,

Hey Cristian,
Thanks for taking time to review the series.

> 
> 
>> Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
>> ---
>>   drivers/firmware/arm_scmi/perf.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/firmware/arm_scmi/perf.c b/drivers/firmware/arm_scmi/perf.c
>> index 3344ce3a2026..edf34a3c4d6a 100644
>> --- a/drivers/firmware/arm_scmi/perf.c
>> +++ b/drivers/firmware/arm_scmi/perf.c
>> @@ -24,7 +24,7 @@
>>   #include "protocols.h"
>>   #include "notify.h"
>>   
>> -#define MAX_OPPS		16
>> +#define MAX_OPPS		24
>>
> 
> There is an hashtable, opps_by_freq, sized by an ilog2()....
> 
> ....so, can we stick to a power-of-2 like 32 instead ?
> (and be more future proof too...)

Thanks, will get this changed in the next re-spin.

> 
> Other than this, LGTM
> 
> Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>
> 
> Thanks,
> Cristian