Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp545467rdb; Thu, 30 Nov 2023 11:21:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IEBCGz4c3aqJymfS4PQ3d669SfqNY5Ow8mwHWFAoxdJLoSOz44EEf+S3GDgZ3KqmI74HPag X-Received: by 2002:a17:903:2596:b0:1cf:9d88:a0ef with SMTP id jb22-20020a170903259600b001cf9d88a0efmr19295529plb.59.1701372095302; Thu, 30 Nov 2023 11:21:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701372095; cv=none; d=google.com; s=arc-20160816; b=piehb+H61eHs1CR+bBOnaE8ts8zVOQ8X2GAzSttbt5pa5nJlaH9j3YDmGewbqKMXXJ szYiwzmuGRgP2JcAHD72NLwAVBH9wcixhnXJfxewjMLER5c/V1jo7ErT0Rw7WymiyuBo 0hjhCm7FQuSyiXoHt9bbBulids+AtzbC3SE1GLCZGUAUADYMj5AmirASao0HyNXG2syZ 2FvgA0zLmpUIrgjLHbupzRvW+HxIz2rGMnwPqmLP908+PlYFY919l/dR9NClWCwOmaaS 7R2H6bHydKy7fTv1RUAFW6SlAl+lxo2RKRrjUD1rGCyiT81GcJoIw9zl1Xqv3BbX8mYA PrGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=FNcHli21vir5baYj9ku8MMNBlCqv0AKIpWf2Lyqz8B0=; fh=OoHa9/zdCzB+erFAqeIC5z60Lx4T7ij4uwD4L9Su0YQ=; b=wzvYcbZGHkAdT0DmAhE/nytZYlYv9L/9jTDieCads3lw4I3NiL2PPq8UlsbnZYpAWP brWU2QOZ2+gXB3lfe6Gu54VCGvEUQ0uqW20XygB2oTXV85NNLq0BdiFnOH2TXrIRQY4g vCYKsZdt0D1IMcGte8iDwobHWLDB06Syg89GoIohCazs/NbAzwH+SPwFO/XhawibHBj9 W5eEv6zYKmdyCtodSqV+Jru81+EhbmtbOm8tNG1mFTXzBRHjExUTiV0Lkai2QKxfk5s2 lZsUR1GoPAuMFndL5y82aPD37ASSh+cTBU9FadfX6asL8S4W32kY69s6bSLWE8QomGPz 2RMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=MZVdptyq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id y15-20020a17090322cf00b001cfd4eb4deasi1915399plg.357.2023.11.30.11.21.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 11:21:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=MZVdptyq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id F3DD680DA9BD; Thu, 30 Nov 2023 11:21:32 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376320AbjK3TVS (ORCPT + 99 others); Thu, 30 Nov 2023 14:21:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376354AbjK3TVR (ORCPT ); Thu, 30 Nov 2023 14:21:17 -0500 Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B31910EF; Thu, 30 Nov 2023 11:21:23 -0800 (PST) Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-6cdcef787ffso1323756b3a.0; Thu, 30 Nov 2023 11:21:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701372083; x=1701976883; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=FNcHli21vir5baYj9ku8MMNBlCqv0AKIpWf2Lyqz8B0=; b=MZVdptyqLtkcvQKLlmAGPE0/pLxv5Gnje94wA3qFn7urap5mGjj280hhluwjO+zGJF BPLteed1crWW7syB1ff26BJP/8fEFVIEwWmQF6ll3VOdmUqFIw9DPs26GLxq3IWHmMlZ 9BILz4kSJpt0zrhgFuK7Oyz1SdZbKUqZP7jxqrUUyyNkrdA6IYxYEDQRVibkqe59ta+O N8X557gQTSRpBQIOwRR/PWG0qozzgT39ED2+vK1ASQeHixqmAvhzxIAxMWwyVNCU5Ejx NAUsYjH+/2cyR1jGApBFNlpWh9O6M9krQar14UMmSMJ0gONHkrsK/dw28HaxQyLdrj8y 2niA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701372083; x=1701976883; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FNcHli21vir5baYj9ku8MMNBlCqv0AKIpWf2Lyqz8B0=; b=W57wZRDzFyYJGSS6cXVzEBy7mWWhsrPXzBav4d/2dZaPAut1Sf539H46VVZlmm6Rdw KxfRt4+axuosUiPEQwdyqxZzq4uq4U/49jMhnBTIlDx1yJ/2Ujk3AzGL17TSB2N9uudk 4+k8mocLeSQFMN0eZC8cP3XZGZfLleuIMkox38SUcobOIPjVNFVVEAqwUxo51tEN3A6V OfTH3THFF2vy8ubrzRzONbcBRjJ9GbxTbCgMbBEO0N2Tskw6Nqql79Hn9BknJ00Ag5Oe 9gcLFP909OGUWqEejg4R3oQ1cYsv6r12AVVJWhaBUUo5kBs/qthsFnOEAky+NT/6wV5r GPiw== X-Gm-Message-State: AOJu0YwYmirVvTW27+7sM7ZoAyFRcGEEoth8xoJnzhYskr6LuFt3FA2/ HWE/oavRppwUz6PRlW4ToHA= X-Received: by 2002:a05:6a00:21c9:b0:6cb:8ec7:ad01 with SMTP id t9-20020a056a0021c900b006cb8ec7ad01mr27603366pfj.10.1701372082809; Thu, 30 Nov 2023 11:21:22 -0800 (PST) Received: from localhost ([2a00:79e1:2e00:1301:e1c5:6354:b45d:8ffc]) by smtp.gmail.com with ESMTPSA id y63-20020a62ce42000000b006c3069547bfsm1628882pfg.79.2023.11.30.11.21.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 11:21:22 -0800 (PST) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, Rob Clark , Steev Klimaszewski , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter , Danylo Piliaiev , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] drm/msm/dpu: Correct UBWC settings for sc8280xp Date: Thu, 30 Nov 2023 11:21:18 -0800 Message-ID: <20231130192119.32538-1-robdclark@gmail.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 30 Nov 2023 11:21:33 -0800 (PST) From: Rob Clark The UBWC settings need to match between the display and GPU. When we updated the GPU settings, we forgot to make the corresponding update on the display side. Reported-by: Steev Klimaszewski Fixes: 07e6de738aa6 ("drm/msm/a690: Fix reg values for a690") Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_mdss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index 6865db1e3ce8..29bb38f0bb2c 100644 --- a/drivers/gpu/drm/msm/msm_mdss.c +++ b/drivers/gpu/drm/msm/msm_mdss.c @@ -545,7 +545,7 @@ static const struct msm_mdss_data sc8280xp_data = { .ubwc_dec_version = UBWC_4_0, .ubwc_swizzle = 6, .ubwc_static = 1, - .highest_bank_bit = 2, + .highest_bank_bit = 3, .macrotile_mode = 1, }; -- 2.42.0