Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Message-ID: <b58c799c-8d3f-4fd8-9ddb-ebb06ef005d5@amd.com>
Date:   Thu, 30 Nov 2023 14:31:02 -0600
User-Agent: Mozilla Thunderbird
Subject: [RESEND v2] ACPI: APEI: Skip initialization of GHES_ASSIST structures
 for Machine Check Architecture
Content-Language: en-US
To:     "Luck, Tony" <tony.luck@intel.com>
Cc:     "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
        "rafael@kernel.org" <rafael@kernel.org>,
        "lenb@kernel.org" <lenb@kernel.org>,
        "james.morse@arm.com" <james.morse@arm.com>,
        "bp@alien8.de" <bp@alien8.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "yazen.ghannam@amd.com" <yazen.ghannam@amd.com>,
        Avadhut Naik <avadhut.naik@amd.com>
References: <20231106201340.434878-1-avadhut.naik@amd.com>
 <c09243d9-b725-49b0-a6ac-163d015ff441@amd.com>
 <ZWeId332wmrdLycH@agluck-desk3>
 <fbfe27c0-1635-434f-a1ab-71a10c9d6f38@amd.com>
 <SJ1PR11MB60839D04A329087D11933B6CFC82A@SJ1PR11MB6083.namprd11.prod.outlook.com>
From:   Avadhut Naik <avadnaik@amd.com>
In-Reply-To: <SJ1PR11MB60839D04A329087D11933B6CFC82A@SJ1PR11MB6083.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OU1IeUJUeHRYUWdzdjhCWGlXYTFJZEdDWlFnQWFBNGxjMTVkZXBaNUptRERw?=
 =?utf-8?B?QUtUOTRTNkVtV3BIUEZYTXM3NTlkN0xZYkpHTmhMcVEwd0orbXR4TEFJN1h3?=
 =?utf-8?B?NE5wQVpNY1JMMTFmVWJReUwzOFVLZGxKK2xEcVdwVitmWkRUNjh4U2hYampy?=
 =?utf-8?B?b2wxQlF4clI4RlJvV3dGM1NJcGN5TDBhUzFBM3RrK21LZ2Y5cmtsd3JEcTJF?=
 =?utf-8?B?c29FNlIzaHRCMjlSVU4waXk1ZWc5eHNZYlJscDhocUVmblc2U1pDaVpCRTBI?=
 =?utf-8?B?MHBsNjNlQkNpTWx3VXRuTVFrbWVIWlZEdGFRcHFDR1Z2Z3ZHQ2hKYS9UYnR4?=
 =?utf-8?B?ektWTUozbHlDTVhzeUNWTitFamt1L2hWQnRzeVFSR2ZPc1dHOS8vSk9HWlov?=
 =?utf-8?B?N25Vb3RrcDdnWTFveGdEUmhmdHZHR3N3YjVRYytVVVVCWjZob0NoZkNaVC93?=
 =?utf-8?B?dVVNc2VjZGx0L2hnZWdPZFNoangzRlRuSGJwaHRFRkYzNENjSTIzTW1jd1V2?=
 =?utf-8?B?ekZOTWJ0L1hwTDhIZDZWTUpFclhEWHFaeEJyWG5yMUFiMmZ3d09tc09sUVJp?=
 =?utf-8?B?SGRqb3FSY0ppMDBUYlFkNFVuVEZmZTYzdnhpL0FsaWo4cFExdFpTZHhwZ2FU?=
 =?utf-8?B?NnhNTFJqWC8rSFZUblRJYlJXa285TkFxUmx1SXBkbDhLUHlyaEpZclF3bVd2?=
 =?utf-8?B?empJOGV1RFozbyt5emVENGlJcTB2ZlFwZ21LU05TUUtMZkJXMW42Smw2cGto?=
 =?utf-8?B?anpjTjhhOEtWaGI2VkhMbVNTRlNoYko2QU5BR0ZnUFVJWDJXMlZLRmFUU1Fz?=
 =?utf-8?B?QjJUUnNUa2FvdmJUdjZ5SXhram9UdEVMQk5pTkpJY2pnajFiYlZHVXRoVFF0?=
 =?utf-8?B?NlhBWFVLeFU3bVVFU0ZiVjB2VnNqaXczV2Y3bFZPQy9WTXQ5Ly9PTmptQlN3?=
 =?utf-8?B?ODZKc3k5aUptK29CSFBRSzQvYi9yWEV2RGVyOTRNaDRUWHFFeGhmbzJPV0Vp?=
 =?utf-8?B?ZkNLTkpHSXJsaVV2YXo2bk13QmdLeVNFU1pTL1ZlTmhvdzR3WC8rdCtwMDc3?=
 =?utf-8?B?UVhnSmVFaFM0aG16Nks4eGpNdkdNVFlNSjc4czNqdHowK2JtOG8yYWRZZjUx?=
 =?utf-8?B?RVc2WEF0N1JOWmRNVmd5b1hmV3RDSWJqRU12Z0ZSRzJRQ2FRUjM2VUNPc0Rq?=
 =?utf-8?B?VUE2UmhvTTJKNnJ0b1RjQVNMQy9HTllLZWpSOTQ1Wk5tQnR6aFhkRExZbmxE?=
 =?utf-8?B?YkN0anBLSlA5M3hDRzVrQ0c3cjNrNHd1d0YxTm9BeEd2L1N4cnFERHh3SERz?=
 =?utf-8?B?WTJGd1QxeXk3R1NNb1FDc2F6ekpNK2Y3WEtqME5GRnFhb0p6VFZYazE4YWlh?=
 =?utf-8?B?R0U5S0xpeFVMa0VwQVo1YkdjUjV1djQ1M0tpYzFBNkN5ci8vTVBrT2M3OVdh?=
 =?utf-8?B?TEJqSDZObCtiYy9qUkpHWlJnZ3FqOVN2b1d0U3FmS2d4UWNUbEFXS0dyV2xN?=
 =?utf-8?B?Rm5TMkxBSFNsdldYMmhFemZGeEp3dXdIQ0pZZnBsZ3FRa1FCU1R4OVBMWURP?=
 =?utf-8?B?RmtBWXExSEcreU9adkI5Q2E1THJLbHJUTkNTSXc2U1MwdUdCbDNHaXJnaFhq?=
 =?utf-8?B?T0dmWEY4QXRpQldtS096VGQ0N2hPM0RaUFBGbTRMVVB4YVlLSEs0T0M4NDRM?=
 =?utf-8?B?NmQ1YUhPOUh1bDNTTE10dVNwT1BvSkRwSUtNNTl1cTFOUjA3cXFqNkthOVZP?=
 =?utf-8?B?Z0EzMmtRdUNSVjYzdW9sS1Riai9iVlRld245RTFyQ0JTNi9qNG9CSWw5YXNx?=
 =?utf-8?B?L3p3ZnpJbVJrZkRQNnZjZmdLZ2dyMW9UWUhyS0VNakhJOVB4L0JITVY1ZTQz?=
 =?utf-8?B?dm9rSXdmWVJlQUszZllQUWphc0Q2dms2d2NQR21XbGZLR0NtVTJmMzB6K2Zx?=
 =?utf-8?B?RnY2bHhMYzYvYXJKTjJHNmpSUDhSQTFLOS9uajNFZmVkM2VFd29hTis5VEhF?=
 =?utf-8?B?Umk4WithZFptbGtvaHFtK0NkN3h2KzkvM3Y1UUdaZEtXRDlkK3d3ZGxuT0Nj?=
 =?utf-8?B?azcybFE3UXBkTE05azVhbXp2SjdBTU5kemNZNFQ5WXQweWFZMzI2V05MaGFx?=
 =?utf-8?Q?26Z+jwRjBYWhg1uTyZTrh/ELW?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b5dc89f4-b38b-4a0c-ecf0-08dbf1e346e1
X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8403.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2023 20:31:05.4508
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eT9QfhCaobOD8oaSVnCew5sKZ1nzVUSBD/OiWCYqHfNF2h9Oo6hkybk6RDQOcJ4n/UpbIZThjp9P7qu4B26+oA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7218
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 30 Nov 2023 12:31:28 -0800 (PST)

Hi,

On 11/30/2023 14:03, Luck, Tony wrote:
>> Actually, caching of values from an earlier structure to be compared against values
>> in a later structure is what we intend to do here i.e. comparing cached source_id
>> from an earlier structure with related_source_id in a later structure. To hint
>> towards the same, I had added the below comment on top of the static structure's
>> declaration:
>>
>>>>> + * Since GHES_ASSIST is not supported, skip initialization
>>>>> + * of GHES_ASSIST structures for MCA.
>>>>> + * During HEST parsing, detected MCA error sources are cached.
>>>>> + * Flags and Source Id fields from these cached values are
>>>>> + * then referred to determine if the encountered GHES_ASSIST
>>>>> + * structure should be initialized.
>>>>> + */
>>
>> Is this not good enough? Should I make it more explicit?
> 
> I understand now, but missed that the caching and use are across
> different entries in the HEST table.
> 
> Maybe something like this:
> 
>  * Since GHES_ASSIST is not supported, skip initialization of GHES_ASSIST
>  * structures for MCA.  During HEST parsing, detected MCA error sources
>  * are cached from early table entries so that Flags and Source Id
>  * fields from these cached values are then referred to in later table
>  * entries to determine if the encountered GHES_ASSIST structure should
>  * be initialized.
> 
Sounds good! Thank you for this. Will update accordingly and resubmit.

> -Tony

-- 
Thanks,
Avadhut Naik