Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp602761rdb; Thu, 30 Nov 2023 13:05:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IGX55zBejY0eorRnRQQnuh79CgtcgWPJ6Gn1WfQvFt6xrnv2NNEQZ1eMVT7M3PkTbrWdgmZ X-Received: by 2002:a17:903:246:b0:1c5:d063:b70e with SMTP id j6-20020a170903024600b001c5d063b70emr23472955plh.53.1701378316252; Thu, 30 Nov 2023 13:05:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701378316; cv=none; d=google.com; s=arc-20160816; b=DS7MIh+nOSjFPm0m7ZahBmqslbzjk3znXfDqd7NeTVa4OHvRpFi1CLR/JS/24R9YLT 4h/Lqtf9gpBXgHUxsYQ8se0uJcPMUdrZat+DEhlYNeCbj89zSxmknZS9Tl8mpslaEfHs 1h1BBO+zXmjBQw9YLUDRD7FUfy4rFP7YFAEPJWMNeaZycc361aF4VE+Kg8GbcCFi5ig1 UxIWh/G3F615oUeO3gahQc0BcDXozaTAQZhWnVpgiPVVMcPyazbdCuAQoav8JGfUgEzn knlX59jk7tzzvn4UUwL11d3Egi0M41WHOJPlDLCYDp6BtnxLRcUHJtFinBJH+SeTAhyZ f7Gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=BkeGkdQVpH91s/Ww5dazq8MyGLogFTvDChsxFY3gc3E=; fh=AFco+4K2609M2JS3lRPn2VLcBVQOBNMevRbij8JCTlg=; b=TtTnSf3JGj7n12WI1SiRUs6Vo8Vvf6GGW3WHbfOeV4JVReucDW2JfwsgGgPWsKmDt3 mk+Whq2l+43HBlvJu6G09Go0QcWr6y5zSgtV8sECcR2ME+oG2De2Pp0JQLLOwVfugg6A fBfy1AK7yqto5uor0dVI9TEcx00sbHZbQ81y/7IoMc2AVsgcQK3xgPjEvMoI2pVo1a7b JxbNXEt82FNQLVhAWDOw0o/RvUmLIXRWixJYpzn8hwmkwusOWO9+h9LtFHk1l/05wO4d ft3gG6QxyhbojJqtW2gJpaAmjVbxeQf367EOmx/abVnhRsXzZKupAZ0D9+ogP+yCWdpF 5aOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OY00rGQg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id u7-20020a170902bf4700b001cfa7f91403si1882516pls.183.2023.11.30.13.04.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 13:05:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OY00rGQg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id AE959801D24A; Thu, 30 Nov 2023 13:04:51 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376793AbjK3VEh (ORCPT + 99 others); Thu, 30 Nov 2023 16:04:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376386AbjK3VEg (ORCPT ); Thu, 30 Nov 2023 16:04:36 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3201D93 for ; Thu, 30 Nov 2023 13:04:43 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 94A43C433C8; Thu, 30 Nov 2023 21:04:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701378282; bh=lqzEStZR0L5lwWNPbnwIia8GbV3FVO0c24b7gkUIOQE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OY00rGQg65nix2pUBaTEtqsZ9WNsqsURFuEyte3ukcKkfiF9Yp7gCYAidbvKJglkb HZWBKljsJ7JxV1s3uBODYRBSN+bTC0ZiYiHwfaNcjl3OuFZ4PPgnqaZetnyiDXXGsZ g0nWhbdF6A2reE4hF69pC1xOn2svr2G/w6LudWoOGeauXSiB6NRHsVfyF3C4+cK4Aw USi4zlOY9oXOfgafC+9pEgLlVgmEV7uZOX8Mfql9zLRMXst0ZU+Z++UWaGmp6gMs5t FxI8IfjzyX1MD0tPWDoWcWx5xeIeAVVhytg62VIP1BtGaAE3/ATAdE6XzrzuE2G0Qn 48C1dxb+QFFkA== Date: Thu, 30 Nov 2023 21:04:38 +0000 From: Simon Horman To: Andy Shevchenko Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Vinicius Costa Gomes , Jamal Hadi Salim , Cong Wang , Jiri Pirko , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Subject: Re: [PATCH net-next v1 1/1] net/sched: cbs: Use units.h instead of the copy of a definition Message-ID: <20231130210438.GP32077@kernel.org> References: <20231128174813.394462-1-andriy.shevchenko@linux.intel.com> <20231130210339.GO32077@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231130210339.GO32077@kernel.org> X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 30 Nov 2023 13:04:51 -0800 (PST) On Thu, Nov 30, 2023 at 09:03:44PM +0000, Simon Horman wrote: > On Tue, Nov 28, 2023 at 07:48:13PM +0200, Andy Shevchenko wrote: > > BYTES_PER_KBIT is defined in units.h, use that definition. > > > > Signed-off-by: Andy Shevchenko > > Thanks, this looks good to me. > > Reviewed-by: Simon Horman > > Did you consider a patch to update sja1105_main.c? > It also seems to have a copy of BYTES_PER_KBIT. I now see that you did :)