Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <57c7feb8-9529-460d-af4e-db4591177f9f@linuxfoundation.org>
Date:   Thu, 30 Nov 2023 14:34:56 -0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] selftests/breakpoints: Fix format specifier in
 ksft_print_msg in step_after_suspend_test.c
Content-Language: en-US
To:     angquan yu <angquan21@gmail.com>
Cc:     shuah@kernel.org, linux-kselftest@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        linux-kernel-mentees@lists.linuxfoundation.org,
        Shuah Khan <skhan@linuxfoundation.org>
References: <20231128214854.60362-1-angquan21@gmail.com>
From:   Shuah Khan <skhan@linuxfoundation.org>
In-Reply-To: <20231128214854.60362-1-angquan21@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/28/23 14:48, angquan yu wrote:
> From: angquan yu <angquan21@gmail.com>
> 
> In the function 'tools/testing/selftests/breakpoints/run_test' within
> step_after_suspend_test.c, the ksft_print_msg function call incorrectly
> used '$s' as a format specifier. This commit corrects this typo to use the
> proper '%s' format specifier, ensuring the error message from
> waitpid() is correctly displayed.
> 
> The issue manifested as a compilation warning (too many arguments
> for format [-Wformat-extra-args]), potentially obscuring actual
> runtime errors and complicating debugging processes.
> 
> This fix enhances the clarity of error messages during test failures
> and ensures compliance with standard C format string conventions.
> 
> Signed-off-by: angquan yu <angquan21@gmail.com>

Thank you for the fix. Applied to linux-kselftest next for Linux 6.8-rc1

thanks,
-- Shuah