Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Message-ID: <041335a9-32f6-4b3b-8512-0ab462334af1@embeddedor.com>
Date:   Thu, 30 Nov 2023 15:57:55 -0600
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH][next] init: Kconfig: Disable -Wstringop-overflow for
 GCC-11
Content-Language: en-US
To:     Kees Cook <keescook@chromium.org>,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc:     Masahiro Yamada <masahiroy@kernel.org>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Nicolas Schier <nicolas@fjasle.eu>,
        linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-hardening@vger.kernel.org
References: <ZWj1+jkweEDWbmAR@work> <202311301304.28F0C52BA@keescook>
From:   "Gustavo A. R. Silva" <gustavo@embeddedor.com>
In-Reply-To: <202311301304.28F0C52BA@keescook>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 11/30/23 15:07, Kees Cook wrote:
> On Thu, Nov 30, 2023 at 02:52:10PM -0600, Gustavo A. R. Silva wrote:
>> -Wstringop-overflow is buggy in GCC-11. Therefore, we should disable
> 
> Can you add some links for this? For example, maybe this?
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97490
> 
> Or discussions from -next builds?

Done. :)

> 
>> this option specifically for that compiler version. To achieve this,
>> we introduce a new configuration option: GCC11_NO_STRINGOP_OVERFLOW.
>>
>> The compiler option related to string operation overflow is now managed
>> under configuration CC_STRINGOP_OVERFLOW. This option is enabled by
>> default for all other versions of GCC that support it.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> 
> But yeah, let's get this landed to keep new warnings from appearing...
> 

I just applied this to my -next tree.

> Reviewed-by: Kees Cook <keescook@chromium.org>

Thanks!
--
Gustavo