Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp736329rdb; Thu, 30 Nov 2023 17:56:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IEqwYTgtaMi5+ZJ2aNawShAkfMjCgoGEubWU6dydP4hPpK54MJSCD+9Lgyn/5iZndD9xN9y X-Received: by 2002:a17:90b:3ec8:b0:285:936a:86b5 with SMTP id rm8-20020a17090b3ec800b00285936a86b5mr21175520pjb.20.1701395778385; Thu, 30 Nov 2023 17:56:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701395778; cv=none; d=google.com; s=arc-20160816; b=VBMFZCL21iSu8BlrQSnsZ9T6jrJwWchx8Ju/4U5ITDpqy3FRbEYpnNuRk0zfpS9F5R 7cmaYIa3WNZ7BtquJEVNmf9gYblrYzUAUTCy6FGUJ+OwrhPvcl45aIlmCHF9IftWHMRr MpPPfFsyZL4RnyK5lzmGIWcddfbHegC2c/C9zvWBzWx5VQtvlS/xypX02SXm5JGlJECy fSy5CnL7oLgnm6iYyEvwJyxOZ7F3PiCZpapFsDm6sLKaGf6P9TSOKlGOEaRkHf3QOVv4 bxycVzEorY015Vgjru1ETk7GnhKqJ2dGP1W/4GqqpgKFWfBUPrmCA3bwa81H6/nOAdXt M0ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:dkim-signature; bh=Gpg0jRMfZzPs+DxGvN7fA6pxlWT05UdkEs/pO3pcReg=; fh=WBYQFSJy0VKnj0fKIhFg1FF1CgxP34EjbGPtLvDuGcQ=; b=yrnUycgOnRnpJ7PVXcXUp+f98zsXIJ7pu8Q3ZWaUeX+Gb+Bts8OsQ0QLf+1cUAqMkx pBaEMkeGy1qMx9ENUdxrCsjbWPcH91OGk/FaWrkpWQu0BgXUm+HVkAJHcBoVQAk/af/C P8+f9gqbf0n6lkPnOHfQX0dCvd8uNQ6mmaiecA64K81hzD4mcM3rRZHd2QYI+DNtMZuO KkcHhag/+ulldm1TmLYNs3w0i966JiYaZeGu6HXckaQCbtTJNdSCi/LNxAujfwYffigX laWgjkL6uaD3JEjjZWtlb3bxzA05P+FypPLng3R0JISD8EsvF1h6tw2TxoPdRt/TYcIR qzbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=2IDYwr3z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id mv5-20020a17090b198500b002864fceae0esi1131740pjb.162.2023.11.30.17.56.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 17:56:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=2IDYwr3z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id D170980F6D1E; Thu, 30 Nov 2023 17:56:15 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230310AbjLAB4C (ORCPT + 99 others); Thu, 30 Nov 2023 20:56:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229808AbjLAB4B (ORCPT ); Thu, 30 Nov 2023 20:56:01 -0500 Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7ED0F4 for ; Thu, 30 Nov 2023 17:56:07 -0800 (PST) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-5d3bdbf1fb5so11423757b3.2 for ; Thu, 30 Nov 2023 17:56:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1701395767; x=1702000567; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Gpg0jRMfZzPs+DxGvN7fA6pxlWT05UdkEs/pO3pcReg=; b=2IDYwr3zmhFsRLV5KrY1UDgjkBoZb36qbFtvi6bwzpMY+6k0rRNVBkstydlj52Fuf6 S929fjQVQ4I5Ngv0WWFSDlITPwIcJ+3d9rAA8v1hV7EkqL1QDENupL6SnbnIJDnUW599 FCTfcWYcwPueHvjSp0Kn950WdADmJUQTF/kwCNXVxBT9+EL6q0EgoPC19OXssgxpx24W iI9mZv2fm0afxOVTxGl675ZauJAZ4ALslknmjMsWEGr3ZLEodNfNWkrjcvHuTPRzJkyJ kO6nT+cHT9oAry8KGfMWDIfyhPtnYDci+WYehW3XWCuSx97OcJ89eaOqSXk/pwSpsnQO dQVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701395767; x=1702000567; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Gpg0jRMfZzPs+DxGvN7fA6pxlWT05UdkEs/pO3pcReg=; b=OTfln1rD5lAQ3Dud2WtXfOf7yHzmCvzt8dpgo0xBO8QRCDABiMBgxEb4ZSMhlfcVku /hQJjWFjY4l8wlysVcXWOUflZ9shQZO4WYsC+6z/3CH95cwP8630mAFMq4JiqPMg/rkf x7IHygMZH6wQ1XKShsuMT8a7wTLushhjR5mUv2GZY7io1+j9JyRdzmZ3YcyU4cyFR+UK jii7gXLSDPWHQsXBkabsfD1GtinXpI0+ECIQ0oygMLK5/wJXhSoIHLAoT4/PLXk1xj23 i+FbYFFthYm/HmY2sLYFtPnfRbkDFDtMcVdeTe7bzeG3TXZJJI27q/YYnyZd8wZ9fNdR my7A== X-Gm-Message-State: AOJu0YzPfLDncBb9mjQ0ndiz1waxkSJI7053xxz1Ufk6PWweR2nxNA0H ED48QLQPdMtSBqa1+XMC945vmEMk7AU= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a81:ff08:0:b0:5cb:1bf4:ce09 with SMTP id k8-20020a81ff08000000b005cb1bf4ce09mr798787ywn.2.1701395767042; Thu, 30 Nov 2023 17:56:07 -0800 (PST) Date: Thu, 30 Nov 2023 17:52:22 -0800 In-Reply-To: <20231125083400.1399197-1-pbonzini@redhat.com> Mime-Version: 1.0 References: <20231125083400.1399197-1-pbonzini@redhat.com> X-Mailer: git-send-email 2.43.0.rc2.451.g8631bc7472-goog Message-ID: <170137684485.660161.8230111667906795222.b4-ty@google.com> Subject: Re: [PATCH v2 0/4] KVM: x86/mmu: small locking cleanups From: Sean Christopherson To: Sean Christopherson , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Paolo Bonzini Cc: mlevitsk@redhat.com Content-Type: text/plain; charset="utf-8" X-Spam-Status: No, score=-8.4 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 30 Nov 2023 17:56:16 -0800 (PST) On Sat, 25 Nov 2023 03:33:56 -0500, Paolo Bonzini wrote: > Remove "bool shared" argument from functions and iterators that need > not know if the lock is taken for read or write. This is common because > protection is achieved via RCU and tdp_mmu_pages_lock or because the > argument is only used for assertions that can be written by hand. > > Also always take tdp_mmu_pages_lock even if mmu_lock is currently taken > for write. > > [...] Applied to kvm-x86 mmu, thanks! [1/4] KVM: x86/mmu: remove unnecessary "bool shared" argument from functions https://github.com/kvm-x86/linux/commit/2d30059d38e6 [2/4] KVM: x86/mmu: remove unnecessary "bool shared" argument from iterators https://github.com/kvm-x86/linux/commit/59b93e634b40 [3/4] KVM: x86/mmu: always take tdp_mmu_pages_lock https://github.com/kvm-x86/linux/commit/4072c73104f2 [4/4] KVM: x86/mmu: fix comment about mmu_unsync_pages_lock https://github.com/kvm-x86/linux/commit/9dc2973a3b20 -- https://github.com/kvm-x86/linux/tree/next