Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
MIME-Version: 1.0
References: <20231201125648.71d7586d@canb.auug.org.au>
In-Reply-To: <20231201125648.71d7586d@canb.auug.org.au>
From:   David Regan <dregan@broadcom.com>
Date:   Thu, 30 Nov 2023 21:03:00 -0800
Message-ID: <CAA_RMS5THkAQxEPWvtpcbb=F-G1xdntZPTmzhAhvK6voWi6VOA@mail.gmail.com>
Subject: Re: linux-next: build warning after merge of the nand tree
To:     Stephen Rothwell <sfr@canb.auug.org.au>
Cc:     Miquel Raynal <miquel.raynal@bootlin.com>,
        Boris Brezillon <boris.brezillon@collabora.com>,
        Boris Brezillon <bbrezillon@kernel.org>,
        David Regan <dregan@broadcom.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Stephen,

from this post:
https://github.com/bbrezillon/linux/commit/e612e1f2c69a33ac5f2c91d13669f0f1=
72d58717

Looks like this comment needs to be added:

* @deassert_wp: set to true when the operation requires the WP pin to be
*                         de-asserted (ERASE, PROG, ...)


What's the best way to go about doing this?

Thanks!

-Dave


On Thu, Nov 30, 2023 at 5:56=E2=80=AFPM Stephen Rothwell <sfr@canb.auug.org=
.au> wrote:
>
> Hi all,
>
> After merging the nand tree, today's linux-next build (htmldocs) produced
> this warning:
>
> include/linux/mtd/rawnand.h:1016: warning: Function parameter or member '=
deassert_wp' not described in 'nand_operation'
>
> Introduced by commit
>
>   e82a5a014dd5 ("mtd: rawnand: Add destructive operation")
>
> --
> Cheers,
> Stephen Rothwell