Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <9075f00e-f914-4739-aae2-ba4ccfd6236b@link.tyut.edu.cn>
Date:   Fri, 1 Dec 2023 12:56:14 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] scripts/show_delta: reformat code
To:     Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc:     gregkh@linuxfoundation.org, akpm@linux-foundation.org,
        masahiroy@kernel.org, ndesaulniers@google.com, n.schier@avm.de,
        ojeda@kernel.org, linux-kernel@vger.kernel.org
References: <20231130143822.17173-1-2023002089@link.tyut.edu.cn>
 <CANiq72nS9_uPXNXc6mORtWsBEUB7JBWeUW+aAQ0Osqnca3vaVA@mail.gmail.com>
Content-Language: en-US
From:   Hu Haowen <2023002089@link.tyut.edu.cn>
In-Reply-To: <CANiq72nS9_uPXNXc6mORtWsBEUB7JBWeUW+aAQ0Osqnca3vaVA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 2023/12/1 01:13, Miguel Ojeda wrote:
> On Thu, Nov 30, 2023 at 3:49 PM Hu Haowen <2023002089@link.tyut.edu.cn> wrote:
>> -                               if string.find(rest, base_str)==1:
>> +                               if string.find(rest, base_str) == 1:
> If this is changed, shouldn't be others like:
>
>>                  if arg=="-b":
>>                  elif arg=="-h":
> be changed too?


Sorry, ignored by accident. I'll make up within the next patch version.


> In other words, it seems this was done manually. Should we instead
> introduce/use something like Black or Ruff if we are going to do this
> sort of changes?


I'm sorry but I'm not familiar with these two things. Are Black and Ruff
some kind of tools which help identify these code format issues? If so
it is better to introduce them to assist to accomplish the similar
series of work instead of only completing it manually with avoiding
omitted parts simultaneously.

Thanks,
Hu Haowen


> Thanks!
>
> Cheers,
> Miguel
>