Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Fri, 1 Dec 2023 14:10:51 +0800
From:   Yujie Liu <yujie.liu@intel.com>
To:     Sean Christopherson <seanjc@google.com>
CC:     Vitaly Kuznetsov <vkuznets@redhat.com>,
        kernel test robot <lkp@intel.com>,
        <oe-kbuild-all@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
        "Paolo Bonzini" <pbonzini@redhat.com>, <kvm@vger.kernel.org>
Subject: Re: arch/x86/kvm/vmx/hyperv.h:79:30: sparse: sparse: cast truncates
 bits from constant value (1b009b becomes 9b)
Message-ID: <ZWl466DIxhF7uRnP@yujie-X299>
References: <202311302231.sinLrAig-lkp@intel.com>
 <87v89jmc3q.fsf@redhat.com>
 <ZWjLN3As3vz5lXcK@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZWjLN3As3vz5lXcK@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?AR2JJ1sgETxR0GPv5qAxxXXug/FmSQHNYCscQtKIJuH0ax1LIRYb1bA5AMFH?=
 =?us-ascii?Q?e9bCCTILfSyvvzVR6g+ev09bxz9y+c5GL+UE4WCZtR10SoL7fdXRPwEKmhH9?=
 =?us-ascii?Q?mlC2GvJn/CN0LksjC9LcwD0Hvsd218E7J0ZOyjdi26ZvX3bG0ede1stsokVN?=
 =?us-ascii?Q?HsHmwFHL0nLVm0vVft86T7MTFNZPggM+w7f0CLW2liSRATAkv1wK0EsLv1v1?=
 =?us-ascii?Q?YHhWayMx/Nqn9vx8rOaa0tIXVCMuRYqx5u6UzspDyyKIv98EksFbqstZ1+YM?=
 =?us-ascii?Q?hxyrWhn/xpZ0PyI2SssBErxjXJixnEalzzzD81p+sCDeaSjYknLDRq5xSzc4?=
 =?us-ascii?Q?pre7wVNKm4ekATggHHsdU5m/DUTYA+o7/njuW/ZMPZa1jRJPV6HcrAekP7Wy?=
 =?us-ascii?Q?qXHSiuFiLfBNz14frim45aR30nCC8Er332NH5CVVe+fF3C3d3YCJiM1L07uS?=
 =?us-ascii?Q?xUNmkYbOjB03p0ZSwzaD5dcUGpy7WUcyLpj5sSC32obepdPLsBodf+2ELzps?=
 =?us-ascii?Q?HWKfnOtmo7B8cyhB0GN9BRN23oxvbLvmAIewivVwsLuNAXLhMY/y2alRLonm?=
 =?us-ascii?Q?kpkXzQ0VkuxP90NcohWfelD9lLgultRYM1CZoIZcNKNnhDkeKXhk14QSGL1c?=
 =?us-ascii?Q?yz3TSU/K5ymS/AQpScoC0PPgIWfaxigHR3XRTr4Krjmpz+/7AA11kCl+HeJh?=
 =?us-ascii?Q?rHBxaiLE2sPP9nSngwNTt2PiCjkllDubh+mxNVASQD5Ox9Lgdcs410M+JMPi?=
 =?us-ascii?Q?VSf/wvovE+nOBvTlF3oWi06g6/329qnUrRb9IRjP+KaEjRzJNzbFN/DGM4cl?=
 =?us-ascii?Q?wasdCxnQZO9hmllJ2PcVA+fcaQfcWRDHGJpWh0Zszv9hZxPV5fkoAV6jVSFS?=
 =?us-ascii?Q?jMr84lMGgShkEnKPso55+gAiANUvY6jQhJOFxXciA55TtqJb3CrIKFttAi3J?=
 =?us-ascii?Q?PyqNHHhRXg7oiTidx+Aqx+1zTL1thk0b3IDQx5q6ojQ1yolB377tMYs+Vw6H?=
 =?us-ascii?Q?ekovrLUZcfj0Fhvm21RePp1EV2VV/ProSjW1+YGd3r+luDL11I+WzYm3+fHX?=
 =?us-ascii?Q?RmiLeahgKWCTlnqkGysvMdde0t6aT3MOFnrCcl3lFBckJrYDSTqIsf4DR9TL?=
 =?us-ascii?Q?IC4plfGD6ss2P/Jc6K+pPgn7bVMq5NahSBReSi5gmrK5zfDjUGWJ+fECheoq?=
 =?us-ascii?Q?B9LW3HpJmX/fziP9FlR2MQNSuFnbzaAO0Kn+U0bt1PXqJcTu4VFQduavj7iY?=
 =?us-ascii?Q?/duEU+v4GmY1D7P8P/zRcK9fhb9vn9indqLKityDzCzu/S6GzopgaUh/rUkX?=
 =?us-ascii?Q?c3EfMrJNYwJc0Sf2NiBDm9zQOM5NyvJu4py8aWn3YUGhQthxKMHlBYNXRElV?=
 =?us-ascii?Q?YawpF37H7qOoRlDk2z+KOWp6S5nF2gcmvpqE0giXqHTXyrvdmaq5XIiY+Uy5?=
 =?us-ascii?Q?p77+MNnJUuDIqtKqYuluWywAaMwnyvCKqFdmcNyTPpfGJjy5o3C7x+eW91x0?=
 =?us-ascii?Q?hj0oW6VLG6ry41SvazRTieOzoB7bj6PpuNV6IX4SKRHacnbW7VtmV9/WFK7M?=
 =?us-ascii?Q?RRuaOcDzmfVxgFu900ncx5TH9DO3yKuxrAsYyJk3?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cd01aab8-2687-458c-08b3-08dbf234e8cf
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6392.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2023 06:15:26.2350
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1JbGH5fIgaVDBw5VSZrYJQC1a3bylSVOr57Lzv7TX/e9nF2O7MFv9bNnACIQw8rKH0qmFdix4dK+mi+MRYetAA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7789
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 30 Nov 2023 22:15:40 -0800 (PST)

On Thu, Nov 30, 2023 at 09:49:43AM -0800, Sean Christopherson wrote:
> On Thu, Nov 30, 2023, Vitaly Kuznetsov wrote:
> > kernel test robot <lkp@intel.com> writes:
> > 
> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > > head:   3b47bc037bd44f142ac09848e8d3ecccc726be99
> > > commit: a789aeba419647c44d7e7320de20fea037c211d0 KVM: VMX: Rename "vmx/evmcs.{ch}" to "vmx/hyperv.{ch}"
> > > date:   1 year ago
> > > config: x86_64-randconfig-123-20231130 (https://download.01.org/0day-ci/archive/20231130/202311302231.sinLrAig-lkp@intel.com/config)
> > > compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
> > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231130/202311302231.sinLrAig-lkp@intel.com/reproduce)
> > >
> > > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > > the same patch/commit), kindly add following tags
> > > | Reported-by: kernel test robot <lkp@intel.com>
> > > | Closes: https://lore.kernel.org/oe-kbuild-all/202311302231.sinLrAig-lkp@intel.com/
> > >
> > > sparse warnings: (new ones prefixed by >>)
> > >    arch/x86/kvm/vmx/hyperv.h:79:30: sparse: sparse: cast truncates bits from constant value (a000a becomes a)
> > 
> > This is what ROL16() macro does but the thing is: we actually want to
> > truncate bits by doing an explicit (u16) cast. We can probably replace
> > this with '& 0xffff':
> > 
> > #define ROL16(val, n) ((((u16)(val) << (n)) | ((u16)(val) >> (16 - (n)))) & 0xffff)
> > 
> > but honestly I don't see much point...
> 
> Yeah, just ignore 'em, we get the exact same sparse complaints in vmcs12.c and
> have had great success ignoring those too :-)

Thanks for the information. We've disabled this warning in the bot to
avoid sending reports against other files with similar code.

Best Regards,
Yujie