Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Fri, 1 Dec 2023 01:49:43 -0500
From:   Wei Gao <wegao@suse.com>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     mingo@redhat.com, peterz@infradead.org, dvhart@infradead.org,
        dave@stgolabs.net, andrealmeid@igalia.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] futex: Add compat_sys_futex_waitv for 32bit
 compatibility
Message-ID: <ZWmCB5AL0sULlOFs@wegao>
References: <20231123053140.16062-1-wegao@suse.com>
 <87a5qwz3dr.ffs@tglx>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87a5qwz3dr.ffs@tglx>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?n7ehahfRV/LulOkGJqIkZwDdk9A1M7WJZ5TIKKN6VdBHYy6VnzkrRlX0J/Vw?=
 =?us-ascii?Q?bJmjfoDHCywoVCDI/c83y5KxTzf7BDxZL5zm++xFFVoIsTTJ4SsO+QAtqXtP?=
 =?us-ascii?Q?4xWUCW5oGL5BR4TtwDgoU2gdJSmdfdg7rD+0OKEbcIrqY1p5CJIYH/nsqyM3?=
 =?us-ascii?Q?1v31eziDVcPqJ5e3BT8UJsk3P6m1dAzAc+jfyKjg7POLtQdMetAcVlDFfXUN?=
 =?us-ascii?Q?evBf2T04caCFVKzgGGzVq31ffCJrA8VAOUu29vJQqqKJp+nF/rQ9xQq7+exR?=
 =?us-ascii?Q?+mbcJ1pd8Hs1DErc0No+MG4hvw2/9wk+M1qMUW1k+Mmx9X5b1j5IfkLUKpqU?=
 =?us-ascii?Q?T4HrY2L6hXGBvJBrHfwulFPS/q3/MeiQj0xRZc3BlqhlvFRAZgb0JWwVdwZ3?=
 =?us-ascii?Q?ymEpvNQhoPR4nwh4YA45oghDEpn/u9K+yb6UoR9mfh8Rzv7FUIn/V5HF7IH6?=
 =?us-ascii?Q?GGayE8hKIxd6njX/j2VK6c90K9ZD//9uripiuwwJikSIMue2kcQZmQIoEBeD?=
 =?us-ascii?Q?nGCwn6k/GpqQaYB04Ac9lBFCHm2K8WHiXu/UYSWXCYlqKfeUzWi64eJmkMpc?=
 =?us-ascii?Q?N++Iqopdp1ObJNFLbN3heXre/qDHIcf+QKrFXYLNJom6ScXMJ1T9ioKu9aiD?=
 =?us-ascii?Q?UEtgUCt/0o84wNAivyL5oH3xbIYNLaxmXiFew1FVhURQBYR9clS0qdTr8O4L?=
 =?us-ascii?Q?gVecEUl8LXm1GmToSDpUL6xTADSAiOux569zRIot+2mNp3L97RW2tkNqHeFC?=
 =?us-ascii?Q?9onGUrdKANQBSH8oGjxbEi+2xeNgWcIQacBvM4Ef7nN49EfSF8c86E/CPzM9?=
 =?us-ascii?Q?fDbnCGP2RLER5Uu+9sOzV2yrtiWWAPQS5tT115uYvftnrLM4Ny9BxSF1w+m+?=
 =?us-ascii?Q?ug4NMTvvt+zBt0rBuVoNL1r+B7h+G0Oozvx73GBstk7EbPtCRAzKV+kT+ygt?=
 =?us-ascii?Q?3KO6Z8BkflIm80dZTr/rblZ8JVrUqSTsLysy4NNoAcMSIVW49HnP4M+ElTVX?=
 =?us-ascii?Q?92w7wyLHjVJWDx8RRu7WnpvMNN5/rplCayBEuu5v+SCTYlgOSYtAR2jmlS6G?=
 =?us-ascii?Q?9FfXWiplCfUalqUdQXQU+yeyblNL4G2XmwTGq6agHXfvjIHDNrkRY24mSyc0?=
 =?us-ascii?Q?UbVet3vWxb0fZzgVRt67QKL1LVfASxuQ7tOyV+xBccL4n4BLgoDHXr8jy0RM?=
 =?us-ascii?Q?1SLLR/jUzCIFdEXYRKf0R0d8yE3y2CRuE1u/a/TaqxFqAs2Dmnkle2YzroId?=
 =?us-ascii?Q?9JKWbP7cXgrtsVWPAqvBfByjoTUJ8L/a/cwQnGJtZGvWq7vzuarvJOFhM8/0?=
 =?us-ascii?Q?87QcSsR9UVIbewteH0tpIQlETOKBgcfg+g283QECBr5En3fTkywfkIssyvEk?=
 =?us-ascii?Q?Lq3GjtW7b35aOq6k2zlISxLTWCQGPHSyJdWE9DgWg+zuFbiYVv6KoQls3bvJ?=
 =?us-ascii?Q?bthkZrsnFCAPOxY2lDcipGw9Giw7SZoiKtNHkBJTZ4Qj9MG6ts+c81mV/Z/c?=
 =?us-ascii?Q?WCmm8kSCuhpq0aQrNjP/PXtkyiFD88LdlcZAuOj/Sa0PK0ONc9YJbiQIGObG?=
 =?us-ascii?Q?yQ/qC16XqhlBTQ8AMu8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 362b204d-2a52-4b81-58fc-08dbf239b757
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8199.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2023 06:49:50.7076
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JHELEMaE24lFeU6UR+mnNx3jg6YQjPmjLWWXNQpbidplgpRNtKLYRsvYfhYa89mE
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8661
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 30 Nov 2023 22:50:18 -0800 (PST)

On Wed, Nov 29, 2023 at 09:54:56PM +0100, Thomas Gleixner wrote:
> On Thu, Nov 23 2023 at 00:31, Wei Gao wrote:
> > The new function copy main logic of current sys_futex_waitv, just update parameter
> > type from "struct __kernel_timespec __user *" to "struct old_timespec32 __user *,"
> > and use get_old_timespec32 within the new function to get timeout
> > value.
> 
> That's not how it works.
> 
> struct __kernel_timespec is the same on 64bit and 32bit syscalls.
> 
> User space has to use the proper type when invoking a syscall and and
> not just decide that it can use something arbitrary.
> 
> All new syscalls which deal with time use the Y2038 aware data types and
> do not have compat fallbacks because there is no requirement to have
> them.
> 
> If user space want's to use struct timespec on 32bit nevertheless in the
> programm for a new syscall, which is obviously stupid in the context of
> Y2038, then it's a user space problem to convert back and forth between
> the two data types.
> 
> Fix LTP to be Y2038 safe instead.

Thanks a lot for your suggestion, will check it.

> 
> Thanks,
> 
>         tglx