Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Date:   Fri, 1 Dec 2023 07:49:13 +0100
From:   Nicolas Schier <n.schier@avm.de>
To:     Hu Haowen <2023002089@link.tyut.edu.cn>
Cc:     gregkh@linuxfoundation.org, akpm@linux-foundation.org,
        masahiroy@kernel.org, ndesaulniers@google.com, ojeda@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] scripts/show_delta: reformat code
Message-ID: <ZWmB67THrLcztb-3@buildd.core.avm.de>
References: <20231201053540.9534-1-2023002089@link.tyut.edu.cn>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="x9YCRS3AC2fWuNsT"
Content-Disposition: inline
In-Reply-To: <20231201053540.9534-1-2023002089@link.tyut.edu.cn>
Organization: AVM GmbH
Precedence: bulk


--x9YCRS3AC2fWuNsT
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Fri, 1 Dec 2023 07:49:13 +0100
From: Nicolas Schier <n.schier@avm.de>
To: Hu Haowen <2023002089@link.tyut.edu.cn>
Cc: gregkh@linuxfoundation.org, akpm@linux-foundation.org,
	masahiroy@kernel.org, ndesaulniers@google.com, ojeda@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] scripts/show_delta: reformat code

On Fri, Dec 01, 2023 at 01:35:40PM +0800, Hu Haowen wrote:
> Correct some lines in irregular coding style to make them look more
> harmonious and fit the common coding regulations in Python.
>=20
> Signed-off-by: Hu Haowen <2023002089@link.tyut.edu.cn>
> ---
>  scripts/show_delta | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
>=20
> diff --git a/scripts/show_delta b/scripts/show_delta
> index 291ad65e3089..33446adce74b 100755
> --- a/scripts/show_delta
> +++ b/scripts/show_delta
> @@ -13,7 +13,7 @@ import sys
>  import string
> =20
>  def usage():
> -	print ("""usage: show_delta [<options>] <filename>
> +	print("""usage: show_delta [<options>] <filename>

Hi,

thanks for your patch.  What Miguel already noticed for v1 is valid for
v2, too: there are still inconsistencies in the coding style, e.g.
`print (...)` and `print(...)`.

To simplify a consistent coding style for future work on the script,
using an external tool for reformatting (and mentioning it in the commit
message) would be helpful.  Miguel suggested Black or Ruff, I think this
is a good idea.

Kind regards,
Nicolas

--x9YCRS3AC2fWuNsT
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEDv+Fiet06YHnC6RpiMa8nIiabbgFAmVpgekACgkQiMa8nIia
bbiuKA//Var3w983693LJ/e1B3Mn0KJvP4LlvdFlcoevj6NnSa4RLO7BFVLwPfPN
LV/v4Be6+Qe8SwLwCZTL1QPyF98F1tP9/zHetlEnMw2zG+Il+dvAqmpkc4bmYntu
JROh0n9C9hUmka0xiEYrEPgU7sEn6HXXjhiqliLCfeEsnmnaFdLr6RIAo7n5U5Za
kxVZc+Inp4wi3sGD2QnzuJOEMUgvtrSJBtQYniWz54ZZju0cMqGZWAzK7PMItcen
fwzh38U3UC/p7bACiZPz/BLDqVOyISZV4TT7geMUUPHLs+U7wY/kovZEoNVSMqBQ
/nV4t2xaQ0+xifxRHGHSHIWhzJl5Q4SDKTsxXR0hRXQK6hHWwILFUjq6s52GecNi
coUWrp0zqh/qniCPGvSWaH9xkYBhTJKj5V45eiFdhzn/bAIa+OuKE8si0aF7ZJ1t
519hXo017GU9IUQCu0tqMXs4J02flRgdFjcqvaW4zmOu1npKxkAGxkJe3so0xKnV
/2e4kwsiYgEqAfoVXINJk9CD9D1C8+Szh9bv9wbpidELRlQnve3PdgrrocRZX2JO
S6/1hR6AwJXfBYQ+xbZZZeVM6HHhHBlAL55+GNb1CAlBGq8TF0Xgl9V4nsSko3Hc
aPIYEaRdPJUycLNP3NXI3R+NXI8TTBjgDJaKlTJQFYJ26PaK4Yw=
=fejp
-----END PGP SIGNATURE-----

--x9YCRS3AC2fWuNsT--