Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Fri, 1 Dec 2023 07:12:15 +0000
From:   Carlos Llamas <cmllamas@google.com>
To:     Alice Ryhl <aliceryhl@google.com>
Cc:     Arve =?iso-8859-1?B?SGr4bm5lduVn?= <arve@android.com>,
        Christian Brauner <brauner@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Joel Fernandes <joel@joelfernandes.org>,
        kernel-team@android.com, linux-kernel@vger.kernel.org,
        Martijn Coenen <maco@android.com>,
        Suren Baghdasaryan <surenb@google.com>,
        Todd Kjos <tkjos@android.com>
Subject: Re: [PATCH 13/21] binder: relocate low space calculation
Message-ID: <ZWmHT4CfFdadT1bB@google.com>
References: <20231102185934.773885-14-cmllamas@google.com>
 <20231107090826.259454-1-aliceryhl@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231107090826.259454-1-aliceryhl@google.com>
Precedence: bulk

On Tue, Nov 07, 2023 at 09:08:26AM +0000, Alice Ryhl wrote:
> Carlos Llamas <cmllamas@google.com> writes:
> > Move the low async space calculation to debug_low_async_space_locked().
> > This logic not only fits better here but also offloads some of the many
> > tasks currently done in binder_alloc_new_buf_locked().
> > 
> > No functional change in this patch.
> > 
> > Signed-off-by: Carlos Llamas <cmllamas@google.com>
> 
> One suggestion below, but I'm fine either way.
> 
> Reviewed-by: Alice Ryhl <aliceryhl@google.com>
> 
> 
> Carlos Llamas <cmllamas@google.com> writes:
> > +		if (debug_low_async_space_locked(alloc))
> > +			buffer->oneway_spam_suspect = true;
> 
> You could avoid a branch here like this:
> 

Sure, sounds good to me.

--
Carlos Llamas