Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp848368rdb; Thu, 30 Nov 2023 23:16:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IFvAkzIMk8Kj8tc+/XAdpobQgL8TJskiOi2ERPrunohGGXlDSNv/LECFdVtrij/navTg3Tn X-Received: by 2002:aa7:8ed1:0:b0:6cd:f3e9:810a with SMTP id b17-20020aa78ed1000000b006cdf3e9810amr3165735pfr.11.1701414997402; Thu, 30 Nov 2023 23:16:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701414997; cv=none; d=google.com; s=arc-20160816; b=wZrOSEtpP4nA+lgND9xJFdoki0O+da7j3CZLWRFxdqHhyD2XknfF16Di5o4mLd3Noq ZnU86Fk4qZ+J/Jg4Lz6umbDqcvUVt8dncGCINKnWoxkCZXgaN5ABOaU2HTEn48eIv6Hy ASDWzdx6hAFKkIkz3RQiXGO4nY7zhX2BiysIdXNKVMEcaadM/O3kLqyTZ7I/At176KO6 M4z/uV4fsxIvPvJSMevVCjBA2OcZx3CNwSeqvKsLrxI2AfnGltagNFg2fa1bl4ANgMUK JmVpdi+iMlZwV0ktD4Dx6ClcuaNH+9z78oSmPGSMzywHWFz5i6Jdf799//AJf8bHmn52 qirA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=Byj91Ej1EY7HzcTwWDJJRjUiWvxr41vFikduqu8D8xE=; fh=UpROfqWAWMTOE5yZJodaszPIid23j4o+xd5xXV9qfmk=; b=ZsIb1xQoRhMeb7BAiraXyjJz5SlV08mk/Z+nrVGT0OOKTdWD9XjEDYLcQnz411kex9 05pzsgqkL3CaFoE2+0WtB9rKb2bavXe6y18Wi2ebiKj7PXd2rZxb7/iJcoorzLQ61e5E 6T7ZGoCjXunjew/zAZ6nkVXpIvwba+eOGAiJKyoRaVKRkR/33wT9Li1HdOlJ7xW00mDl NqGdVUwD6ymST4Dts+gwSy+mD+/03lteClk9hheLd4WH6VRIuzcWfcaj0I/MnwrHr/rJ CT1rUA6HQ1q4fXwCiBzslMVo9Juo7wpReG/g/fEqeO7X6P9ygWNtJT+O4d6V8MgueOiy o8XA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=b7lbX6E9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id x191-20020a6386c8000000b005be1ee5b9dfsi2813589pgd.454.2023.11.30.23.16.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 23:16:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=b7lbX6E9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 26396831AEB6; Thu, 30 Nov 2023 23:15:34 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229768AbjLAHPT (ORCPT + 99 others); Fri, 1 Dec 2023 02:15:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229496AbjLAHPS (ORCPT ); Fri, 1 Dec 2023 02:15:18 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C36710FD for ; Thu, 30 Nov 2023 23:15:25 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 86B5DC433C8; Fri, 1 Dec 2023 07:15:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701414925; bh=CNZZ/9juIG0OKqeCsO8gwDQtYKzOzJvLw6s4b85gygc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=b7lbX6E9Atn0nM6nUkJOXvJ+YXnvvVQOBP2sYOjYBPcclVzf6WHHGgKnA1gq2ttWT dHrzt+cU+6aeAbyDzCORYpaRuSmUenP9+ObSY/DjxT1w0bc28kVu26xPBdONHICl1g 1WercqzES8h+hy0PjTeBQug8GviZrNeMPIblM0VTIxD84kZEEP7OPPAi5pd+ISxAaY tvivvH7BVAU9LrbwMiV5j6d/+5EPWcP4NaAJ8mtt2pDbGCOawySReq84/pKuGLGj5u oAFFfXByC4nusyblyyqQADkO8p2Pp9GRPYrXDURtCj+Zasvu7lkwfnd8M/BPxzgnvb iLvePxfTOoQpw== Date: Thu, 30 Nov 2023 23:15:23 -0800 From: Jakub Kicinski To: Dan Carpenter Cc: Shinas Rasheed , Veerasenareddy Burru , Sathesh Edara , "David S. Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH net-next] octeon_ep: Fix error code in probe() Message-ID: <20231130231523.267c08a5@kernel.org> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 30 Nov 2023 23:15:34 -0800 (PST) On Tue, 28 Nov 2023 16:13:19 +0300 Dan Carpenter wrote: > Set the error code if octep_ctrl_net_get_mtu() fails. Currently the code > returns success. > > Fixes: 0a5f8534e398 ("octeon_ep: get max rx packet length from firmware") > Signed-off-by: Dan Carpenter Sathesh, Veerasenareddy, please review. See: https://docs.kernel.org/next/maintainer/feature-and-driver-maintainers.html#reviews -- pw-bot: needs-ack