Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Fri, 1 Dec 2023 07:19:05 +0000
From:   Carlos Llamas <cmllamas@google.com>
To:     Alice Ryhl <aliceryhl@google.com>
Cc:     Arve =?iso-8859-1?B?SGr4bm5lduVn?= <arve@android.com>,
        Christian Brauner <brauner@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Joel Fernandes <joel@joelfernandes.org>,
        kernel-team@android.com, linux-kernel@vger.kernel.org,
        Martijn Coenen <maco@android.com>,
        Suren Baghdasaryan <surenb@google.com>,
        Todd Kjos <tkjos@android.com>
Subject: Re: [PATCH 16/21] binder: refactor page range allocation
Message-ID: <ZWmI6QxlDuV-Miyr@google.com>
References: <20231102185934.773885-17-cmllamas@google.com>
 <20231107090835.260342-1-aliceryhl@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231107090835.260342-1-aliceryhl@google.com>
Precedence: bulk

On Tue, Nov 07, 2023 at 09:08:35AM +0000, Alice Ryhl wrote:
> Carlos Llamas <cmllamas@google.com> writes:
> > Instead of looping through the page range twice to first determine if
> > the mmap lock is required, simply do it per-page as needed. Split out
> > all this logic into a separate binder_get_user_page_remote() function.
> >
> > Signed-off-by: Carlos Llamas <cmllamas@google.com>
> 
> One nit, otherwise looks okay to me.
> Reviewed-by: Alice Ryhl <aliceryhl@google.com>
> 
> Carlos Llamas <cmllamas@google.com> writes:
> > +		unsigned long index;
> > -		size_t index;
> 
> You're changing the type of index to unsigned long here, but it seems to
> me that size_t is the correct type.

Perhaps size_t made sense before the addresses were also moved to
unsigned long. I think this is a better fit now.

--
Carlos Llamas