Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760588AbXLAAB7 (ORCPT ); Fri, 30 Nov 2007 19:01:59 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757328AbXLAABt (ORCPT ); Fri, 30 Nov 2007 19:01:49 -0500 Received: from e31.co.us.ibm.com ([32.97.110.149]:40418 "EHLO e31.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755756AbXLAABr (ORCPT ); Fri, 30 Nov 2007 19:01:47 -0500 Date: Fri, 30 Nov 2007 18:01:50 -0600 From: "Serge E. Hallyn" To: "Eric W. Biederman" Cc: "Serge E. Hallyn" , Herbert Xu , Andrew Morton , Daniel Lezcano , Cedric Le Goater , Linux Containers , Pavel Emelyanov , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, David Miller Subject: Re: [PATCH 4/4] net: Implement the per network namespace sysctl infrastructure Message-ID: <20071201000150.GA18758@sergelap.austin.ibm.com> References: <4742C73C.3010904@openvz.org>

<20071130161856.GA10588@sergelap.austin.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2308 Lines: 60 Quoting Eric W. Biederman (ebiederm@xmission.com): > "Serge E. Hallyn" writes: > > > > > Hey Eric, > > > > the patches look nice. > > > > The hand-forcing of the passed-in net_ns into a copy of current->nsproxy > > does make it seem like nsproxy may not be the best choice of what to > > pass in. Doesn't only net_sysctl_root->lookup() look at the argument? > > Yes. Although I call it from __register_sysctl_paths. > > > But I assume you don't want to be more general than sending in a > > nsproxy so as to dissuade abuse of this interface for needlessly complex > > sysctl interfaces? > > A bit of that. I would love to pass in a task_struct so you can use > anything from a task. The trouble is I don't have any task_structs or > nsproxys with the proper value at the point where I am first setting > this up. Further I have to have the full sysctl lookup working or I > could not call sysctl_check. > > > (Well I expect that'll become clear once the the patches using this > > come out.) > > > > Are you planning to use this infrastructure for the uts and ipc > > sysctls as well? > > Yes. Where it comes in especially useful, is I can move /proc/sys > to /proc/sys//task//sys. And get a particular processes > view of sysctl. > > We also get a little more reuse of common functions. > > Otherwise Pavel does have a point that using this for uts and ipc > is not a savings lines of code wise. > > After having seen Pavel changes I am asking myself if there is a sane > way to remove the ctl_name argument from the ctl_path. > > Anyway where I am with the nsproxy question was that I don't > see anything easily better. What I have works and gets the job > done, and doesn't have any module unload races or holes where a sloppy > programmer can mess up the sysctl tree. We needed a solution. > Trying any harder to find something better would take ages. So > I figured this implementation was good enough. I agree. So it's already in -mm but still Acked-by: Serge Hallyn thanks, -serge - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/