Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp882411rdb; Fri, 1 Dec 2023 00:38:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IEy4wDawHcc8Yf3CfrSmTXlXFavBddk8A57VpGIFjLPKwMO87/0IGc5ciP33GqBzAqy17IO X-Received: by 2002:a17:90b:388e:b0:285:c4f1:4646 with SMTP id mu14-20020a17090b388e00b00285c4f14646mr16836981pjb.46.1701419884559; Fri, 01 Dec 2023 00:38:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701419884; cv=none; d=google.com; s=arc-20160816; b=hkwwIdRHZI8XcuoY3RJGj1x973Ra8sKoB1cAEdl42UF+o+dd1DgA3h1A6zV+N23ho0 vJuBKf57c7jFJ9KfxRRWGZiMv6QfZ1gS1X6ZNTz/ber5Aq4A+6dXHBfYSqxuUW07idk9 M9gRwdwjycSKGfVsa7XOtsMchhpWdT5mL2Ugobfb1OeTz48ytHYhyzU++WKH4/UvN8qL /DfnyFhdKuWNYWg8prnovqSXujwDC0ra626njj0zLz0xBXtCIsF6qYOwxtbW52qbbsbv 5hYhH1P8Qx0KpNFhv3Y+srgNcESupOWG9iFr130d3wodk7qtcU9GNwHfM7iSj8jDTm0O gliA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=uIqCK5DM9OwPvFWGWv+26jWjfPHLPtg142vz+q7Uxfg=; fh=sVX6tHUx4lKzZAeXBqNl9bwC5YJ0ItsqIW7MZqs3HFI=; b=id1B0O2PKyQkoXUmDk46uQJQnFZ9sae0ax/oRy1kWgcN1OgmVsKUxGOSlXsuPzQStw JeGc+cpKnoF7D83rMno4n5L6Zk1tilPDnha9+fbR5q+Lm3RJCZIM0Try6oIvr5SBib4k g3ItGOqJ+Me5E4dkXuqQHVu8dRHLTLoaOW8/+VO7FMZw/z8I5VUfnu0cwTgKiXteu24d cId2jiZ/KqZRJYvXLL1FEV+In6qxH8R6UIvWXGmewKL8IhAoEIJax7rvP3QS+moyyJJU oiyrjtaIDb8FsHKz8D7OwvNgmDkpCu7hFc6kQqTwKgrbAA3lXh6rCuZRoGn7PCJJ46Yn elCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ISHSQGMz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id n1-20020a17090a9f0100b0027686905e79si3024542pjp.146.2023.12.01.00.38.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 00:38:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ISHSQGMz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id DC710809AF96; Fri, 1 Dec 2023 00:38:00 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377855AbjLAIho (ORCPT + 99 others); Fri, 1 Dec 2023 03:37:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377850AbjLAIhm (ORCPT ); Fri, 1 Dec 2023 03:37:42 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3C311713 for ; Fri, 1 Dec 2023 00:37:48 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 28DAFC433AD; Fri, 1 Dec 2023 08:37:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701419868; bh=bh85U6qN+NrzkHALJLdBDTWd6uulN/hrqM1AYU0gOBg=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=ISHSQGMzW++hzOPN4QdItD7NV5eW5IO8efyUg1rRCBw1eJvEcUYJWuj+RLY39Q2FW xvPRi7C1moOHe1ziCAQTJJYP/Mqfg6FQ/WRuNqMCLG9+azMHajN7vuOT9ieV/n11xh Fa61TXxgsQ0mWwq39/X2nyDXOYMGRh9SZpxsOiFxu5BBJj3axAaoiVHKL5CbtECmDj heNDpgCH4hRxz5ssaTjC9qJv7IixunS8BWgDQGuHVhv76nOmsOPnkbTT7VJ8n80+O7 6Kuo58z2wRajfaX2ZOxA5kMdItdvAQfsXfQSq3bnXQ0mhsVZpR9M2DZ+jzEE1/p3l2 EvsKlZKZ98kxQ== From: Maxime Ripard To: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Donald Robson Cc: matt.coster@imgtec.com, frank.binns@imgtec.com, boris.brezillon@collabora.com, maarten.lankhorst@linux.intel.com, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch, Arnd Bergmann , kernel test robot In-Reply-To: <20231130160017.259902-2-donald.robson@imgtec.com> References: <20231130160017.259902-1-donald.robson@imgtec.com> <20231130160017.259902-2-donald.robson@imgtec.com> Subject: Re: (subset) [PATCH v2 2/5] drm/imagination: Fixed missing header in pvr_fw_meta Message-Id: <170141986571.3198881.12603407007353117665.b4-ty@kernel.org> Date: Fri, 01 Dec 2023 09:37:45 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12.3 X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Fri, 01 Dec 2023 00:38:01 -0800 (PST) On Thu, 30 Nov 2023 16:00:14 +0000, Donald Robson wrote: > A missing header causes the compiler to warn that the function below is not > forward declared. > > >> drivers/gpu/drm/imagination/pvr_fw_meta.c:33:1: warning: no previous prototype for function 'pvr_meta_cr_read32' [-Wmissing-prototypes] > 33 | pvr_meta_cr_read32(struct pvr_device *pvr_dev, u32 reg_addr, u32 *reg_value_out) > | ^ > drivers/gpu/drm/imagination/pvr_fw_meta.c:32:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > 32 | int > | ^ > | static > 1 warning generated. > > [...] Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime