Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
From:   Sathesh B Edara <sedara@marvell.com>
To:     Dan Carpenter <dan.carpenter@linaro.org>,
        Shinas Rasheed <srasheed@marvell.com>
CC:     Veerasenareddy Burru <vburru@marvell.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>
Subject: RE: [PATCH net-next] octeon_ep: Fix error code in probe()
Thread-Topic: [PATCH net-next] octeon_ep: Fix error code in probe()
Thread-Index: AQHaJDQUcOq9NXBiNEOoZYNhRs9fOg==
Date:   Fri, 1 Dec 2023 08:55:05 +0000
Message-ID: <MWHPR1801MB19828A129D67109B97458B2FD881A@MWHPR1801MB1982.namprd18.prod.outlook.com>
References: <cd2c5d69-b515-4933-9443-0a8f1b7fc599@moroto.mountain>
In-Reply-To: <cd2c5d69-b515-4933-9443-0a8f1b7fc599@moroto.mountain>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?PafG4npfRukqrqutcTgubvGbfy0GHHrW1vQ6Sh4DTukuydhDx6YljYrnJKF1?=
 =?us-ascii?Q?ib4oV8DNt14HwbB5ZGFxysyZaJn/sdsVtId6M6g/cC5fsvTMydF+K75nobSA?=
 =?us-ascii?Q?kgG+USPFrSRMOV1t8FwSlfZahoOdimL4J85tCyzRNq+e7lrZX7y4D7lYaSAY?=
 =?us-ascii?Q?WlcyWoBQludDN51lVepmtqCT6ISlvSt4Q7uczZRrVNBBt/mOqavPgVWlFboS?=
 =?us-ascii?Q?Uo2xiEUxhQ20gzUdmkhSgE6UVsr3GkGB6XZ3d1J4G1I6d5G/82f1NNa3fWoN?=
 =?us-ascii?Q?/HwDFkh5ThLtrUTae0+2t/GZy3Kkxbp04+3US7Ss3aCb8ayx8XJiTqo0XdMI?=
 =?us-ascii?Q?tTKHlfRAf6svItdwkFmR3MrSE5DQx/GSmMjHHJxm8Li4cedmZdZL94X+5R6b?=
 =?us-ascii?Q?Jjn+ZRJY28OFMmaH5FhUp2gb33WJN+r9EiOeX4cBy4V/X8u+hpHp55sYMlTM?=
 =?us-ascii?Q?Q9sffAdSWfnEmhk64lNzjBqxyf6/YxEP4B3l09VpVl7wrsi45svBMoQTSnBu?=
 =?us-ascii?Q?PIZ65zgukYfsTisLC3M8/hGyPMNAkFrGY9Xmt5GRaQsbMDnjUhfHOgFul951?=
 =?us-ascii?Q?KTGP/Y+91yzgREbtBmuTrPJmQlEymRibZoqpXdgXsRT9aAQL7T7eJXdTyFX0?=
 =?us-ascii?Q?tQLHj++B2GHjVbFAj8otyor9G1lQsR7SyLzLx4N2CP8Nz6G7kQgK0ySgDXqp?=
 =?us-ascii?Q?HFq0vLmxuM6koau4FgONw8kkBRF/Ei+ar9agdcoJuRJ2DLudU8Ah8nnk+16K?=
 =?us-ascii?Q?EJA5ScMdMMrypiOQ7hB8bW4McKuEmyzVmWSRkCcunVuF7H2lOx5QYk2bhojt?=
 =?us-ascii?Q?Os5HFQSm4hDQPI13zTUjUH1zaTmSyWcTGlcguSHAKLNVZRkr0FBryTQcEGSj?=
 =?us-ascii?Q?310pznYM/yBStxcRjQrq+2DgETFRji/z1v+YeARGfyu9X5615DtwLJV+nQMl?=
 =?us-ascii?Q?eKZsDEvpDVSXd1Q1elTam0fuAKvMSzFqL7D6yrcUJceTtyFcWg5Td+6oAKDr?=
 =?us-ascii?Q?6wRerFor1yplcG2q2Lbm2emu4nX41s6BEvZj5Wc70zF76BgK0sBMPqJC21mF?=
 =?us-ascii?Q?apQ9pKhCrtmIpZwo4J4kJQ2K31bObrTwI0IaNf7pkRotuqCHyu8FIaoZHlSC?=
 =?us-ascii?Q?OcQw0Ak63X1jy62/HKV7M/nQrDvrn//oDb+Jyo7pB1Nhy8S14AVL6GgN0yBf?=
 =?us-ascii?Q?5KBidISdnoKzz5x0GGz3nfCcl28SXQCQVlywD4+EUPoLgHdpsh7CuqlLwosB?=
 =?us-ascii?Q?AZSsAXGIN3DSH1+2exrWnib0PXXZiiaJzzpUZ9QAamL2eMC8caXC7joPMVGf?=
 =?us-ascii?Q?CXqIPifPtncbrm3IuZRmUyvOQV3b9fSCBBi5ynobFdV45vMsDDn0naBv4dbJ?=
 =?us-ascii?Q?mbeqgwdaa0iNsA9ib0A8cHoby+bZtIVsLZSYbGE1oT6J2KMyFwZqVTB+r/IL?=
 =?us-ascii?Q?dBck2r95lTInDsj02yT/SIQ1owOm8bmikhstXHh7BBJeXProIeHOnKFEydVT?=
 =?us-ascii?Q?R3xplFYcQKNReUVXAJcs7mpKkVNYl3ysQgiBCluLfLX7K7Lo6gqoc6O1wyTt?=
 =?us-ascii?Q?892hZP6cseGr8IjitYs=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1801MB1982.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4ec50264-4537-4c78-6460-08dbf24b369e
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Dec 2023 08:55:05.5621
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: fCX6a2qljO0xZb77nNz52eKqtswY+K7jf9trSJxrTxor5G0xs9wFdGGXoTzFjTTZJ3t/MVsXDrlZq5/sA9F0Ig==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR18MB5213
X-Proofpoint-GUID: aNIip92kE6v19Q1Qny_4hM4fM77gF-Hp
X-Proofpoint-ORIG-GUID: aNIip92kE6v19Q1Qny_4hM4fM77gF-Hp
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-01_06,2023-11-30_01,2023-05-22_02
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Fri, 01 Dec 2023 00:55:33 -0800 (PST)


-----Original Message-----
From: Dan Carpenter <dan.carpenter@linaro.org>=20
Sent: Tuesday, November 28, 2023 6:43 PM
To: Shinas Rasheed <srasheed@marvell.com>
Cc: Veerasenareddy Burru <vburru@marvell.com>; Sathesh B Edara <sedara@marv=
ell.com>; David S. Miller <davem@davemloft.net>; Eric Dumazet <edumazet@goo=
gle.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>=
; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; kernel-janitors@vge=
r.kernel.org
Subject: [PATCH net-next] octeon_ep: Fix error code in probe()

----------------------------------------------------------------------
Set the error code if octep_ctrl_net_get_mtu() fails.  Currently the code r=
eturns success.

Fixes: 0a5f8534e398 ("octeon_ep: get max rx packet length from firmware")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 drivers/net/ethernet/marvell/octeon_ep/octep_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c b/drivers/=
net/ethernet/marvell/octeon_ep/octep_main.c
index 423eec5ff3ad..f2e5c7d80398 100644
--- a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
+++ b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
@@ -1383,6 +1383,7 @@ static int octep_probe(struct pci_dev *pdev, const st=
ruct pci_device_id *ent)
 	if (max_rx_pktlen < 0) {
 		dev_err(&octep_dev->pdev->dev,
 			"Failed to get max receive packet size; err =3D %d\n", max_rx_pktlen);
+		err =3D max_rx_pktlen;
 		goto register_dev_err;
 	}
 	netdev->min_mtu =3D OCTEP_MIN_MTU;
--
2.42.0
Reviewed-by: Sathesh B Edara <sedara@marvell.com>