Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <3cfaf679-a739-4e76-937f-a66d03d256a8@intel.com>
Date:   Fri, 1 Dec 2023 16:55:58 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v7 21/26] KVM: x86: Save and reload SSP to/from SMRAM
Content-Language: en-US
To:     Maxim Levitsky <mlevitsk@redhat.com>, <seanjc@google.com>,
        <pbonzini@redhat.com>
CC:     <linux-kernel@vger.kernel.org>, <kvm@vger.kernel.org>,
        <dave.hansen@intel.com>, <peterz@infradead.org>,
        <chao.gao@intel.com>, <rick.p.edgecombe@intel.com>,
        <john.allen@amd.com>
References: <20231124055330.138870-1-weijiang.yang@intel.com>
 <20231124055330.138870-22-weijiang.yang@intel.com>
 <d2be8a787969b76f71194ce65bd6f35426b60dcc.camel@redhat.com>
From:   "Yang, Weijiang" <weijiang.yang@intel.com>
In-Reply-To: <d2be8a787969b76f71194ce65bd6f35426b60dcc.camel@redhat.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WWxqY2lLR1lablRqb3ByZjFEV2lObHgwSURaVEtTVVBzTllYdVA1Tm5hUGNx?=
 =?utf-8?B?Q2NtWkpHSHNQVklZczNoL2hkTHlQbTdKMC8rYkV0UXFmOXZzaEZtcW1QZnND?=
 =?utf-8?B?MlpoSkc5TUZVWjdjZTB4QWRhOGJTMC82aC9Ec2VmcU1MRWU3czNOZXhDMUdO?=
 =?utf-8?B?TU1zeTNVU1k0K0pLV2pTVmdrOHBpUW1VcFdhd294N0IwOEM2R2VGMWRweTVI?=
 =?utf-8?B?bWFveVdzMVJNby82N0VOL2RmSlhqdmpvcysyZHlkZXl2czVDdm9UWGFtQ09h?=
 =?utf-8?B?bFFvaTgxWGZyOHdWY3VCeVM2RWF3K1Flcmh3cG50N29LU2tCR09XZnJUZUw0?=
 =?utf-8?B?TEQrbWxlclo3TDIzSmwzbitZdVFGV3VrbVJkeHBINUwvbHdNaUNzd215YnRD?=
 =?utf-8?B?VmpkRWo5S1lpWHV4aDJaTmEralQ0VndKMThoZHNXYmlwRFdrMm1wN3I0bVoy?=
 =?utf-8?B?K1ZQTytTMUhkZG1KWHhBS1ZoQnpnNDhBNm1ORXc1bEhUazVxK21hSXlGWkdz?=
 =?utf-8?B?Y0t3Tlp3V01MdE93U2xZOU81N3FzS1QxMHJNbUNnZ2JOcDdHMjEzZnJBblUw?=
 =?utf-8?B?ZUxzempSQms0K3pJZ0o2enRSUExrTGduTHNLTUpOK2tXc2hUbk4vQlh4RDZU?=
 =?utf-8?B?ZWJrUFN1a3crUkc0TmUrZWNUYnpncSsweTYwcXl4ZUdzeHd2a24rVnBhaDk1?=
 =?utf-8?B?NXNZV3RtTDJHd1hISmlVaHZkZk9OMFFjd2xHYnB3U3VEbTB4a2ZLMnExcWIy?=
 =?utf-8?B?KzlwTktTQzhnNkgzclpwa1JwYk1GVHRKc3FiTFk1TGdVTFhZVVUwUlFSWUZM?=
 =?utf-8?B?VzRvdHNuOVFMM3FQOW4zdS8yZ3BnenBaQ2k1ekg1UFMwVS95N1Z5L1EwbDhM?=
 =?utf-8?B?UTAxOWNaWHdiUFpGRmZFbDVhcHUwRTFoa3h3L1pqMHBscitUcmVCT0hkVkFP?=
 =?utf-8?B?cUNpSkY1Vy9BaDRLZ3p1ZHYyWDgwTmkyUW16aWJXRlRlV0ozdUpVMWdSQjNv?=
 =?utf-8?B?eE1LT0pSRjFqQTc3UkJRTWVVZlFVM3pNNnlURkVHRlpEbW1BUTMvNDBrZXRK?=
 =?utf-8?B?UkxWOVJvYkNXQU0wNjdyQjkwR2owSmVwMHBTd0tMdEdKaWVrYk9UdmZoTTg1?=
 =?utf-8?B?aXQweUNZamFPZlcvNmJIVEdmVXlMczN6MGd0NXpjU3ZDd1E4MXlzUk1rOXJ5?=
 =?utf-8?B?RzRGcGZTOHh0eTkxT3pmQWY4RHR4K2hYdzl6OHlQTlFWRGJmMWFRVGduWndX?=
 =?utf-8?B?SVZ2UlBaVVNrbHJnazNYb0hldjd3MkJtUlJMNFp6UVlqUHVCVldLRmxFVlpq?=
 =?utf-8?B?QjM5d1pVNjR3T280Ui9YTm80SnJZdkFGR01TT0UyTkFTUUY5bS81eHkyc0tI?=
 =?utf-8?B?eS9FT2FPSmtnaXlNalIvdlJRanE3WmxjYXZTZnJyaWdyYWVzVzFSZ1VVMEp5?=
 =?utf-8?B?NTk3SkNRUDk4N1JQZ25LTk5YRXNuSzYyRUJDeEU3ZkUxTzNtMjBldEFYbEtw?=
 =?utf-8?B?VkNSMVVsM3VMWFB5RzVxd3RDWEVtT2NkNlJtT05rdHc3bnBwb2k0WnQ5SDhx?=
 =?utf-8?B?YlNuQVhIMVVCMHZXTFVYZTNGNnhRQnhFb3hhb2RzSmwvMjdyT0RCRVBtMHkw?=
 =?utf-8?B?cU1ZQ1NNc0hYd1RGSE1udUdoaVJadGo2ais0eTJ2ejFEZGJHbmlnSWxJWUxL?=
 =?utf-8?B?UVZBRWZXM0I5a0k1ZVBlcVFXd2pyUWp2Slp3N0VEZm9lUDk1ZURXZ2VKNkts?=
 =?utf-8?B?UWl0WDdGZW5jK25aV0VTNXRGVVZ5TGovS29WSWZ6OVpaSDJITFBZcTU0ckZ6?=
 =?utf-8?B?RU5aVU1zYlV6d0hLNkZtVFduakRneTRNY2N0Qk9sQlNMYWxxa005d3lnS0E5?=
 =?utf-8?B?OUxUdnphNVFTOFlQYWFuWDNIcldNTUVnQXhhOXQwRS9iZWcyRUlxeHVRTlBi?=
 =?utf-8?B?ZlRqY2JrRU1MN2hKdElsZmN3cm5NQVBlY0h6NEkrMUFXaHJtRkhBTjV2cE83?=
 =?utf-8?B?b0kzeEdqNXBKNFdxTXdFbDY3cng4N2NpMUZxNFB6N2NIZWtDRW1jTFZlOG1I?=
 =?utf-8?B?ZHcwNENicHgwK1RQSVBWNlhleFlIT2NXanIyazBCVjBVbnJKaHlPWW4xaVBk?=
 =?utf-8?B?djdnQUxlTnpaSXd4eTcwVFRJQTFyRmZLc3pKOENUaDcyRjFSOEpaRWR1Wng1?=
 =?utf-8?B?cEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e19b1fe6-392a-4c41-071d-08dbf24b5b6a
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2023 08:56:08.5722
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lwnP2rhOP86jJxNLCyqFDNAu/zJalro6SF31lIx47HFl8Qoi+v+K72FjmgfSPOJ9HZeczPJVReeR2GElLCTtdQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB5827
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Fri, 01 Dec 2023 00:56:28 -0800 (PST)

On 12/1/2023 1:42 AM, Maxim Levitsky wrote:
> On Fri, 2023-11-24 at 00:53 -0500, Yang Weijiang wrote:
>> Save CET SSP to SMRAM on SMI and reload it on RSM. KVM emulates HW arch
>> behavior when guest enters/leaves SMM mode,i.e., save registers to SMRAM
>> at the entry of SMM and reload them at the exit to SMM. Per SDM, SSP is
>> one of such registers on 64bit Arch, so add the support for SSP.
>>
>> Suggested-by: Sean Christopherson <seanjc@google.com>
>> Signed-off-by: Yang Weijiang <weijiang.yang@intel.com>
>> ---
>>   arch/x86/kvm/smm.c | 8 ++++++++
>>   arch/x86/kvm/smm.h | 2 +-
>>   2 files changed, 9 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/kvm/smm.c b/arch/x86/kvm/smm.c
>> index 45c855389ea7..7aac9c54c353 100644
>> --- a/arch/x86/kvm/smm.c
>> +++ b/arch/x86/kvm/smm.c
>> @@ -275,6 +275,10 @@ static void enter_smm_save_state_64(struct kvm_vcpu *vcpu,
>>   	enter_smm_save_seg_64(vcpu, &smram->gs, VCPU_SREG_GS);
>>   
>>   	smram->int_shadow = static_call(kvm_x86_get_interrupt_shadow)(vcpu);
>> +
>> +	if (guest_can_use(vcpu, X86_FEATURE_SHSTK))
>> +		KVM_BUG_ON(kvm_msr_read(vcpu, MSR_KVM_SSP, &smram->ssp),
>> +			   vcpu->kvm);
>>   }
>>   #endif
>>   
>> @@ -564,6 +568,10 @@ static int rsm_load_state_64(struct x86_emulate_ctxt *ctxt,
>>   	static_call(kvm_x86_set_interrupt_shadow)(vcpu, 0);
>>   	ctxt->interruptibility = (u8)smstate->int_shadow;
>>   
>> +	if (guest_can_use(vcpu, X86_FEATURE_SHSTK))
>> +		KVM_BUG_ON(kvm_msr_write(vcpu, MSR_KVM_SSP, smstate->ssp),
>> +			   vcpu->kvm);
>> +
>>   	return X86EMUL_CONTINUE;
>>   }
>>   #endif
>> diff --git a/arch/x86/kvm/smm.h b/arch/x86/kvm/smm.h
>> index a1cf2ac5bd78..1e2a3e18207f 100644
>> --- a/arch/x86/kvm/smm.h
>> +++ b/arch/x86/kvm/smm.h
>> @@ -116,8 +116,8 @@ struct kvm_smram_state_64 {
>>   	u32 smbase;
>>   	u32 reserved4[5];
>>   
>> -	/* ssp and svm_* fields below are not implemented by KVM */
>>   	u64 ssp;
>> +	/* svm_* fields below are not implemented by KVM */
>>   	u64 svm_guest_pat;
>>   	u64 svm_host_efer;
>>   	u64 svm_host_cr4;
>
> My review feedback from the previous patch series still applies, and I don't
> know why it was not addressed/replied to:
>
> I still think that it is worth it to have a check that CET is not enabled in
> enter_smm_save_state_32 which is called for pure 32 bit guests (guests that don't
> have X86_FEATURE_LM enabled)

I'm not sure whether it's worth doing so for CET on 32-bit guest since you said:
" it lacks several fields because it is no longer maintained ".

I kick the ball to Sean and Paolo to get their voice on this.