Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <d4f33b5c-f80d-4808-8e94-5c01eda34f10@collabora.com>
Date:   Fri, 1 Dec 2023 10:08:40 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] arm64: dts: mediatek: mt8183-kukui-jacuzzi: fix dsi
 unnecessary cells properties
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        linux-mediatek@lists.infradead.org,
        Eugen Hristev <eugen.hristev@collabora.com>
Cc:     krzysztof.kozlowski+dt@linaro.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, matthias.bgg@gmail.com,
        kernel@collabora.com, hsinyi@chromium.org
References: <20230814071053.5459-1-eugen.hristev@collabora.com>
 <170126437824.153055.10626099314938040381.b4-ty@collabora.com>
 <299f569f-c3e7-4807-a141-4bbc06435f03@linaro.org>
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>
In-Reply-To: <299f569f-c3e7-4807-a141-4bbc06435f03@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Il 30/11/23 10:01, Krzysztof Kozlowski ha scritto:
> On 29/11/2023 14:27, AngeloGioacchino Del Regno wrote:
>>
>> On Mon, 14 Aug 2023 10:10:53 +0300, Eugen Hristev wrote:
>>> dtbs_check throws a warning at the dsi node:
>>> Warning (avoid_unnecessary_addr_size): /soc/dsi@14014000: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
>>>
>>> Other DTS have a panel child node with a reg, so the parent dtsi
>>> must have the address-cells and size-cells, however this specific DT
>>> has the panel removed, but not the cells, hence the warning above.
>>>
>>> [...]
>>
>> Applied, thanks!
>>
>> [1/1] arm64: dts: mediatek: mt8183-kukui-jacuzzi: fix dsi unnecessary cells properties
>>        commit: 4b66a34afe29d991155081b2f1e10482bd00cbaa
>>
> 
>> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>>
> 
> You know, your SoB implies review. Unless you want to say you
> usually apply code without reviewing it...
> 

Yeah, of course it does imply review ... but if there's no actual problem with me
also sending a R-b tag, it's more practical for me, because:
  1. I have mail filters to show me what I reviewed, and
  2. Matthias also can see what I reviewed....

...but I get it that in the specific case of *this* patch, I've sent a R-b just
before applying, so I agree in that this was actually really really useless to do.

so.. whoops :-)

Thanks, btw!
Angelo