Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp933973rdb; Fri, 1 Dec 2023 02:34:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IFHzz6RctRBZWllpsyyD29y+ZwYBPlIIqZ7a9xzKq1UQigo6ppA4VYWn3Vvni+u5senV0s/ X-Received: by 2002:a05:6a00:244c:b0:6b7:18c1:c09a with SMTP id d12-20020a056a00244c00b006b718c1c09amr24898324pfj.5.1701426885717; Fri, 01 Dec 2023 02:34:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701426885; cv=none; d=google.com; s=arc-20160816; b=H0hqESrTFvJOnG/sY6uzTK8lFsQps1jFXX1uz1pCVPTycnh5u92erDAEE2SNhVNrWk 3daF/Eai/9ZzsnjQe0Dtcuz8ReVu9xeGK9PPOkuh68V/jqLcy8gzKwqnN3cSqdt+Lypc Z6QEI1fiUyXVbmk1Xa/UYhJvSMCj/BENr2Qva6jv5MUPDNbRnODWiAmFAmhz+gLGOYMj P8PFAoBmcrMcLsDF++hVo14A8bWUQOge14wu6Rpe6hmIwlKUfXnxP11wldT/0wmrtLy0 MyFBDo1QjKw5oTGD2Mrd4NDfkT/87RuTDcoYh18Tn7w1oIAbsE/YbLdtZVx2uIPbCItD Q8kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:references:in-reply-to:subject:cc:to:from :dkim-signature; bh=x9QLIDvjWUePyTNPo1KyKIxmABI1QYlXqcofIXZnDv4=; fh=p/xhiBqAwsHXDyTc3hP04CoEfkCym971UaHgGylQlPw=; b=kxZk+pBUXpyXLOCmcRuBN4WnnwVaL0qApZ5OfvrajaKI+/cvQXnkGqbkk77IkWdjrH mTcr4AND1fYzRQwB9vn20/Jj56SwUcpDUkly/nzxRnohjFKSGAQCeuo61uzruioB9Vju ZkL9oHjrrzcCAEOTzJlKDWxpNkYJ+NLu2KrMvfNK6lXiXeoiPqUOElHQ1hWg87bGmMqS bE6rkBCp6FE/Y2HQLcWsqcxnZTPl1lMzq+ORtT5eVQkSHM3qWc/9Vv1zNyQgL2PaJsLJ sHAJB+HZSctS4Dx9oL5gUrFku0rLstHlHDg8WMBkJorb72uzEXpeq2CYi56a9crZWBKY Dhig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=Efp+K6pp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id fa25-20020a056a002d1900b0068a65b26fc6si3188879pfb.43.2023.12.01.02.34.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 02:34:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=Efp+K6pp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 5545E8116787; Fri, 1 Dec 2023 02:34:42 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378266AbjLAKe3 (ORCPT + 99 others); Fri, 1 Dec 2023 05:34:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378239AbjLAKe1 (ORCPT ); Fri, 1 Dec 2023 05:34:27 -0500 Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::227]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5456DDE; Fri, 1 Dec 2023 02:34:33 -0800 (PST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 3D85120003; Fri, 1 Dec 2023 10:34:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1701426871; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x9QLIDvjWUePyTNPo1KyKIxmABI1QYlXqcofIXZnDv4=; b=Efp+K6ppRKNmXRXC312z4I4B/6CUBUuHRLy8PLz+V/UGueyXXhjUby1z/imQlO2LUhYGLR GLCiyYckN/srl+stf7jfzn6vO8+xatIFz1FFvYGMSuvYAi3wqhfzOT3fcrulMkGFlAu1wJ 6sfsj3uvzn9oKJQUzs7Nsw2oDCTQ7M3ErnbzRY7fohDNl9k2hSPTae29J1N6eUF5QhPVDe cf/keirVpnBJrg6utYHwPH1+cFVRs0rSUSj/XvDwYB8MoeDtu35HIV2LS2XSCu2aqyWtBx zv8qYSdo+dMxNt9XMG8q/3X1Sff/mM5tgB3tImLUaHFEtH/5iGRG0Tpgo/cy/Q== From: Gregory CLEMENT To: Jiaxun Yang , "paulburton@kernel.org" , Thomas Bogendoerfer , "linux-mips@vger.kernel.org" , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Vladimir Kondratiev , Tawfik Bayouk , Alexandre Belloni , =?utf-8?Q?Th=C3=A9o?= Lebrun , Thomas Petazzoni Subject: Re: [PATCH v2 20/21] MIPS: generic: Add support for Mobileye EyeQ5 In-Reply-To: References: <20231123152639.561231-1-gregory.clement@bootlin.com> <20231123152639.561231-21-gregory.clement@bootlin.com> Date: Fri, 01 Dec 2023 11:34:30 +0100 Message-ID: <87ttp2dxe1.fsf@BL-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: gregory.clement@bootlin.com X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 01 Dec 2023 02:34:42 -0800 (PST) "Jiaxun Yang" writes: > =E5=9C=A82023=E5=B9=B411=E6=9C=8823=E6=97=A5=E5=8D=81=E4=B8=80=E6=9C=88 = =E4=B8=8B=E5=8D=883:26=EF=BC=8CGregory CLEMENT=E5=86=99=E9=81=93=EF=BC=9A >> Introduce support for the MIPS based Mobileye EyeQ5 SoCs. >> >> Signed-off-by: Gregory CLEMENT >> --- > [...] >> diff --git a/arch/mips/generic/Kconfig b/arch/mips/generic/Kconfig >> index 7dc5b3821cc6e..04e1fc6f789b5 100644 >> --- a/arch/mips/generic/Kconfig >> +++ b/arch/mips/generic/Kconfig >> @@ -48,6 +48,13 @@ config SOC_VCOREIII >> config MSCC_OCELOT >> bool >>=20 >> +config SOC_EYEQ5 >> + select ARM_AMBA >> + select WEAK_ORDERING >> + select WEAK_REORDERING_BEYOND_LLSC >> + select PHYSICAL_START_BOOL >> + bool > > ^ I believe WEAK_ORDERING is already selected by MIPS_CPS, But MIPS_CPS can be disabled: it is not selected by MIPS_GENERIC_KERNEL. > and WEAK_REORDERING_BEYOND_LLSC should be selected by MIPS_CPS as well. WEAK_REORDERING_BEYOND_LLSC is only selected by CPU_LOONGSON64 for now not by MIPS_CPS Thanks, Gregory >=20=20 > Thanks > --=20 > - Jiaxun --=20 Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com