Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp938938rdb; Fri, 1 Dec 2023 02:46:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IEgNNaez+i3IHDIzL/Wzsij1dBAjO8brCwK+x245oTOHCqKvNtuZVgB8zOmno4RlQkF9C1g X-Received: by 2002:a05:6e02:1144:b0:35d:5331:9ccf with SMTP id o4-20020a056e02114400b0035d53319ccfmr696195ill.8.1701427617745; Fri, 01 Dec 2023 02:46:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701427617; cv=none; d=google.com; s=arc-20160816; b=snIuZe1G27aCDQnKh7972h+49bAtVn18RmfAi42lz7xP7rzf/iUb0pXqv3nsAV784s 2r/E0s8HVwvC/cePqwkwRXVHbUm9BPnvodZ/b6tfSg6vrOkmkQC1VY45lxUveP4TVcyt RNvUCPv85ufjGj7ksWSZFepZ+Tf2GpLCSCwNogWSu8VhfpAsInCZEgFZ6Le2PF+NNF7r fBaoSPtWwkGTta92R8n1lOGTgYTKaeCzgb9TTSUl9jdyMiQdDimRj3hteVqHmfVkobMT gmEsj5iIqmy91GsgfJXFDwB5aCS47QTm8rYq5nMN2MF28w4148UVNzWLpsGQnmVgVOf2 dn9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=6NA57GVpcAlUrYRXA0xtGWCe36ignqDZBMAU0zkJLz4=; fh=hJ08VrQ01skH5nJ/kAqAP8O+i8T0nrBnCP4uQOE6o5U=; b=cZ0fwawaErUcnzjlvukIFiNJrVa41A+49M/e7IhAGlPWbEI7tfxkYpTUmsNkWOwAaz UNAvI9cFKWlOJjbjOCqR5coDRvWboZwZWC+03q6WF0rLoOviFb28mXMl9LX/wRaNYRG6 EpgbYOegMgG5xqfcuUWl9T7uAC632w87kJD3eCM2H3cXSVIxV9upS1dc93i1QgnznZjm GKby+LbK6nauXShN9CW+RglLC4/cQZ3XlmHy3hf4n1id0DNNaV9bNMCxvC0fAAAjzk6v gnbBh14L8U0oii7dfQonEvtGhUYuoW+P5uAEb4nO/UuUSQJ9yeHqYBGjyfKQTSLzAO5C Jejg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="JBGpZma/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id bj15-20020a056a02018f00b005c1b59032b5si3363691pgb.453.2023.12.01.02.46.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 02:46:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="JBGpZma/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 8097C811678C; Fri, 1 Dec 2023 02:46:52 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378406AbjLAKqV (ORCPT + 99 others); Fri, 1 Dec 2023 05:46:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378390AbjLAKqQ (ORCPT ); Fri, 1 Dec 2023 05:46:16 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CB0510D7 for ; Fri, 1 Dec 2023 02:46:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701427582; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6NA57GVpcAlUrYRXA0xtGWCe36ignqDZBMAU0zkJLz4=; b=JBGpZma/OSceaaaPYpNUG2dz4xVL5ljtn5JQQ0tiKlLTvBLX6wRHnButmgGbbPU1/OLbV5 o6S2PmrXtT/u06PNPJootxZt4tKK3DWhGn//4duQe6CSgqkQCjohdhVAQPH3ExUIc4zeSd aCED52ovm08PJxryx2+tFxx9Bx37TEQ= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-266-bWjaQz9HPTCrFgStonuXtQ-1; Fri, 01 Dec 2023 05:46:20 -0500 X-MC-Unique: bWjaQz9HPTCrFgStonuXtQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6AD7C3C0C127; Fri, 1 Dec 2023 10:46:19 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.39.193.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id 12C8E10E46; Fri, 1 Dec 2023 10:46:16 +0000 (UTC) From: Jose Ignacio Tornos Martinez To: stern@rowland.harvard.edu Cc: davem@davemloft.net, edumazet@google.com, jtornosm@redhat.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org, oneukum@suse.com, pabeni@redhat.com Subject: Re: [PATCH] net: usb: ax88179_178a: avoid failed operations when device is disconnected Date: Fri, 1 Dec 2023 11:46:14 +0100 Message-ID: <20231201104615.173933-1-jtornosm@redhat.com> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 01 Dec 2023 02:46:52 -0800 (PST) Hi Alan, Thank you for your help. > Another possibility would be to have the unbind routine set a flag in > the private data structure, and then make the ax88179_write_cmd() and > ax88179_read_cmd() routines avoid printing error messages if the flag is > set. Or don't bother with the flag, and simply make the routines skip > printing an error message if a transfer fails with error code -ENODEV. Yes, I had thought about those possibilities and I think they are the only ones from the driver. As you are commenting as well, I will try a second version with that. Best regards José Ignacio