Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp1000953rdb; Fri, 1 Dec 2023 04:44:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IGSX8qeHL+84xiaCg4WAsulVx6f3IT8CMJlR+YtbEUEd6FG6ZWw9x8tRBz4NmzLun5JoBSG X-Received: by 2002:a17:90b:2291:b0:286:576a:74d4 with SMTP id kx17-20020a17090b229100b00286576a74d4mr2754644pjb.17.1701434671204; Fri, 01 Dec 2023 04:44:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701434671; cv=none; d=google.com; s=arc-20160816; b=lMkYd0C9MRjbcsFiot/aqQTn9OOoIlCq0oPJL1MUuJQfP/IUofOrHyR+NbUJz4LY1z tJChzXA3/dskGhn2n4ciS1EyTe92sYEE1lZUgD/wQJBF3lwukt4zSiP4LIPdfeN5YOWY nDSE35tChQ6+bdjRfy24MbynBEjS9RUYK7gNUP0nVzRG5kBz1Zr3eZf000eYMTA7cv+K +Imrki/RlnfGklQOvuMcw96vNWH5R4ljSv96S3vWDerUzG3mBu6Sod88u1NXlddEIiOe pMZRaq3SDlYEjr3Ks/PSMkZK0yFV9Bq2FNlk581xwkQJFzen4cZ+ghDwjHgY72S8eT/J F20g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=igYYLBUBB3VVcUr+NT8EHu3eJ0rew39yeoyQPnA7OPo=; fh=IXI57RYZJ5ML2GINoWb2R70DHYEZScdvccJy15A0qMs=; b=QqD+j6Hz70VeBxuirITPwW2/xIEfmVjNZduUg05mC444meqYaiicbAC5/rde0qYY8C DIvA9F3TC6nthAFANM3CFDIsXe/PsSN6jBRUB6t92KviyuIvepeQdmxZ84/OnbkDUcMk iPP6zrvfC8TckQEe9luBAE/QWPxL35wayR5eXVFw/WPEpovHPhC+ofe2adfcSZbyPG+I IOM7HsMJGiFUmsN1lnminuEkcBUaAV+6r7XIEnWLxTbVkQGJ+1NtEcIMzIbut3gLjn2G F80XyuWvqpTM2pMPuWN7BYPqAb0eLQTDlMgJrlUKSZ/Cnck41TCdSGpmlZ4TPsyCI+IT pkWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=CnrmfvMk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id ja10-20020a170902efca00b001c732b6869csi3001145plb.63.2023.12.01.04.44.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 04:44:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=CnrmfvMk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id EE69F836CE5C; Fri, 1 Dec 2023 04:44:17 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378896AbjLAMoE (ORCPT + 99 others); Fri, 1 Dec 2023 07:44:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378882AbjLAMoD (ORCPT ); Fri, 1 Dec 2023 07:44:03 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 699101A4 for ; Fri, 1 Dec 2023 04:44:07 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B36CC433C7; Fri, 1 Dec 2023 12:44:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1701434647; bh=ah7J3Jqo85Y9L6UmtUaNFJgYT5iUf/nZE7iW/HuhMYc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CnrmfvMkp6yoWoq8NJ1XEtT4O7m4/JQFa1GxIQtgU5F5aVDX1HP/VVulkZDwyD9T4 BGMGmR+Ksv/nWBy6gUv3Kf7zzXD15PwDGmDpOZ3O6677P90vL/UIHKVpfsF9QLy/r8 85SsqfXldhr9nl3+62tAyAV3Mi9xas7AUdSF1E1o= Date: Fri, 1 Dec 2023 12:44:04 +0000 From: Greg KH To: Lukasz Luba Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, daniel.lezcano@linaro.org, rafael@kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] powercap: DTPM: Fix the missing cpufreq_cpu_put() calls Message-ID: <2023120139-staging-sprang-7e77@gregkh> References: <20231201123205.1996790-1-lukasz.luba@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231201123205.1996790-1-lukasz.luba@arm.com> X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 01 Dec 2023 04:44:18 -0800 (PST) On Fri, Dec 01, 2023 at 12:32:05PM +0000, Lukasz Luba wrote: > The policy returned by cpufreq_cpu_get() has to be released with > the help of cpufreq_cpu_put() to balance its kobject reference counter > properly. > > Add the missing calls to cpufreq_cpu_put() in the code. > > Fixes: 0aea2e4ec2a2 ("powercap/dtpm_cpu: Reset per_cpu variable in the release function") > Fixes: 0e8f68d7f048 ("powercap/drivers/dtpm: Add CPU energy model based support") > Cc: # v5.10+ But the Fixes: tags are for commits that are only in 5.12 and newer, how can this be relevant for 5.10? thanks, greg k-h