Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp1024357rdb; Fri, 1 Dec 2023 05:19:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IGnx2Fe/TDMnafFeQyctGiy+vVfCiSXQaA7HK311cT5Zz1pesaYKsTmmjafGlGDj4NiovZi X-Received: by 2002:a17:90b:3e86:b0:285:93f0:b2a4 with SMTP id rj6-20020a17090b3e8600b0028593f0b2a4mr26621566pjb.7.1701436779320; Fri, 01 Dec 2023 05:19:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701436779; cv=none; d=google.com; s=arc-20160816; b=wD6/73b4CrjQmGkF5ibfEXNBbvNE46iX+L4xEKpVmPrHdBLQXAymXkZZhE3KW7TUcz pLEq/lnR9d5G6FidZxWZjiGIDicyowfvgGz44ZNFxhDazn50jBqSKsU5WvdkLo0gQXGM rEpjdCabG/61PCrzVL6R95EU1lJIFPHeHyMDCLI1hsHEHu1G2jeMgZZZkoIB18AfcYyV zI2fKPDqXlY69G6ms48VuSXz+X4gk8LUe17klescdAAW2eS3n6ta0Ns2YahFQg/qH6ER qOPg5+PawQmVimhxb09JP5it2BctDdLChMjzdeon7ABKxIRvs+VOBhYmI9c27urmqAqL 1/Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=TV4RE4cHNpakye744+P99xHdpE2/iAr/FBdxm7x4r+g=; fh=7wiwkIc8RB7gCkBe41SRRvQxiAeyHz5PPqR0539QyoU=; b=OPutVEzbyvhJnd/vesw/HX6iygRpMFOVplg3IN1mk0PCzJ6lPN9cHn1w72ZZGzFw9B hNoHHsbSxl3iiAqqzSQoc0khCu0X+dQcG0ItLisMoumf8cN65aRvefTDq/yZ6RQRDmXE B/6MgyqbXS/IwwXrSsdHYA4/eTImh65hv/fX63rNGV7McMUMygz3srHbkwqLISPfN+aR ccGbPdW+z52Tz3MYufRQRqaTD6PmLNe19KLCmeNZE9RhosUoP3sxLt9DKo542KdenbRs xi0Y/Lp/to5DIhVGJWIa5130HCawpLlytLqi4ZcYWucoYZ+DQun6LIqviXfbALgUdezF eF2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=k7+YvcLW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id nu15-20020a17090b1b0f00b002810ae70420si5577502pjb.121.2023.12.01.05.19.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 05:19:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=k7+YvcLW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id E19EF84D1212; Fri, 1 Dec 2023 05:19:36 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378972AbjLANTS (ORCPT + 99 others); Fri, 1 Dec 2023 08:19:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378947AbjLANTR (ORCPT ); Fri, 1 Dec 2023 08:19:17 -0500 Received: from mail-yw1-x112a.google.com (mail-yw1-x112a.google.com [IPv6:2607:f8b0:4864:20::112a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BA5713E for ; Fri, 1 Dec 2023 05:19:23 -0800 (PST) Received: by mail-yw1-x112a.google.com with SMTP id 00721157ae682-5d279bcce64so23823337b3.3 for ; Fri, 01 Dec 2023 05:19:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701436762; x=1702041562; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=TV4RE4cHNpakye744+P99xHdpE2/iAr/FBdxm7x4r+g=; b=k7+YvcLWgiIpFeZv4E6dFYbAwzp6qzf0OwdULmKHfCwnOeKRrERw+/fncxBdnWu6Mg k+VFF/Y1hv4iGa+4Eo5VMZQEJin0y9769rCzYfwBL0W/u8UdtOn+5JLGKsm8E22hCObQ QPwQFoZ1fxi2LvbyRfzKGfT6MtPqSAvdoPqiKbOLHusiGlyafxS2SYWz84N3jc5DaMys gCeOQdQv3mEXA3hA699C5TpZU8tU6n2o/EJb1JXHQ1uqF0GUbQCf9X0m7nW1Dh6uZx2i f5MX9ohIUwVDObiOcxD2zx4H8liQ2STNYQ6xvPLA9TCgvKsfNtpYRAedINwSORJlkoBn a+rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701436762; x=1702041562; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TV4RE4cHNpakye744+P99xHdpE2/iAr/FBdxm7x4r+g=; b=WMYyjXlt3sygajpO4COlyR4QBj7vaOB6SuYSlAyUNGLWT8t7Q2bkfIfHtFYnE+kAlf I+hXfFclaLNQCUNvNTU3EPFZkHDH/J+3Stx/M93yONRRdFGYg1h6etOWVPW2FLUuuesk QhRIiF4gdZpKIoZsPDKB0+Py37ZV0smBJODQS5DctErI6j9pvkvu/sJ2rPgd4Da4P3NH BSEHpF60FNpb7eCzoVs66jyYEcR2lzsKsYXWZ0AYWQ9f+T1oEXdlhkX1O3PGu4KPaUCC vhVF2lUdARnpVTfH1xwmMRjBho1mH1q/RwMmYOicrzU7tm5RtFzSFWAbs3qs3+DR7Ji+ yI+w== X-Gm-Message-State: AOJu0Yy/FRirvAJR/pYlX9ANCe2+MFIGvmSOat/st9olSVywU3a6K0ET VhoLWPD7u6CBwZ9I1we2qbC0yThmlQDynk/xnbx9BQ== X-Received: by 2002:a81:9242:0:b0:5d3:cfc1:2df2 with SMTP id j63-20020a819242000000b005d3cfc12df2mr3380112ywg.14.1701436762501; Fri, 01 Dec 2023 05:19:22 -0800 (PST) MIME-Version: 1.0 References: <20231201100527.1034292-1-jorge@foundries.io> In-Reply-To: <20231201100527.1034292-1-jorge@foundries.io> From: Linus Walleij Date: Fri, 1 Dec 2023 14:19:10 +0100 Message-ID: Subject: Re: [PATCHv3] mmc: rpmb: fixes pause retune on all RPMB partitions. To: Jorge Ramirez-Ortiz Cc: ulf.hansson@linaro.org, adrian.hunter@intel.com, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Fri, 01 Dec 2023 05:19:37 -0800 (PST) On Fri, Dec 1, 2023 at 11:05=E2=80=AFAM Jorge Ramirez-Ortiz wrote: > When RPMB was converted to a character device, it added support for > multiple RPMB partitions (Commit 97548575bef3 ("mmc: block: Convert RPMB > to a character device"). > > One of the changes in this commit was transforming the variable > target_part defined in __mmc_blk_ioctl_cmd into a bitmask. > > This inadvertedly regressed the validation check done in > mmc_blk_part_switch_pre() and mmc_blk_part_switch_post(). > > This commit fixes that regression. > > Fixes: 97548575bef3 ("mmc: block: Convert RPMB to a character device") > Signed-off-by: Jorge Ramirez-Ortiz > Cc: # v6.0+ Reviewed-by: Linus Walleij Yours, Linus Walleij