Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <070c174c-057a-46de-ae8e-836e9e20eceb@salutedevices.com>
Date:   Fri, 1 Dec 2023 16:43:35 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC PATCH 1/1] locking: introduce devm_mutex_init and
 devm_mutex_destroy
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Waiman Long <longman@redhat.com>
CC:     <peterz@infradead.org>, <mingo@redhat.com>, <will@kernel.org>,
        <boqun.feng@gmail.com>, <jic23@kernel.org>,
        <linux-kernel@vger.kernel.org>, <kernel@salutedevices.com>
References: <20231128000910.73784-1-gnstark@salutedevices.com>
 <cbd2705d-9d43-4822-9b5c-ea437a2ccca7@redhat.com>
 <ZWYW4nDZNAO7NADj@smile.fi.intel.com>
Content-Language: en-US
From:   George Stark <gnstark@salutedevices.com>
In-Reply-To: <ZWYW4nDZNAO7NADj@smile.fi.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Andy, Waiman

Thanks for the review.

I'll move the patch to the devm-helpers.h then.


On 11/28/23 19:35, Andy Shevchenko wrote:
> On Mon, Nov 27, 2023 at 08:55:18PM -0500, Waiman Long wrote:
>> On 11/27/23 19:09, George Stark wrote:
> 
> ...
> 
>> These APIs are specific to devres. I don't believe it is suitable to put
>> them into the generic mutex.h header file. All devres_* functions are
>> defined in include/linux/device.h which is probabably not included in
>> mutex.h. You may consider putting these APIs into device.h instead.
> 
> +1. We have include/linux/devm-helpers.h.
> 

-- 
Best regards
George