Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp1055265rdb; Fri, 1 Dec 2023 06:05:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IFXEHbX5Xp0CG7KVOfFz0f8eTgD0XzInEAZFvNbjDUkygbNwNvCAKdv9oPxhqHz4S2E//xy X-Received: by 2002:a17:902:be12:b0:1cf:9e9f:fddf with SMTP id r18-20020a170902be1200b001cf9e9ffddfmr25004303pls.44.1701439540082; Fri, 01 Dec 2023 06:05:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701439540; cv=none; d=google.com; s=arc-20160816; b=NXYMcw3nY0LGbdKILMugm27LkaG3v1xS52MP2s9RtBqRYV+VS8lJiPDNO3F6dHZ6qe /Q5PaitDX8wpqcs+rDT6TK5r9xg/5Me3HOr224ENyWFLWKn82c7XYQnAqGfN+3qcRMct IKP2LUQChdo25UpAu1FuGApH+R9N0+EyVeNIYcoI1fQ1R8JsI85zgNayjJk0QjzIIU9M hSIgn1zkVCh64VLbB7FlbwsYjsci6Cpczm1ZaA7PHZY+/Tfbf3G24Z5+RVt3j8f9/3SM 0HTyQhHaOOpCJli+7LHgA6X3aMzXPXo25lq21v5LZ5T7BqSjC0Pmm/SASICDUR3LPZ+n ZkUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Gc98IDl4f3dpcClMUSqp20voJP/FNj3pQCT54gqb67M=; fh=I4RLCLw/dMKPX9xPZZ8+mL0LeKDitseWF0AaQr+3mks=; b=TpM0RfdezvVsU8v9FmjOR7lo7orMirnz1E+2k6yLE5pkXySgxor4HDKJtGyjQyhtXl QmkQnfLhIy3vD/Hoo9QzaH9/vYcOSqsRjwO1faqFohZO7uDOPFhUIpenIa7abFR7q/2V 7Pd6Exa6AbZ3rVfuCnjvCJCAPty3sCwvyE97bjSeak0SmBdXBqdO1HZjto0m3DlufgDK gmZQDJwg0aK3LGnAbAnhCdQycswTrE1XH2L4Xa4Yi5ACcoP2Wmsdh/srWaUN+aUAgyXd ZZStXeQ9Lc8dSJ/o1+sE63H5EVZrFHsGbitFOc59lya0l7cIYReqIBBvc6961v2WWUXL Wr7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=qbcU8xmd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id x7-20020a170902b40700b001bf0b29d935si3267733plr.34.2023.12.01.06.05.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 06:05:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=qbcU8xmd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id A254E8106874; Fri, 1 Dec 2023 06:05:17 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379126AbjLAOFF (ORCPT + 99 others); Fri, 1 Dec 2023 09:05:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379120AbjLAOFE (ORCPT ); Fri, 1 Dec 2023 09:05:04 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78E0F1B2; Fri, 1 Dec 2023 06:05:10 -0800 (PST) Received: from pyrite.hamster-moth.ts.net (h175-177-049-156.catv02.itscom.jp [175.177.49.156]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 177711AC0; Fri, 1 Dec 2023 15:04:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1701439472; bh=ZafNoeEiTkEMR2Mskz+/jeQsiJ1/6DAgbgEgbXTgowE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qbcU8xmdrlGoFSKZSapRmFb5mN6wxgBgyBtw3jGhhvjuWlMyiSa3xr/86Uw8GAyc3 jIgWdDs+AnUSdDqrBDx5zx+kJJbVg37eWM/B0SEUXZCpvuJIzKJAp3bW01smF0ezfB X4PgbnegCsiBOt1IpV5NOnpwqyloJ4o4C13LJLlM= From: Paul Elder To: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org Cc: laurent.pinchart@ideasonboard.com, kieran.bingham@ideasonboard.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, Paul Elder , Dafna Hirschfeld , Mauro Carvalho Chehab , Heiko Stuebner , linux-arm-kernel@lists.infradead.org (moderated list:ARM/Rockchip SoC support), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2 4/4] media: rkisp1: debug: Consolidate counter debugfs files Date: Fri, 1 Dec 2023 23:04:33 +0900 Message-Id: <20231201140433.2126011-5-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231201140433.2126011-1-paul.elder@ideasonboard.com> References: <20231201140433.2126011-1-paul.elder@ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 01 Dec 2023 06:05:17 -0800 (PST) Consolidate all the debugfs files that were each a single counter into a single "counters" file. While at it, reset the counters at stream on time to make it easier for to interpret the values in userspace. Signed-off-by: Paul Elder --- New in v2 .../platform/rockchip/rkisp1/rkisp1-capture.c | 2 + .../platform/rockchip/rkisp1/rkisp1-common.h | 4 ++ .../platform/rockchip/rkisp1/rkisp1-debug.c | 69 ++++++++++++------- 3 files changed, 50 insertions(+), 25 deletions(-) diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c index c6d7e01c8949..67b2e94dfd67 100644 --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c @@ -1030,6 +1030,8 @@ rkisp1_vb2_start_streaming(struct vb2_queue *queue, unsigned int count) struct media_entity *entity = &cap->vnode.vdev.entity; int ret; + rkisp1_debug_reset_counters(cap->rkisp1); + mutex_lock(&cap->rkisp1->stream_lock); ret = video_device_pipeline_start(&cap->vnode.vdev, &cap->rkisp1->pipe); diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h b/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h index be69173958a4..789259fb304a 100644 --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h @@ -599,9 +599,13 @@ int rkisp1_params_register(struct rkisp1_device *rkisp1); void rkisp1_params_unregister(struct rkisp1_device *rkisp1); #if IS_ENABLED(CONFIG_DEBUG_FS) +void rkisp1_debug_reset_counters(struct rkisp1_device *rkisp1); void rkisp1_debug_init(struct rkisp1_device *rkisp1); void rkisp1_debug_cleanup(struct rkisp1_device *rkisp1); #else +static inline void rkisp1_debug_reset_counters(struct rkisp1_device *rkisp1) +{ +} static inline void rkisp1_debug_init(struct rkisp1_device *rkisp1) { } diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c index 79cda589d935..4358ed1367ed 100644 --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c @@ -25,6 +25,11 @@ struct rkisp1_debug_register { const char * const name; }; +struct rkisp1_debug_counter { + const char * const name; + unsigned long *value; +}; + #define RKISP1_DEBUG_REG(name) { RKISP1_CIF_##name, 0, #name } #define RKISP1_DEBUG_SHD_REG(name) { \ RKISP1_CIF_##name, RKISP1_CIF_##name##_SHD, #name \ @@ -191,6 +196,43 @@ static int rkisp1_debug_input_status_show(struct seq_file *m, void *p) } DEFINE_SHOW_ATTRIBUTE(rkisp1_debug_input_status); +static int rkisp1_debug_counters_show(struct seq_file *m, void *p) +{ + struct rkisp1_device *rkisp1 = m->private; + struct rkisp1_debug *debug = &rkisp1->debug; + + const struct rkisp1_debug_counter counters[] = { + { "data_loss", &debug->data_loss }, + { "outform_size_err", &debug->outform_size_error }, + { "img_stabilization_size_error", &debug->img_stabilization_size_error }, + { "inform_size_error", &debug->inform_size_error }, + { "irq_delay", &debug->irq_delay }, + { "mipi_error", &debug->mipi_error }, + { "stats_error", &debug->stats_error }, + { "mp_stop_timeout", &debug->stop_timeout[RKISP1_MAINPATH] }, + { "sp_stop_timeout", &debug->stop_timeout[RKISP1_SELFPATH] }, + { "mp_frame_drop", &debug->frame_drop[RKISP1_MAINPATH] }, + { "sp_frame_drop", &debug->frame_drop[RKISP1_SELFPATH] }, + { "complete_frames", &debug->complete_frames }, + { /* Sentinel */ }, + }; + + const struct rkisp1_debug_counter *counter = counters; + + for (; counter->name; ++counter) + seq_printf(m, "%s: %lu\n", counter->name, *counter->value); + + return 0; +} +DEFINE_SHOW_ATTRIBUTE(rkisp1_debug_counters); + +void rkisp1_debug_reset_counters(struct rkisp1_device *rkisp1) +{ + struct dentry *debugfs_dir = rkisp1->debug.debugfs_dir; + memset(&rkisp1->debug, 0, sizeof(rkisp1->debug)); + rkisp1->debug.debugfs_dir = debugfs_dir; +} + void rkisp1_debug_init(struct rkisp1_device *rkisp1) { struct rkisp1_debug *debug = &rkisp1->debug; @@ -198,31 +240,8 @@ void rkisp1_debug_init(struct rkisp1_device *rkisp1) debug->debugfs_dir = debugfs_create_dir(dev_name(rkisp1->dev), NULL); - debugfs_create_ulong("data_loss", 0444, debug->debugfs_dir, - &debug->data_loss); - debugfs_create_ulong("outform_size_err", 0444, debug->debugfs_dir, - &debug->outform_size_error); - debugfs_create_ulong("img_stabilization_size_error", 0444, - debug->debugfs_dir, - &debug->img_stabilization_size_error); - debugfs_create_ulong("inform_size_error", 0444, debug->debugfs_dir, - &debug->inform_size_error); - debugfs_create_ulong("irq_delay", 0444, debug->debugfs_dir, - &debug->irq_delay); - debugfs_create_ulong("mipi_error", 0444, debug->debugfs_dir, - &debug->mipi_error); - debugfs_create_ulong("stats_error", 0444, debug->debugfs_dir, - &debug->stats_error); - debugfs_create_ulong("mp_stop_timeout", 0444, debug->debugfs_dir, - &debug->stop_timeout[RKISP1_MAINPATH]); - debugfs_create_ulong("sp_stop_timeout", 0444, debug->debugfs_dir, - &debug->stop_timeout[RKISP1_SELFPATH]); - debugfs_create_ulong("mp_frame_drop", 0444, debug->debugfs_dir, - &debug->frame_drop[RKISP1_MAINPATH]); - debugfs_create_ulong("sp_frame_drop", 0444, debug->debugfs_dir, - &debug->frame_drop[RKISP1_SELFPATH]); - debugfs_create_ulong("complete_frames", 0444, debug->debugfs_dir, - &debug->complete_frames); + debugfs_create_file("counters", 0444, debug->debugfs_dir, rkisp1, + &rkisp1_debug_counters_fops); debugfs_create_file("input_status", 0444, debug->debugfs_dir, rkisp1, &rkisp1_debug_input_status_fops); -- 2.39.2