Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Message-ID: <c0a4b430-291b-4de8-a655-2f768e95fe5e@intel.com>
Date:   Fri, 1 Dec 2023 15:37:43 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [Intel-wired-lan] [PATCH net-next v5 03/14] page_pool: avoid
 calling no-op externals when possible
Content-Language: en-US
To:     Yunsheng Lin <linyunsheng@huawei.com>
CC:     Christoph Hellwig <hch@lst.de>,
        Paul Menzel <pmenzel@molgen.mpg.de>,
        Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        Larysa Zaremba <larysa.zaremba@intel.com>,
        <netdev@vger.kernel.org>, Alexander Duyck <alexanderduyck@fb.com>,
        "Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
        <linux-kernel@vger.kernel.org>, Eric Dumazet <edumazet@google.com>,
        Michal Kubiak <michal.kubiak@intel.com>,
        <intel-wired-lan@lists.osuosl.org>,
        David Christensen <drc@linux.vnet.ibm.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "David S. Miller" <davem@davemloft.net>
References: <20231124154732.1623518-1-aleksander.lobakin@intel.com>
 <20231124154732.1623518-4-aleksander.lobakin@intel.com>
 <6bd14aa9-fa65-e4f6-579c-3a1064b2a382@huawei.com>
 <a1a0c27f-f367-40e7-9dc2-9421b4b6379a@intel.com>
 <534e7752-38a9-3e7e-cb04-65789712fb66@huawei.com>
 <8c6d09be-78d0-436e-a5a6-b94fb094b0b3@intel.com>
 <4814a337-454b-d476-dabe-5035dd6dc51f@huawei.com>
 <d8631d76-4bb3-41a4-a2b2-86725867d2a9@intel.com>
 <6c234df1-d20a-812e-3c58-7e3941d8309b@huawei.com>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <6c234df1-d20a-812e-3c58-7e3941d8309b@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z05IRlhvQUZHK0RCamM3NkRmODlJNFp3SVNvUDhOQmhQRUNucjAwellLVWFl?=
 =?utf-8?B?SFlaMWUxYTEvM3ZMUVFYbXRsdUE0dnc2S25SYjltSnFpbEJONDRmR3ZjSDd4?=
 =?utf-8?B?UGwvaGp5RmVLYmR0b2ZBd3czdnNES2wzdXBxOFI5Tmx0eVo1RXlDRFRKaysz?=
 =?utf-8?B?TWE4K3h4Z1JUb3pINjdYSjVGbXIwR3hGdHZDdktVNGwvcWNjNHFKVVpZbi9M?=
 =?utf-8?B?TlhlZzhBRFlNV3RGbGFlOVVzeWZVUEZraHk1Tiswb2pYeFFXcXZBNUd5WERR?=
 =?utf-8?B?VktsbE5OR0VCbkZYNk9lbUNUSU9MMTErVFVqUTBpUG5QdEdZME5jOExIanFw?=
 =?utf-8?B?aER5Z0tLeHZZbnVXcEVicXF0WlE2UjNUdHJyV1FnRjByNUdDWWlXc3BFZlNu?=
 =?utf-8?B?dEdLZXo1NDV6TWZQV2tUeWZFbDFoWGQzeExlMlNjeSs2OENsbytLSjY4NFEy?=
 =?utf-8?B?OGhYenhlTit3b3VIZEFNUStxRzRaRjZyTjlMUVAwSzJGWEVPNnhWcC9iRldS?=
 =?utf-8?B?dE1xQ29SNzFHR1JEeWxMNEhBc1dUWk84TE9sdzliVGp5MStTYzB3M1ZuWEFB?=
 =?utf-8?B?OWluZzJDVzFZekM0LzJHSzBSTDkvUW9qNG1RamZKTzlMTG1IdVR0UUtTT1Jt?=
 =?utf-8?B?bjFOejc3YUU1NlhMSTNrSEhEbmJsVG16MnFuZDBEamN4TkFnOE4ySEdyYW4r?=
 =?utf-8?B?UEFHWmx3SXhTS1dyL3AzOVpaaVl4VURNMFBCcmFNNzRvN3BoMFl4TDVzZ0lH?=
 =?utf-8?B?cTRkL1NrUE5tREZhbGFHeEMwM1hlMEYyYlp0aGxqNjh4Q0ZMQy8zYmhrWkVp?=
 =?utf-8?B?bk1NL05KcWRrT3lrcFUyT2lGc0dhQXVSTUhuOVVlOXpnVURjMzMrNFpHN2k3?=
 =?utf-8?B?eW5LUWZKS2dKOXY4UEJYcXhpdEN2aGp6YTNja2w4dGNmYktCODhzYVRBVm5T?=
 =?utf-8?B?TEFqa3VpaXFSc0N2WUhVZVdFZEVYLzhKYW1IUUgzOUIzajlpdDB2OStHMUk5?=
 =?utf-8?B?WUFib2djTTBCdWREMU9iSHp0WktwdUlVaUE2MmUrRW53Z01SOERkaElaTkhH?=
 =?utf-8?B?L3UxcWliZUEvbWF2a09MR0xBeVJzUHViQmY1RXFNNVdJZE5hS04xaldUS1Vl?=
 =?utf-8?B?V0E1RkoxVTJKWDhJU0YySEVzMGlpT3RudzdERVU0eXdLa09OOG5WRk41OTc3?=
 =?utf-8?B?ei9OdzZTc0FjSkxZV05sRi82d045N29SVU5lTUhuRWdpaS9LcW9ZcHZiWktL?=
 =?utf-8?B?UERRVXlSamtKRFkzcmdFSlJBbXZkY1paRTJTcWszL1JIODJHOFdLaTBLRERW?=
 =?utf-8?B?VDI2VE1GTlVQdWUrT2IrTEFnbmczL3BZcGZoWU9mQUVmN1RFYXJCVlMrUlps?=
 =?utf-8?B?RnRBVlNsL3k4WDAzMEVJamhBRWttb0d2ZTVteHZpdGFDRkF5TktxdS9QM015?=
 =?utf-8?B?NkUzbFdiZE1zMnU5TVVkcERKcVhOYThjKzAzMHM0VWlPck9CYkc2UGRLUEI1?=
 =?utf-8?B?Mm1NYlYrQXlKOGFDYUtQWlkzV1VzWVBXK0daNUNYL2txNXk1ampPQXBtckRn?=
 =?utf-8?B?SGUvNzNtVVpBUEszdTVnM1BROFNUeWpMZjU3UGc2elhKVWp1aTN4Zk4vNkxQ?=
 =?utf-8?B?OUgrSUxyeWcyai9Kd0I4Rm9JbXMzTndHMkN4MVpxTXdtaGdDS3hQRnV4MmF6?=
 =?utf-8?B?T2FEQlBFaWZ6dnk4eE0vNUx5SWFLcDh0dFp5NE5oMTEzeVV3ZUJhNThvZElk?=
 =?utf-8?B?M2MzYWlybHY5d0lOVlRTd1RBUUZNRUUxVXpQSDhWZU9WK1ovWTVOZTRrOTNH?=
 =?utf-8?B?WVdFTnh5Z1VqZ010cGcrTFl1RENSdDdBNG5HdWJac0U1OW5lUFBOOGFTRmU1?=
 =?utf-8?B?YTZPV0lyNUE3WTVLbXRXajNRaE1BSzRQTDBVd2dBeWVhVEZiNENGVys0RFor?=
 =?utf-8?B?ODQxNjM3SUs1b2lidWhWcXZGT0tudXh4dkFEN2Z5a0VCVlE5VDZGSDU4SGdM?=
 =?utf-8?B?a2tpM3dTYUc2SGhYdDJzSWhOREVGTlNIUTRvUmlBdXhqQnF0dGNlQUhmdmNF?=
 =?utf-8?B?dlJDbHpMejNLWGpON28xeWloZXF5K04zSDdHd0xtMWZNQnRETWpwYWNQa3M5?=
 =?utf-8?B?WmRsSmQ3b3hCZmhtc3oya2lrdVBIbGxkSWQ3eXlVS2JsakhUYlFZN2p5cGVt?=
 =?utf-8?B?OWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fe02a8ab-d344-4570-df31-08dbf27b38d9
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2023 14:38:45.4569
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eATsXZCludrwVVFmcB9ZLDHQciyMCw40A71CI7EtVmBBmdq3zZrrBXrPab0lO4gFZSjmpgjLwxKQIDmTRzS4UzCgLuq59kY+iBA9McY9BmM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR11MB8696
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 01 Dec 2023 06:39:08 -0800 (PST)

From: Yunsheng Lin <linyunsheng@huawei.com>
Date: Thu, 30 Nov 2023 20:20:44 +0800

> On 2023/11/30 19:58, Alexander Lobakin wrote:
>> From: Yunsheng Lin <linyunsheng@huawei.com>
>> Date: Thu, 30 Nov 2023 16:46:11 +0800
>>
>>> On 2023/11/29 21:17, Alexander Lobakin wrote:
>>>> From: Yunsheng Lin <linyunsheng@huawei.com>
>>>> Date: Wed, 29 Nov 2023 11:17:50 +0800
>>>>
>>>>> On 2023/11/27 22:32, Alexander Lobakin wrote:
>>>>>>
>>>>>> Chris, any thoughts on a global flag for skipping DMA syncs ladder?
>>>>>
>>>>> It seems there was one already in the past:
>>>>>
>>>>> https://lore.kernel.org/netdev/7c55a4d7-b4aa-25d4-1917-f6f355bd722e@arm.com/T/
>>>>
>>>> It addresses a different problem, meaningless indirect calls, while this
>>>> one addresses meaningless direct calls :>
>>>> When the above gets merged, we could combine these two into one global,
>>>> but Eric wasn't active with his patch and I remember there were some
>>>> problems, so I wouldn't count on that it will arrive soon.
>>>
>>> I went through the above patch, It seems to me that there was no
>>> fundamental problem that stopping us from implementing it in the dma
>>> layer basing on Eric' patch if Eric is no longer interested in working
>>> on a newer version?
>>
>> I'm somewhat interested in continuing working on Eric's patch, but not
>> now. Have some urgent projects to work on, I could take this in January
>> I guess...
>> This PP-specific shortcut was done earlier and gives good boosts. It
>> would be trivial to remove it together with the XSk shortcut once a
>> generic both indirect and direct call DMA shortcut lands.
>> Does this sounds good / justified enough? Or you and other
>> reviewers/maintainers would prefer to wait for the generic one without
>> taking this patch?
>>
> 
> I would prefer we could wait for the generic one as there is only about one
> month between now and january:)

Ok, let's do it this way. I'll try to revive Eric's idea soon and get it
taken if he doesn't mind :>

Thanks,
Olek