Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp1084071rdb; Fri, 1 Dec 2023 06:44:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IGuiH5oIzg7vTyFldqqq97ZGfGAXYRMsfo+03oNv/8zMnGt/WME+RKAF0ap4Gm+SAhR6mJ0 X-Received: by 2002:a05:6a20:160d:b0:187:60da:4767 with SMTP id l13-20020a056a20160d00b0018760da4767mr38481914pzj.25.1701441890175; Fri, 01 Dec 2023 06:44:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701441890; cv=none; d=google.com; s=arc-20160816; b=RFUMgdkkj9pjGPqCsuGusGDuUP86N8RKfI5xTScZDs7HhM3UzUyijQ9PwnBNfM/XSJ GCQzPyhpUACDSfS6fkgnRcxjOpUzXKDMs5CT6z7giGeeSnyqJiF5ggas3G3URjVsOK+D H17aC3Nn/Xfr3K/an0dKjO78nE4EKonGSMzTBrhNqTQYgSHp67NkzYe518kAgRGb8UBJ T4hX/mCfAilsIN7I4lAiCgsIhHbEIhKvYEAKr1pTWE4FiHoCoOUO7YSVnDnAUFlfzq9K /Z1waQIK/7Hysl47Mx1KWgcXihJ4Ey6YOq0GPQAUazn1/k4CvA/qyiOx6Ox6v8+chtZZ Uhwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:date:references:in-reply-to :message-id:mime-version:user-agent:feedback-id:dkim-signature :dkim-signature; bh=kKo4dJKblO+HlaEynT7R0ipo9rNcBzF1TALtacSN8BE=; fh=dTtrAcGs2K0uRyVUqjRkO1Is4PnzkiHWJaMmpc6Zsfo=; b=mNl2Wr4VuEzIetNGNI4ggC2y0cB6LKJRFVVHstN+rHb/gjxhJsAAJjZzaPrfI7CHw2 fva5e2LE6rvyBDeB4TD6nJYIf3Zn7vau8NJeCnnPRoJn6Yf1iolIe/LMpwZfegx9pa22 UvIkhmaD/mqzzv3VksxxXpmQYUAC+2o2eRsPs/m6SZA6nLk/NtfvtY/s7D/PQSYJ2ViS Sy8Ulh/J4TcYcZ3reGvX/45oS/kE7x9Yufa0dU0RdVwG2REiSXRw+uxjDJ0yOjYyHkEM P062JoU62crywGGA/Cs8a1lU0TIJLMSZdTaox85RxIgrb9RfNSISzs9lAQFXlkPaJIR9 dang== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@arndb.de header.s=fm3 header.b=M8oHNdH+; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=gvF3JFrw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id u3-20020a656703000000b005c1cc7273besi3303831pgf.521.2023.12.01.06.44.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 06:44:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@arndb.de header.s=fm3 header.b=M8oHNdH+; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=gvF3JFrw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 9EB79836E44C; Fri, 1 Dec 2023 06:44:27 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379192AbjLAOn7 (ORCPT + 99 others); Fri, 1 Dec 2023 09:43:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379235AbjLAOn5 (ORCPT ); Fri, 1 Dec 2023 09:43:57 -0500 Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B265510F4 for ; Fri, 1 Dec 2023 06:44:00 -0800 (PST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.nyi.internal (Postfix) with ESMTP id 6FA835808AE; Fri, 1 Dec 2023 09:43:57 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Fri, 01 Dec 2023 09:43:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1701441837; x=1701449037; bh=kK o4dJKblO+HlaEynT7R0ipo9rNcBzF1TALtacSN8BE=; b=M8oHNdH+cvykmc/+5J 8RMXWyg22pwYkaY44RoX9SPAkdK1aLBFwwkj4sptf+YpDIdDWuTHixMt9aEH++tj kRSLFukS+/iWZDl3Q0aoNgsvZ8NUjDBSh39eGILjEePgB5J6m3aLFYpHYIztcwMU jKm81uFGfDBlzWrPt5/0p7DrQTiGlFdjyBx76kxrq+8KsEBvUgXzyCBFFzMl0fNL i8wvSsEhMh2XHOhbJ08aVytYJYkjEYgxtRGwAR+RCpNkU4rOpaDvol39QD0QGJDx U3QPyA+VAYxSUKSbtQrHD//p9vvDd8gZi+BgknFw5FSC0jNXuHmv9Jf9vMz90S3w sPuQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1701441837; x=1701449037; bh=kKo4dJKblO+Hl aEynT7R0ipo9rNcBzF1TALtacSN8BE=; b=gvF3JFrwR29gFH3qJWYjCOqt3lyop MwdkBKVOAx3QaD9AsJ+mKQvXRb+g3ZVqwY8+x4NjTbHwwvcebV9LRkL7NEtTJvfE 3oBykOvMihi81cveRMT/4Uk8DBrNnKptFYiNvuF75XpUEv4CgHRDUFgaBehOJkOI HKPkil0zv46wXWPldhcOqaBYlgC4878tbGVMBU3DNpqk0ivMSXm8doZ391JausdQ fFXr8GVgKGWxuyXGeJvSfi52quDYp0TAAIcZb59B9ORY1oxRebTGIctziyUCT8L9 QueLm9VM9VjhHwOyEP8SS6rU/u1TRMV8T3fZ+jj98h2Ed9exim2dstO6g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeiledgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 75EBCB6008D; Fri, 1 Dec 2023 09:43:55 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-1178-geeaf0069a7-fm-20231114.001-geeaf0069 MIME-Version: 1.0 Message-Id: In-Reply-To: <20231201121622.16343-2-pstanner@redhat.com> References: <20231201121622.16343-1-pstanner@redhat.com> <20231201121622.16343-2-pstanner@redhat.com> Date: Fri, 01 Dec 2023 15:43:35 +0100 From: "Arnd Bergmann" To: "Philipp Stanner" , "Bjorn Helgaas" , "Andrew Morton" , "Dan Williams" , "Jonathan Cameron" , "Jakub Kicinski" , "Dave Jiang" , "Uladzislau Koshchanka" , "Neil Brown" , "Niklas Schnelle" , "John Sanpe" , "Kent Overstreet" , "Masami Hiramatsu" , "Kees Cook" , "David Gow" , "Yury Norov" , "wuqiang.matt" , "Jason Baron" , "Kefeng Wang" , "Ben Dooks" , "Danilo Krummrich" Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Linux-Arch Subject: Re: [PATCH v2 1/4] lib: move pci_iomap.c to drivers/pci/ Content-Type: text/plain X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 01 Dec 2023 06:44:27 -0800 (PST) On Fri, Dec 1, 2023, at 13:16, Philipp Stanner wrote: > > -#ifdef CONFIG_PCI > /** You should not remove the #ifdef here, it probably results in a build failure when CONFIG_GENERIC_PCI_IOMAP is set and GENERIC_PCI is not. Alternatively you could use Kconfig or Makefile logic to prevent the file from being built without CONFIG_PCI. Arnd