Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp1084536rdb; Fri, 1 Dec 2023 06:45:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IF7SUo5MqBLv3qdzkL0j3rvLouoeFiLZIzmfJBKqVe5FLO1OkXpp8YzzQIMedg1PmH0l9QU X-Received: by 2002:a05:6a00:1882:b0:6cd:e0e5:16b4 with SMTP id x2-20020a056a00188200b006cde0e516b4mr11262780pfh.2.1701441941287; Fri, 01 Dec 2023 06:45:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701441941; cv=none; d=google.com; s=arc-20160816; b=fmRdiEvyMaEyu+LkIRem/76l1RO+F1l3vGmv255w9N83xs4FgtV7CR/f1BjNUdhZD0 rCQJ84H3rXNNMUkxu3BLWAmGFeCDCaB9OnuTzZatodaRNDaX5CdBv4qiuvisxNMjkYGO /FHGMPRiONX5l3CoyztzHKdS/F7HvfQo/bme64JyiwGcXX4cFNVc3ZZUSN+sE16VFcz4 JD0X8y29Lp6eprhgPm7sDxy6Krzylr2P6jjP03H2w+Bh06jGEsXH8TO2FAeEHW9uVuvK BTJsfcCRtFBxieJD6XFX1GPTf2FaePiDy937bTaCP56/4BGpt/NYMiUk4l0N0PEVG1Uj MgZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=scP7Kc4UKaObh0xtEvS6wmL9HVThK4eE79a/A4jC0hM=; fh=By5/Vd5k+ZfW/zpIr3JnvHnMPyytFAXAcXnk7a/x5yo=; b=GAIZLNQPbbSSdxV6N30WErdRZlnDImBTZyPzibz+WiByE6J6wkqCS/u/yg2kMhR039 zQWUZ/ua0+QUGyfJNBdsGadeiJmK35L3pmOYAyhYAPwbQgVx8g6Lu/YGk2rr/HfPK5dF c+aVfnSvJT8C2aWCs3z2eL4JAUTMKsb+ErZg4t+DMEzPcYK7KKAwzvLyI6fgn0k9hqwE Q0dAdRSz2fv4N/bqkkczXKz6Tyr2nVSVbNR/XY3g6BVc5q01ijTyHsFO3715moPZ3CuV fuE7qkhCPQoksujgnua9CyOKuCD0+rOh8jBVP81y3TPPZoYJ6s0La2Gu2otNTjsdZt63 gVTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=oFtMD8CB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id bj28-20020a056a02019c00b005c604ef1835si3664788pgb.617.2023.12.01.06.45.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 06:45:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=oFtMD8CB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 44FB5836B4C8; Fri, 1 Dec 2023 06:45:38 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379240AbjLAOpL (ORCPT + 99 others); Fri, 1 Dec 2023 09:45:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379238AbjLAOpG (ORCPT ); Fri, 1 Dec 2023 09:45:06 -0500 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9EF81717 for ; Fri, 1 Dec 2023 06:45:10 -0800 (PST) Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-50bce42295eso2508233e87.2 for ; Fri, 01 Dec 2023 06:45:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701441909; x=1702046709; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=scP7Kc4UKaObh0xtEvS6wmL9HVThK4eE79a/A4jC0hM=; b=oFtMD8CB+QmsOLVCmDENuAEM/Auz/tRCS6ww8FNecUBX3lO2I3Fd3y2uYWhYvrKaNa uJsj4hyrHAuQriav2RLG3qUSFhXcPQQLpZjHQLNFpKHEa464JiQ/8aIfwVFRgiKoQzFf H9coFG4q3BATygX8BvxDM6L22AT8HHXJGaBicfY4/efJ2iZA+HNy/80iwdqX4UMOoeRW Sd0mB890v2Fzd9KDq2jnbUllYPMsr08zzrlsIpAPJHzNiPe2Occf9UclA+gE0MJsAMo4 5sgBYT2XlmkJxuewmS5Q9U8GjGTs3C+V2jMX5SWRxW/Fh33ZJz4yWfZFGbruPVHS/kMt M+fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701441909; x=1702046709; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=scP7Kc4UKaObh0xtEvS6wmL9HVThK4eE79a/A4jC0hM=; b=uBCKmGSAulZx/wJBcpLpH8YFMB0CvnIOj8qVkW3NMi6sO1p3coHYj8JlK92Min+NKx vvqsBM548BdfCFyAlGqtP244bqTxhM7vT4spVkL0I3o+2QLqyaIDm0pQQbJ1pRjda281 8oQIYx1OOlLRLntLiLdG6H6sycwZkArFH6VfboAjrxEzZMZy/WunqYj8mP83ceALaKoE cJ9aYkFPAF6E9O9fMbvVhSJbtq/qkMUtAhbVQkOnKX74ep7MGXlTDsCzAlasEXEh9SSw yOlbv3AStQpUW/snYut+lB4hcZpaBjCSCU7eYPhFHx2Hv5eSi39WGOyltU9AhIxLz1GA XllA== X-Gm-Message-State: AOJu0Yy7oxfujRd0vDcy2WXXFtubINHUys+4UGBkiClG0FTNZHyjQn/Z Qu9AONvySvamV0inG4pd7+vW0TBLXj1Ef2bMu6I= X-Received: by 2002:a05:6512:21ac:b0:50b:cbb1:3c08 with SMTP id c12-20020a05651221ac00b0050bcbb13c08mr756768lft.36.1701441908913; Fri, 01 Dec 2023 06:45:08 -0800 (PST) Received: from [192.168.1.20] ([178.197.223.109]) by smtp.gmail.com with ESMTPSA id m9-20020a056000024900b0033334bc1338sm645717wrz.113.2023.12.01.06.45.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Dec 2023 06:45:08 -0800 (PST) Message-ID: <48cf2111-46a0-4907-8d55-5ce80b585111@linaro.org> Date: Fri, 1 Dec 2023 15:45:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] dt-bindings: clock: ti: Convert interface.txt to json-schema Content-Language: en-US To: Andreas Kemnade Cc: mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, kristo@kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org References: <20231127202359.145778-1-andreas@kemnade.info> <7a62ed8a-b0e3-4881-90d7-b8f5d38e482e@linaro.org> <20231128093241.707a4fa0@aktux> <7361082a-f271-4ef4-9dad-06ee7445c749@linaro.org> <20231128214116.22dfff1e@akair> <221ba6a3-c4c2-40cd-b1d8-8170af78c784@linaro.org> <20231201150937.3631ee99@akair> <7aaea1e4-b7bd-47e4-a6e6-32b8195ea1bf@linaro.org> <20231201154112.2ecfdab2@aktux> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20231201154112.2ecfdab2@aktux> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 01 Dec 2023 06:45:38 -0800 (PST) On 01/12/2023 15:41, Andreas Kemnade wrote: > On Fri, 1 Dec 2023 15:17:46 +0100 > Krzysztof Kozlowski wrote: > >> On 01/12/2023 15:09, Andreas Kemnade wrote: >>> Am Wed, 29 Nov 2023 09:15:57 +0100 >>> schrieb Krzysztof Kozlowski : >>> >>>> On 28/11/2023 21:41, Andreas Kemnade wrote: >>>>> Am Tue, 28 Nov 2023 09:41:23 +0100 >>>>> schrieb Krzysztof Kozlowski : >>>>>>> If the interface clock is not below a ti,clksel then we have reg. >>>>>>> >>>>>> >>>>>> This should be expressed in the bindings. It's fine to make the reg >>>>>> optional (skip the description, it's confusing), but the ti,clksel >>>>>> should reference this schema and enforce it on the children. >>>>>> >>>>> Well there are other compatibles below ti,clksel, too, so should we >>>>> rather add them when the other .txt files are converted? >>>> >>>> This binding should already be referenced by ti,clksel. When the other >>>> are ready, you will change additionalProperties from object to false. >>>> >>> I played around with it: >>> >>> --- a/Documentation/devicetree/bindings/clock/ti/ti,clksel.yaml >>> +++ b/Documentation/devicetree/bindings/clock/ti/ti,clksel.yaml >>> @@ -33,6 +33,11 @@ properties: >>> const: 2 >>> description: The CLKSEL register and bit offset >>> >>> +patternProperties: >>> + "-ick$": >>> + $ref: /schemas/clock/ti/ti,interface-clock.yaml# >>> + type: object >>> + >>> required: >>> - compatible >>> - reg >>> >>> >>> That generates warnings, which look more serious than just a >>> non-converted compatible, so lowering the overall "signal-noise-ratio". >>> >>> e.g. >>> from schema $id: >>> http://devicetree.org/schemas/clock/ti/ti,clksel.yaml# >>> /home/andi/linux-dtbs/arch/arm/boot/dts/ti/omap/omap3-overo-tobiduo.dtb: >>> clock@c40: clock-rm-ick: 'ti,index-starts-at-one', 'ti,max-div' do not >>> match any of the regexes: 'pinctrl-[0-9]+' >>> >>> I think we should rather postpone such referencing. >> >> Are you sure in such case that your binding is correct? The warnings >> suggest that not, therefore please do not postpone. >> > well, there is not only stuff from clock/ti/ti,interface.yaml but also from > clock/ti/divider.txt below ti,clksel. So I have one warning about the missing > compatible there and also about the properties belonging to that compatible. Ah, you have other bindings for the "-ick" nodes? Then you cannot match by pattern now, indeed. Maybe skipping ref but adding "compatible" into node, like we do for Qualcomm mdss bindings, would work. But in general all these should be converted at the same time. Best regards, Krzysztof