Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp1106235rdb; Fri, 1 Dec 2023 07:15:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IGo0VXCNq8mjFSjtJpl9gwdr33vI/TqIPzW/Rq5fbH3ky6KxfAfrDdnYTg7M4YQqc4Cz+oE X-Received: by 2002:a05:6a00:88f:b0:6b3:f29c:dde1 with SMTP id q15-20020a056a00088f00b006b3f29cdde1mr27963354pfj.21.1701443712007; Fri, 01 Dec 2023 07:15:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701443711; cv=none; d=google.com; s=arc-20160816; b=aii0l6MmzRQ+UB+9I9PhZ3Phb4e2H0XbAxuLuZeTK4FOYxiv/kfam2ZkQdTCY6e0A8 Ks3ril0qBurtz20H8WlxcvVTsHPN6Fx5DLNoYX1hy6lwbfN/jZ3sPIGWToAZ4AnfYYgy oOWod48ZWfXTg10EPS0a0cTCagwH20MVdANM0LRvjO/Y+35y8tZ+YVTPC3QWZsrT7nGd u6Wam3uhOq49k0LX68GsXvPtdIBgsiKFhCYEQce4MU5+dDpkIFVyyyPFtkbkXtnyVdFg yY/CvIv9abcOc96aDXRvTLxOgx4KDcPhZ8kbJZeTGDuUFpjU1BVX513DHVmFOGm88r0L BsBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=c+jx8HoyhzxiydFyXHE2frQBCbCouzHNLsW3Lqd+5ss=; fh=GKVmYqvkX1s2788UtwI7x7CJIosq2j2qYdsfYBaalVQ=; b=yqmACMiWMuDOuixWlb5YBos4eCk9oKfytKWw5XSkTrjsGKvX//F+KY8+nhgY64TILM N5qZlt1OYC72fCZk52ymyrgc6fjROesWSY79+yHEWlGY2x8nWSLAsirpb6PP+vTLqmeZ CoMOOg+yk18Newe8Ib+oU05hwbvnWWeRhNu/Pff7bRSHK0y+oCJpTNbrE6DGrLQl6ik1 DSLhQK2m7xoo1CjzY+K3Gs7QZKQXH9om7VSCZ93R5pLHqR4w0AEfoJMTDBgzqerRvsdp zKJMRWvRZpainegYvJx1eovK95+pmZXT1bk+/DE8ZBoKySzraZyoi0clrDQ2dQ1/gl0Y Intw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nogZAFzQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id f8-20020a056a00238800b006cdff9ab05fsi1313607pfc.50.2023.12.01.07.14.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 07:15:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nogZAFzQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 9F609806B57A; Fri, 1 Dec 2023 07:14:42 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379368AbjLAPOa (ORCPT + 99 others); Fri, 1 Dec 2023 10:14:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379340AbjLAPO3 (ORCPT ); Fri, 1 Dec 2023 10:14:29 -0500 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 807BE10F8 for ; Fri, 1 Dec 2023 07:14:35 -0800 (PST) Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-6cde104293fso2138078b3a.0 for ; Fri, 01 Dec 2023 07:14:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701443675; x=1702048475; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=c+jx8HoyhzxiydFyXHE2frQBCbCouzHNLsW3Lqd+5ss=; b=nogZAFzQ1gFJA34X/nOWTr5HvcbRNPOp0XtpUZ6RllfyTCHMXaKwDGvQbDFghgE1II hzC5auAy1Y9XNvNt7lt+8NaZDh8NEvqdZ52jrSQC/wyfBvRRT3c3eK4Wxp9vtFCywqzx 0Ol/V4mOt+9JSl4uahzEFX7zZscbU/eE7s44larreDSdxi3Ap1FPnsSneuaMbgxPY6BO 6Cv2GXKf4nMoupm4rCGqwbdNnvVj/+MNQdWZh5ADgoo5xTBmwOja1KL4THGoq3wb7/1B TM15Z4CPuiTY8inOSQedHD0ZWB8Nj0QnrL1sXDif4wGRldoSX93pIYz7dVeoPIJU+XuF mmeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701443675; x=1702048475; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c+jx8HoyhzxiydFyXHE2frQBCbCouzHNLsW3Lqd+5ss=; b=Ico1iPsdx4Df34u6c8YOCkpLOp7zX5kVFsmAprk8pl8dlsZwzGzjxfcZuUQ8DdXFK5 eXSUrqhLBDrojAhfVZrv+rWnE+ewj4m1R9yexhedSjjza/Hhoyew6EvnsQBWlUnZIUiF M8ORPSMt7Bw5TdnZIDOEnPVP/+jcijIn4c7pJcfERi40B+L1F7dB8F8XUXrHir4aUQCa Ve7DxUANPezyN7W7TGPx/uz4IEcbN8hQ77rPaPdyXfhad/rjy1gRIvNW8vWEY4D8/b6X /rROw2duxg41XpDKRLsVGfQUWYw65ScSOABHKTfuc3TG/NMR8RI7c0h2PBJsdBw2Hmpv Q7zg== X-Gm-Message-State: AOJu0YxOeNPR5NJ/6e8Pcl80yWOwQdasrzfsaKYcI/R9MI/0i6NlrvEC TunK6vDw+xeMgRLgesmJa57I X-Received: by 2002:a05:6a20:1614:b0:18b:f108:1595 with SMTP id l20-20020a056a20161400b0018bf1081595mr26409897pzj.53.1701443675056; Fri, 01 Dec 2023 07:14:35 -0800 (PST) Received: from localhost.localdomain ([117.213.98.226]) by smtp.gmail.com with ESMTPSA id s14-20020a65644e000000b00578afd8e012sm2765824pgv.92.2023.12.01.07.14.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 07:14:34 -0800 (PST) From: Manivannan Sadhasivam To: martin.petersen@oracle.com, jejb@linux.ibm.com Cc: andersson@kernel.org, konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, quic_cang@quicinc.com, Manivannan Sadhasivam , Abel Vesa Subject: [PATCH 02/13] scsi: ufs: qcom: Fix the return value of ufs_qcom_ice_program_key() Date: Fri, 1 Dec 2023 20:44:06 +0530 Message-Id: <20231201151417.65500-3-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231201151417.65500-1-manivannan.sadhasivam@linaro.org> References: <20231201151417.65500-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 01 Dec 2023 07:14:42 -0800 (PST) Currently, the function returns -EINVAL if algorithm other than AES-256-XTS is requested. But the correct error code is -EOPNOTSUPP. Fix it! Cc: Abel Vesa Fixes: 56541c7c4468 ("scsi: ufs: ufs-qcom: Switch to the new ICE API") Signed-off-by: Manivannan Sadhasivam --- drivers/ufs/host/ufs-qcom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c index cbb6a696cd97..852179e456f2 100644 --- a/drivers/ufs/host/ufs-qcom.c +++ b/drivers/ufs/host/ufs-qcom.c @@ -158,7 +158,7 @@ static int ufs_qcom_ice_program_key(struct ufs_hba *hba, cap = hba->crypto_cap_array[cfg->crypto_cap_idx]; if (cap.algorithm_id != UFS_CRYPTO_ALG_AES_XTS || cap.key_size != UFS_CRYPTO_KEY_SIZE_256) - return -EINVAL; + return -EOPNOTSUPP; if (config_enable) return qcom_ice_program_key(host->ice, -- 2.25.1