Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp1106829rdb; Fri, 1 Dec 2023 07:15:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IFmDc6P/f1nD5nwerwRTXP/OquTg2vFMxICQdj2H6Jz9Qv8geC/wQZ6FLtvpF0o5VAJyoh1 X-Received: by 2002:a17:90b:1a8e:b0:285:9893:b31a with SMTP id ng14-20020a17090b1a8e00b002859893b31amr22550297pjb.44.1701443751643; Fri, 01 Dec 2023 07:15:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701443751; cv=none; d=google.com; s=arc-20160816; b=sUhZU07vyS4m/eAfupU9WHx1LugYPNBrS/hZxlsrQKS01Av5mJrRq9WxacWogeLNmQ cybFO+oZf9Pk5Y91HeLLYu+EYQFde91CH0zNTQG9V41NQeX4vguLOqusqg0TK5xJbF/u aMlR73ZL9R8/FudN+A3Y5Ck5PZjASlj/D9V0X3WdHpn1VGfn+9w8EzFzYMPKWquYvXHH Rb4FasThpx/jb6opv5NChZJlyDog5sG+UmNmf2dwGMvZxsSKl0RCpRlEWtG2VGiJInnU b9wqEZiRb1hw8E/6HErezMbVF4PesaH0kl55yyNaK/SO1OSVe74xDLzez2Zv7pefcMC2 iNpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=S5u5mj8ueK+oc2yv8mZg26TvQm1X83rBh8cXq05A5b8=; fh=O5Q8LUawuCtrJk5mJG0Sz+mqyfwsmdVT26FvWpOyqg0=; b=NPtlfC+LyB83Cd8hYxptMks3kIXX85dgqRsoEmarm08NRx75Tp0OvreI/3Ebkp0WKc 52Vyjsn8Pbl66I+VFHQvOKUAQtOJALniwAe0fBnDXruRUBrz37VMz+hfwpLL0PCB9gF1 BPut/B17FlGKbNkSmprRRYuQpr7HbgCsiTdIAehG808oWfV7mejU/WJds6bLYk8k1br9 B3IkhSKfgsZQtoekMMopHFcTJr7rlWKYzV7a54tr0hVJdT3pDWzdKUU8ssdn/RB+QPmg 9dXzZIJ6+bIZlqTQ0ueWZrWXQHqqpwOfQdaoEMy3fSRdFfFHA62czqSXFLkbDRLVHb2s HiCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OqYs0GmF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id d21-20020a170902729500b001d0107ee537si3167491pll.428.2023.12.01.07.15.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 07:15:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OqYs0GmF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id AF4178374B93; Fri, 1 Dec 2023 07:15:33 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379433AbjLAPPG (ORCPT + 99 others); Fri, 1 Dec 2023 10:15:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379406AbjLAPO4 (ORCPT ); Fri, 1 Dec 2023 10:14:56 -0500 Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 246CA171A for ; Fri, 1 Dec 2023 07:14:59 -0800 (PST) Received: by mail-pf1-x429.google.com with SMTP id d2e1a72fcca58-6cdd13c586fso2048015b3a.0 for ; Fri, 01 Dec 2023 07:14:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701443698; x=1702048498; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=S5u5mj8ueK+oc2yv8mZg26TvQm1X83rBh8cXq05A5b8=; b=OqYs0GmF8HFxp5IsgzqAulfJFTwog24rf3mni9vKI2/sxOm9JPq3BaymnyA3lIYbDq lGSX+JeE8BOmoWcJ/af2/C8Z+yk8j73ivOFvKMKt3z7hSLpuZBIN2rheDuC1e24em4Hu eNpbL5BMEQjQQjMX5piE943Zp5ANR/GLCN2tG1JtzFsrpDZtQ2cLI9EoNr/QiQVAtCf3 Q5i7E6PPHlYSfWrNvjBgtCYiSeCGGs9H4Kz412qih8tCbREub2ythCx2gF1NU65jOOKh GW78sJammyY7wBmDChniak6rErGEUS+maCY9+Pzuo4QwbzbFoy6qqG1nfNpQCAR/9fWz DMig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701443698; x=1702048498; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=S5u5mj8ueK+oc2yv8mZg26TvQm1X83rBh8cXq05A5b8=; b=p1aEMkSo7WzHBoWhBBwTLlLaZh7SVzjC3RiuaDAAL9QiOeSQELO0pjfLfiNCY2J6tp gcZkjhlVkOZlPRcUeM6BatQ6VVJqDEi7rpNShdQKOBfeNAISsL5BW4X17Ae1kZXtP4sI v6FLgpLwHbfuhHxXyZ6qBqeq6jNZu2GhH3bsFnuxOI+RN9ypD2A/+WvynLk/JjjDu5Oc qzG7BA3qp+BG2yC1bq87aNWwScZcHftBoT+CEsmPJkyHZ7NszBziT9nPlerreFzjNaYF 9/IFK5rceOhsEv6lENHxrG99rT00TRA74RBgskmwS0z3Lr91zh5ZjhPfV9kpgg2Vmdo7 CITQ== X-Gm-Message-State: AOJu0Yyj267iZcYftNaNa7jQVQk0B1qg1DFIWdhTkYZnn8eqkHKVEXpl uOARapaWA6qpj8K46OjTCH0f X-Received: by 2002:a05:6a20:548e:b0:18c:8d0f:a794 with SMTP id i14-20020a056a20548e00b0018c8d0fa794mr19592802pzk.19.1701443698551; Fri, 01 Dec 2023 07:14:58 -0800 (PST) Received: from localhost.localdomain ([117.213.98.226]) by smtp.gmail.com with ESMTPSA id s14-20020a65644e000000b00578afd8e012sm2765824pgv.92.2023.12.01.07.14.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 07:14:58 -0800 (PST) From: Manivannan Sadhasivam To: martin.petersen@oracle.com, jejb@linux.ibm.com Cc: andersson@kernel.org, konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, quic_cang@quicinc.com, Manivannan Sadhasivam Subject: [PATCH 07/13] scsi: ufs: qcom: Fail ufs_qcom_power_up_sequence() when core_reset fails Date: Fri, 1 Dec 2023 20:44:11 +0530 Message-Id: <20231201151417.65500-8-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231201151417.65500-1-manivannan.sadhasivam@linaro.org> References: <20231201151417.65500-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 01 Dec 2023 07:15:33 -0800 (PST) Even though core_reset is optional, a failure during assert/deassert should be considered fatal, if core_reset is available. So fail ufs_qcom_power_up_sequence() if an error happens during reset and also get rid of the redundant warning as the ufs_qcom_host_reset() function itself prints error messages. Signed-off-by: Manivannan Sadhasivam --- drivers/ufs/host/ufs-qcom.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c index 604273a22afd..4948dd732aae 100644 --- a/drivers/ufs/host/ufs-qcom.c +++ b/drivers/ufs/host/ufs-qcom.c @@ -359,8 +359,7 @@ static int ufs_qcom_power_up_sequence(struct ufs_hba *hba) /* Reset UFS Host Controller and PHY */ ret = ufs_qcom_host_reset(hba); if (ret) - dev_warn(hba->dev, "%s: host reset returned %d\n", - __func__, ret); + return ret; /* phy initialization - calibrate the phy */ ret = phy_init(phy); -- 2.25.1