Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp1107180rdb; Fri, 1 Dec 2023 07:16:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IGFApbOiq/QPuWJWW2j8ORrBDeyOObaOQZX+UYchpyCRbws45TipbWmSTMJn0H0pbrayXJX X-Received: by 2002:a05:6a21:33a2:b0:18b:9031:822a with SMTP id yy34-20020a056a2133a200b0018b9031822amr30198224pzb.46.1701443776102; Fri, 01 Dec 2023 07:16:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701443776; cv=none; d=google.com; s=arc-20160816; b=HHoOQEnSbpk9GRbL3gXuElfa/vEU9ut4RM2qDRLHJHcKQFe+ebQOaguQ7VsTA9+n6I sf8x1lHu6/tKjf6F51CsOJEy2sOEj9V8+m2jerQN2tawtjub032QKs+ljx9Il1Gj33nl gytQTAcNlTRcvfKo6EbVShx59qKtHzo0IY/w/w6PIG1YVaRIierV4iZu2wsX/HVfAqAn c7vLycFyhIaoX01U0pL68032fpjeC43G4g4Xq8wO/t0hhiOiJjIj+HcORzvMXE8Qh/gU 5cVr4Sp9+bLO7i3s77l+mUEkeiAXXcX2oOcCeigJZZkO0l40b7gCO+l29ioEDkavT8pk qhsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=7s+dxOARPtmuDtxtrPmYWXFcx5QSwMABsj/xuwm0cfM=; fh=O5Q8LUawuCtrJk5mJG0Sz+mqyfwsmdVT26FvWpOyqg0=; b=RfZVa3sGnRYdtbk/P7QE7Yp0S3SfDugtsz9WpYAj/0h6LhiB3Ncx6duaM6edDyyUbm xXmyTi7ERE2/hTm4NGDUU/KRSN8EDNS5bsHa/IdFAO0OoyKPPHtywtpSXQepCoswKsSH IpLcW+l08FzCKCIMKAsYOnmQcaeT7gV9qZAz+4vVGC0MP4JQlKiIC2eIoKluWDU82oCN SWEazzGMoc8SBF1D6aZF8ACHggQnqDaPountEUhukaPYEUrrw33ilywm3lPSeHVwWiRL +wpDZ82tFSHp6WLS03MJ4u1AjzwdnDoXFMIKMdLJOp6adC4Wjk2MjXs1MzSEscUzk5Hc GFhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="a/WAEUWw"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id q33-20020a635061000000b00578ca217740si3533017pgl.711.2023.12.01.07.16.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 07:16:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="a/WAEUWw"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 340FF8076174; Fri, 1 Dec 2023 07:15:32 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379472AbjLAPPP (ORCPT + 99 others); Fri, 1 Dec 2023 10:15:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379428AbjLAPPB (ORCPT ); Fri, 1 Dec 2023 10:15:01 -0500 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C7BE1725 for ; Fri, 1 Dec 2023 07:15:06 -0800 (PST) Received: by mail-pj1-x1034.google.com with SMTP id 98e67ed59e1d1-28648be0811so1447986a91.0 for ; Fri, 01 Dec 2023 07:15:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701443705; x=1702048505; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7s+dxOARPtmuDtxtrPmYWXFcx5QSwMABsj/xuwm0cfM=; b=a/WAEUWwXBU2IwTd/1lnStFpgCNRsM5snta4eqSqhLzBSBwpsjhVCyYVYV2lD/WBVS mbK/kKi8hhafFgki7Qke4VWPLBaLVImDjo6NBPn1bm3a1GvCkZ0+dXjGVHMVK+yz+ULe oYrdGfOX5MjAeEeT4kdwQP9lF1ejE8xyN2lHRc6ITB5fuWqYJepJip1GcRZ6r3sphNuX Qtzf+A6M6VkKAP2DtPIU5aln+GiDMb3JrCAeXSJU6d9i+kCdsm1ElijHkwoTVlLBuS/r FeoRBICXTsomzzFwdEpmQnGC+jZXB6VG2ejEmh3/xzob3O/wH+KPR86ty7Nt/YJjAb41 cXAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701443705; x=1702048505; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7s+dxOARPtmuDtxtrPmYWXFcx5QSwMABsj/xuwm0cfM=; b=PPii7S7xsHFi0RphdrzuF2n/XIEMuDUo+3yP193nFRRS7Ky64xF42Kt9uyh5RrOe5Z uWo2bZ5lXI0Ysw1jTEoKiIGWnjtnkxXtWMBe8d2GD48TMsivoNbG3Rv98d1/zZIv5Jty snT/1jz2mo7OWnmu78+HUaEeVKfaY/e9VGBX4/02e27NgsskzFbprJ/0U4uBpubd/5rm Lfe/Rbgk3Ew3kQjQde59OMYTzvN6m9JqUwvciwDEt6A2clbcJHypZHLuxPTySmfIs1m/ OmyBqiZ9GddEW4PAzhwailWweJA3qtYXBr6b/nswhPuIh4xctRD0YUON4GP4H72Gsn2b ygfg== X-Gm-Message-State: AOJu0Yzr+5DUo60atWAOZ4+xA97RfvUKuFGF14whCzHjT2IcLTTsC8Lw g/0QdO1r2JR5rEMejAVG6m8l X-Received: by 2002:a17:90b:1a8d:b0:285:81aa:aec0 with SMTP id ng13-20020a17090b1a8d00b0028581aaaec0mr26173302pjb.12.1701443705444; Fri, 01 Dec 2023 07:15:05 -0800 (PST) Received: from localhost.localdomain ([117.213.98.226]) by smtp.gmail.com with ESMTPSA id s14-20020a65644e000000b00578afd8e012sm2765824pgv.92.2023.12.01.07.15.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 07:15:04 -0800 (PST) From: Manivannan Sadhasivam To: martin.petersen@oracle.com, jejb@linux.ibm.com Cc: andersson@kernel.org, konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, quic_cang@quicinc.com, Manivannan Sadhasivam Subject: [PATCH 09/13] scsi: ufs: qcom: Remove redundant error print for devm_kzalloc() failure Date: Fri, 1 Dec 2023 20:44:13 +0530 Message-Id: <20231201151417.65500-10-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231201151417.65500-1-manivannan.sadhasivam@linaro.org> References: <20231201151417.65500-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 01 Dec 2023 07:15:32 -0800 (PST) devm_kzalloc() will itself print the error message on failure. So let's get rid of the redundant error message in ufs_qcom_init(). Signed-off-by: Manivannan Sadhasivam --- drivers/ufs/host/ufs-qcom.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c index e4dd3777a4d4..218d22e1efce 100644 --- a/drivers/ufs/host/ufs-qcom.c +++ b/drivers/ufs/host/ufs-qcom.c @@ -1107,10 +1107,8 @@ static int ufs_qcom_init(struct ufs_hba *hba) struct ufs_clk_info *clki; host = devm_kzalloc(dev, sizeof(*host), GFP_KERNEL); - if (!host) { - dev_err(dev, "%s: no memory for qcom ufs host\n", __func__); + if (!host) return -ENOMEM; - } /* Make a two way bind between the qcom host and the hba */ host->hba = hba; -- 2.25.1