Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp1107650rdb; Fri, 1 Dec 2023 07:16:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IGxXWJZbcjuUZZ7ZwHrPv4spvCriMtloPyU4btT6dC36kV2qLuWUgzKs9o+duygmpmWTqQu X-Received: by 2002:a05:6a21:7891:b0:18b:950d:de3b with SMTP id bf17-20020a056a21789100b0018b950dde3bmr31402671pzc.38.1701443810459; Fri, 01 Dec 2023 07:16:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701443810; cv=none; d=google.com; s=arc-20160816; b=aLHIPpOUB1mX2gBQud3oswF49LVOTJrr2u+2/lAMZC3DejyBR0oCu2smn+iNNDouM3 nbrVYcdifQlRGMr/gHoDWdVuieZclkoujrQdiZMOw9/0Bm++cR+eZ0oz4lAxHbPPnqPl +IK+jVSbLv7J5vnJio87BjwdNEl5oC1R0ghhFvnro743rDLslnQz5+pGVUeqdK0y/nmR WIXmz2qVrQAzfLc+MRLH4t95vIHC5tURMF/QOW3IfuktC8Nxmt3LQ1JSz0DPv1DkN01D m3ekrSDpzpMVUm78BUAjgqQatlh9dMUuGgG2GEVaNuMkTS/JhuoAUY3E/jkRxTrFRBQf Dalw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=63N0jK5ZcBeJuBTrtXzoyRGZDNopQVJCv+vFWIRCiEI=; fh=O5Q8LUawuCtrJk5mJG0Sz+mqyfwsmdVT26FvWpOyqg0=; b=CStPJAarna9l0+CGvATzvssDO82QT0ICSelRzLsLagoAjajQ2qAnlDbw7y/zxlTalL tSy/pOkeWb3zzP+Vj5KJg9Thm8CNhgb/jIqi+ZHEpCpVWRN5y70eZMmx8OGeOC6/7jom fzHs+sLDEH/IbqHEV8mU/px4uNhOzX4adRfxY+yfozg2udfNk3Mp9fjV3grsxP8Y4Lpz nlVBHcC2zohFuMT9+/zfhig2z+iBBkg6NgA16RCTaWz9StIANt8iLfALEn+Oe6DzuC5y e+6EP/JQ4oVJ7BTSOrxM06WAHYsMMnL0nKPkUkraGf5yvO12xN40p+8H/Bc3hPLihJif 8uag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Fjo9L6Jc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id v16-20020a63f850000000b005c1b58a321asi3699944pgj.411.2023.12.01.07.16.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 07:16:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Fjo9L6Jc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 429FF80732B4; Fri, 1 Dec 2023 07:15:23 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379328AbjLAPPC (ORCPT + 99 others); Fri, 1 Dec 2023 10:15:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379405AbjLAPO4 (ORCPT ); Fri, 1 Dec 2023 10:14:56 -0500 Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E1E2171F for ; Fri, 1 Dec 2023 07:15:02 -0800 (PST) Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-6cdd9c53270so1923392b3a.1 for ; Fri, 01 Dec 2023 07:15:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701443702; x=1702048502; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=63N0jK5ZcBeJuBTrtXzoyRGZDNopQVJCv+vFWIRCiEI=; b=Fjo9L6Jc+XW3mkryMOXpBapHySvMEDBSGGCVBO8lKPjx7PdZLuWUaLsxYvzM/zTFbn 4ELY1d/1mbI2mv6Fc2GfQZ+WiWX6jtLmyhZJIze7wkAIcN+3BQQr+tHhd9n+DP048NB4 XseAf8A8MyPaH/SxxUxVuJ/OxSGM7FTYwaafsbEoIwBG8tVzOem6LWxZhepU8ru5LFQo JxAF4oWgM8154LI6XfpShBUPEntXLajZRlDIjE/MSLb1kIV/UDEkau5s/8tyzykTtvL3 IpskeAyOYgH7I6YtD2v9Pg15b9C3SNioexQinroYbUk1vXzbPtjfyrbHZN05WXqmBBHU LZ+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701443702; x=1702048502; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=63N0jK5ZcBeJuBTrtXzoyRGZDNopQVJCv+vFWIRCiEI=; b=Ar44dMV6Ho4GxZxvHYWMwGWAX//ieL9SPZ+77BsWkHHJQS9KzzPe+MxnCWoTWDvCxr vSpvMVCD1PhsNCSxqiBUyWRAdtqGDL06W1mdZ/1ZE0kLTdrw5J/f2m1+z386jQA+v+zG VIQwKPaV4zAd8lpyMHJQxOXCRldtjMm/KANYhTbDRNF1r13eYvZEjL+pFjmKv1gVDvfg zeWv0xCxhuG1hchUFdzxDwwPcyo35Tk3oiFi5bqzFb62ba5ARZqKPMP3THrL3QA3E0yN RaOG8phvPAB+JOaqkpUdHPZ1V9IPEbDQdwPVXLko1fcBFAPbzeHd6RZzX+e3CV2+i7ng e8WA== X-Gm-Message-State: AOJu0YylNmSBB1M2J+XtWhPw35+mqtaaZOvPdoUEbyIC1MMakhAYBbZx s5hofkdFINDNVpOd6405eKxSLmats5y+Dn0HFg== X-Received: by 2002:a05:6a20:9150:b0:18b:9682:59e9 with SMTP id x16-20020a056a20915000b0018b968259e9mr26138765pzc.21.1701443701963; Fri, 01 Dec 2023 07:15:01 -0800 (PST) Received: from localhost.localdomain ([117.213.98.226]) by smtp.gmail.com with ESMTPSA id s14-20020a65644e000000b00578afd8e012sm2765824pgv.92.2023.12.01.07.14.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 07:15:01 -0800 (PST) From: Manivannan Sadhasivam To: martin.petersen@oracle.com, jejb@linux.ibm.com Cc: andersson@kernel.org, konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, quic_cang@quicinc.com, Manivannan Sadhasivam Subject: [PATCH 08/13] scsi: ufs: qcom: Check the return value of ufs_qcom_power_up_sequence() Date: Fri, 1 Dec 2023 20:44:12 +0530 Message-Id: <20231201151417.65500-9-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231201151417.65500-1-manivannan.sadhasivam@linaro.org> References: <20231201151417.65500-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 01 Dec 2023 07:15:23 -0800 (PST) If ufs_qcom_power_up_sequence() fails, then it makes no sense to enable the lane clocks and continue ufshcd_hba_enable(). So let's check the return value of ufs_qcom_power_up_sequence(). Signed-off-by: Manivannan Sadhasivam --- drivers/ufs/host/ufs-qcom.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c index 4948dd732aae..e4dd3777a4d4 100644 --- a/drivers/ufs/host/ufs-qcom.c +++ b/drivers/ufs/host/ufs-qcom.c @@ -415,7 +415,10 @@ static int ufs_qcom_hce_enable_notify(struct ufs_hba *hba, switch (status) { case PRE_CHANGE: - ufs_qcom_power_up_sequence(hba); + err = ufs_qcom_power_up_sequence(hba); + if (err) + return err; + /* * The PHY PLL output is the source of tx/rx lane symbol * clocks, hence, enable the lane clocks only after PHY -- 2.25.1