Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
MIME-Version: 1.0
References: <20231201-x1e80100-drm-panel-edp-v1-1-ef9def711d8a@linaro.org>
In-Reply-To: <20231201-x1e80100-drm-panel-edp-v1-1-ef9def711d8a@linaro.org>
From:   Doug Anderson <dianders@chromium.org>
Date:   Fri, 1 Dec 2023 07:19:22 -0800
Message-ID: <CAD=FV=XLbuOwtYiP7w+dqRK3p0QM3maumQ2TOL7+N1SXqi9f0A@mail.gmail.com>
Subject: Re: [PATCH] drm/panel-edp: Add SDC ATNA45AF01
To:     Abel Vesa <abel.vesa@linaro.org>
Cc:     Neil Armstrong <neil.armstrong@linaro.org>,
        Jessica Zhang <quic_jesszhan@quicinc.com>,
        Sam Ravnborg <sam@ravnborg.org>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

On Fri, Dec 1, 2023 at 5:13=E2=80=AFAM Abel Vesa <abel.vesa@linaro.org> wro=
te:
>
> Add support for the SDC ATNA45AF01 panel.
>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>  drivers/gpu/drm/panel/panel-edp.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/pa=
nel-edp.c
> index 825fa2a0d8a5..467a42eddbe9 100644
> --- a/drivers/gpu/drm/panel/panel-edp.c
> +++ b/drivers/gpu/drm/panel/panel-edp.c
> @@ -1988,6 +1988,7 @@ static const struct edp_panel_entry edp_panels[] =
=3D {
>         EDP_PANEL_ENTRY('S', 'H', 'P', 0x154c, &delay_200_500_p2e100, "LQ=
116M1JW10"),
>
>         EDP_PANEL_ENTRY('S', 'T', 'A', 0x0100, &delay_100_500_e200, "2081=
116HHD028001-51D"),
> +       EDP_PANEL_ENTRY('S', 'D', 'C', 0x416d, &delay_100_500_e200, "ATNA=
45AF01"),

'SDC' should sort above 'STA' (and 'SHP'). Each of the manufacturers
have their own "block". Since this is the first 'SDC' it should get
its own block (with a blank line before and after) between 'KDB' and
'SHP'.

-Doug