Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
From:   =?iso-8859-1?Q?Jan_Kundr=E1t?= <jan.kundrat@cesnet.cz>
To:     Hugo Villeneuve <hugo@hugovil.com>
Cc:     <gregkh@linuxfoundation.org>, <jirislaby@kernel.org>,
        <hvilleneuve@dimonoff.com>, <linux-kernel@vger.kernel.org>,
        <linux-serial@vger.kernel.org>
Subject: Re: [PATCH 6/7] serial: max310x: add macro for max number of ports
Date:   Fri, 01 Dec 2023 16:59:12 +0100
MIME-Version: 1.0
Message-ID: <ddbc67dd-f8a3-4a6a-954a-bee49260ecab@cesnet.cz>
In-Reply-To: <20231130191050.3165862-7-hugo@hugovil.com>
References: <20231130191050.3165862-1-hugo@hugovil.com>
 <20231130191050.3165862-7-hugo@hugovil.com>
Organization: CESNET
User-Agent: Trojita/unstable-2022-08-22; Qt/5.15.10; wayland; Linux; 
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On =C4=8Dtvrtek 30. listopadu 2023 20:10:48 CET, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
>
> Add macro to hold the maximum number of UART ports per IC/device.
>
> Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>

Reviewed-by: Jan Kundr=C3=A1t <jan.kundrat@cesnet.cz>
Tested-by: Jan Kundr=C3=A1t <jan.kundrat@cesnet.cz>

> ---
>  drivers/tty/serial/max310x.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/max310x.c b/drivers/tty/serial/max310x.c
> index f3a99daebdaa..58dd5cc62014 100644
> --- a/drivers/tty/serial/max310x.c
> +++ b/drivers/tty/serial/max310x.c
> @@ -30,6 +30,7 @@
>  #define MAX310X_MAJOR=09=09=09204
>  #define MAX310X_MINOR=09=09=09209
>  #define MAX310X_UART_NRMAX=09=0916
> +#define MAX310X_MAX_PORTS=09=094 /* Maximum number of UART ports per IC. *=
/
> =20
>  /* MAX310X register definitions */
>  #define MAX310X_RHR_REG=09=09=09(0x00) /* RX FIFO */
> @@ -1502,7 +1503,7 @@ static const struct max310x_if_cfg=20
> __maybe_unused max310x_spi_if_cfg =3D {
>  static int max310x_spi_probe(struct spi_device *spi)
>  {
>  =09const struct max310x_devtype *devtype;
> -=09struct regmap *regmaps[4];
> +=09struct regmap *regmaps[MAX310X_MAX_PORTS];
>  =09unsigned int i;
>  =09int ret;
> =20
> @@ -1605,7 +1606,7 @@ static int max310x_i2c_probe(struct=20
> i2c_client *client)
>  =09const struct max310x_devtype *devtype =3D
>  =09=09=09device_get_match_data(&client->dev);
>  =09struct i2c_client *port_client;
> -=09struct regmap *regmaps[4];
> +=09struct regmap *regmaps[MAX310X_MAX_PORTS];
>  =09unsigned int i;
>  =09u8 port_addr;
> =20