Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
From:   Frank Li <Frank.Li@nxp.com>
To:     manivannan.sadhasivam@linaro.org
Cc:     Frank.Li@nxp.com, bhelgaas@google.com, imx@lists.linux.dev,
        kw@linux.com, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
        linuxppc-dev@lists.ozlabs.org, lpieralisi@kernel.org,
        minghuan.Lian@nxp.com, mingkai.hu@nxp.com, robh@kernel.org,
        roy.zang@nxp.com
Subject: [PATCH v5 4/4] PCI: layerscape: Add suspend/resume for ls1043a
Date:   Fri,  1 Dec 2023 11:17:12 -0500
Message-Id: <20231201161712.1645987-5-Frank.Li@nxp.com>
In-Reply-To: <20231201161712.1645987-1-Frank.Li@nxp.com>
References: <20231201161712.1645987-1-Frank.Li@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?j/UcZxrp+TpWsNdxFTZpVAywkGk0XHhDmLfWJNtdjIymhFiX3bmsUwGJwQdV?=
 =?us-ascii?Q?E7tYCKFZo/idG2SNWMiiwdJqzEkZF0mpTgO3hDwipk56YesJfXFUPqvEijdd?=
 =?us-ascii?Q?u/RBfINLIbjClw2vn03xb3J8CiNzMugimKB12XOr8v11BHrAhga2ZsoMqYJi?=
 =?us-ascii?Q?gUHCCflTsyW8JnWfQV+SUA8d2DnKSZ6p+IfCHsZ1xoKgh6dchKD/lSxVosEw?=
 =?us-ascii?Q?pAtOecrp0H9HdzpVgtES9hhMksUUMELJcDZ+ei2JjQJBbKVuILnEj/ov5eB3?=
 =?us-ascii?Q?3gGyHmOZL0Cl85ozgNAdxW5HIfy0+BUn02ibcoJLmAxqJ+DotjHKwQ8Elpks?=
 =?us-ascii?Q?KEsGqBkpMfx9gjbi7Ah3uM2tBIsOZy7fHxNEv5JtCJr88I3plllD2Xg/JESV?=
 =?us-ascii?Q?XxjeV9qCXhu8mh2BGb//7k/Zq6g4lBZoe5uGZiCFE8q+cG6jv9lfGTrrexeE?=
 =?us-ascii?Q?aWTfRkUSt36d4r9tuE+ZmulDs1aTazq+UVNGfBWR0c5xOynxWx9XwyHSehns?=
 =?us-ascii?Q?xkekNiyMgOADqEAh24eKBIAjNsJVBfc0rvcbb5mEVfwrB3uk6Nkz5+nXFH1x?=
 =?us-ascii?Q?bBf3L/RCndoSMLbUHRqfcuH2OvMto05mgiwpqnUtCDZdfBQ0ibNtsEtPzuMJ?=
 =?us-ascii?Q?qZzLEW2j1HnF95z0WNy1u+7HUd1jFwAVV04FIqjnhpY68Q+bjxLBRIIvdW22?=
 =?us-ascii?Q?GMP7lc8uRfKU8JGSMzFrIJcyJnyBc6AL+xGLQq3O+HffnbFQL+hfG4KXgmbW?=
 =?us-ascii?Q?SLRfPJ/yGmBZqHSzGEwOfijWmzCqlH/UTNqmjmAnF499uMw88Hy1HYlDLrAL?=
 =?us-ascii?Q?WyYQ8fGYgm8407625kSj7de1PG8IdrI9SBwtJOz0WnhTfxVFZJURcuI8g9h1?=
 =?us-ascii?Q?Y3z8otIF4EI6d04lCKFbjpQQNoLwML6MphRMMeH/a+sfBS1eEYLAOu9fqtRV?=
 =?us-ascii?Q?/+gh5roUldQsQSeDAqWzeSR4pHb6mELHVns2jU9+1fKQf2XEY0yX3EkLePYN?=
 =?us-ascii?Q?L/tj6WivoDxAD+hwvVcHm5LncbSmfBh0uNw5us+bvv9wDrhexTpBQwyx/ooV?=
 =?us-ascii?Q?kMfhx4kFOyom34kVxqR+/Yp9I1vmX4guNAIGeLCvvPaNbPHq22HDjijoeudB?=
 =?us-ascii?Q?x8nvHX/R3JznFtzcI6w3JhyjykcWOnvhrSQbUdp9nzVaQWaa7xlGJOql9LPQ?=
 =?us-ascii?Q?P0BoG400l5GNLQQkw1wnZHotLow4ghPuMDna4p3JGp2Y7KNkTyP6eNmlYbm1?=
 =?us-ascii?Q?50HYmkTa+azfnLSfEhKBtklud9DqGQrc4VlbMvkEyo6euozHOYho8/iNs4xB?=
 =?us-ascii?Q?wfPCPzOxpkbOVqCuelShzSKPE+sAZIjPVXOcjkL/8jb+1XiL/za2i7/zyNdA?=
 =?us-ascii?Q?PSUlb0PvkJXXJ8yVsfuFP1ji5ed2w/v06vVvEArBI9xwrLmla3jZvEZuK5gE?=
 =?us-ascii?Q?mK+QbJ1GLWgruvN0HMfgj54ZDZRd4kmfTwYRfAMqB6wWBBt1paaZ9r/c34cB?=
 =?us-ascii?Q?p2i2+LWPjYJav9/8KcsBvbC3essB9sVo/JyYvEMdoXXqShiwCjt9kFCZDms7?=
 =?us-ascii?Q?nz2dg2hUBxyN6xHZ+/ojHBHnv49f0SfniFrkg0m5?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bef8c711-36c9-443a-1a8f-08dbf2890d74
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2023 16:17:45.4793
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 69YYGyPL8EkMJM79V/u0Fm/HT5/tQFxhbjGkSDdtoqfMtRKuSJmiGHJXXYYGHsBGB2pg1AWoS4DMNSWEr3AReQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8695
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 01 Dec 2023 08:19:08 -0800 (PST)

Add suspend/resume support for Layerscape LS1043a.

In the suspend path, PME_Turn_Off message is sent to the endpoint to
transition the link to L2/L3_Ready state. In this SoC, there is no way to
check if the controller has received the PME_To_Ack from the endpoint or
not. So to be on the safer side, the driver just waits for
PCIE_PME_TO_L2_TIMEOUT_US before asserting the SoC specific PMXMTTURNOFF
bit to complete the PME_Turn_Off handshake. Then the link would enter L2/L3
state depending on the VAUX supply.

In the resume path, the link is brought back from L2 to L0 by doing a
software reset.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---

Notes:
    Change from v4 to v5
    - update commit message
    - use comments
    /* Reset the PEX wrapper to bring the link out of L2 */
    
    Change from v3 to v4
    - Call scfg_pcie_send_turnoff_msg() shared with ls1021a
    - update commit message
    
    Change from v2 to v3
    - Remove ls_pcie_lut_readl(writel) function
    
    Change from v1 to v2
    - Update subject 'a' to 'A'

 drivers/pci/controller/dwc/pci-layerscape.c | 63 ++++++++++++++++++++-
 1 file changed, 62 insertions(+), 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pci-layerscape.c b/drivers/pci/controller/dwc/pci-layerscape.c
index a9151e98fde6f..715365e91f8ef 100644
--- a/drivers/pci/controller/dwc/pci-layerscape.c
+++ b/drivers/pci/controller/dwc/pci-layerscape.c
@@ -41,6 +41,15 @@
 #define SCFG_PEXSFTRSTCR	0x190
 #define PEXSR(idx)		BIT(idx)
 
+/* LS1043A PEX PME control register */
+#define SCFG_PEXPMECR		0x144
+#define PEXPME(idx)		BIT(31 - (idx) * 4)
+
+/* LS1043A PEX LUT debug register */
+#define LS_PCIE_LDBG	0x7fc
+#define LDBG_SR		BIT(30)
+#define LDBG_WE		BIT(31)
+
 #define PCIE_IATU_NUM		6
 
 struct ls_pcie_drvdata {
@@ -224,6 +233,45 @@ static int ls1021a_pcie_exit_from_l2(struct dw_pcie_rp *pp)
 	return scfg_pcie_exit_from_l2(pcie->scfg, SCFG_PEXSFTRSTCR, PEXSR(pcie->index));
 }
 
+static void ls1043a_pcie_send_turnoff_msg(struct dw_pcie_rp *pp)
+{
+	struct dw_pcie *pci = to_dw_pcie_from_pp(pp);
+	struct ls_pcie *pcie = to_ls_pcie(pci);
+
+	scfg_pcie_send_turnoff_msg(pcie->scfg, SCFG_PEXPMECR, PEXPME(pcie->index));
+}
+
+static int ls1043a_pcie_exit_from_l2(struct dw_pcie_rp *pp)
+{
+	struct dw_pcie *pci = to_dw_pcie_from_pp(pp);
+	struct ls_pcie *pcie = to_ls_pcie(pci);
+	u32 val;
+
+	/*
+	 * Reset the PEX wrapper to bring the link out of L2.
+	 * LDBG_WE: allows the user to have write access to the PEXDBG[SR] for both setting and
+	 *	    clearing the soft reset on the PEX module.
+	 * LDBG_SR: When SR is set to 1, the PEX module enters soft reset.
+	 */
+	val = ls_pcie_pf_lut_readl(pcie, LS_PCIE_LDBG);
+	val |= LDBG_WE;
+	ls_pcie_pf_lut_writel(pcie, LS_PCIE_LDBG, val);
+
+	val = ls_pcie_pf_lut_readl(pcie, LS_PCIE_LDBG);
+	val |= LDBG_SR;
+	ls_pcie_pf_lut_writel(pcie, LS_PCIE_LDBG, val);
+
+	val = ls_pcie_pf_lut_readl(pcie, LS_PCIE_LDBG);
+	val &= ~LDBG_SR;
+	ls_pcie_pf_lut_writel(pcie, LS_PCIE_LDBG, val);
+
+	val = ls_pcie_pf_lut_readl(pcie, LS_PCIE_LDBG);
+	val &= ~LDBG_WE;
+	ls_pcie_pf_lut_writel(pcie, LS_PCIE_LDBG, val);
+
+	return 0;
+}
+
 static const struct dw_pcie_host_ops ls_pcie_host_ops = {
 	.host_init = ls_pcie_host_init,
 	.pme_turn_off = ls_pcie_send_turnoff_msg,
@@ -241,6 +289,19 @@ static const struct ls_pcie_drvdata ls1021a_drvdata = {
 	.exit_from_l2 = ls1021a_pcie_exit_from_l2,
 };
 
+static const struct dw_pcie_host_ops ls1043a_pcie_host_ops = {
+	.host_init = ls_pcie_host_init,
+	.pme_turn_off = ls1043a_pcie_send_turnoff_msg,
+};
+
+static const struct ls_pcie_drvdata ls1043a_drvdata = {
+	.pf_lut_off = 0x10000,
+	.pm_support = true,
+	.scfg_support = true,
+	.ops = &ls1043a_pcie_host_ops,
+	.exit_from_l2 = ls1043a_pcie_exit_from_l2,
+};
+
 static const struct ls_pcie_drvdata layerscape_drvdata = {
 	.pf_lut_off = 0xc0000,
 	.pm_support = true,
@@ -252,7 +313,7 @@ static const struct of_device_id ls_pcie_of_match[] = {
 	{ .compatible = "fsl,ls1012a-pcie", .data = &layerscape_drvdata },
 	{ .compatible = "fsl,ls1021a-pcie", .data = &ls1021a_drvdata },
 	{ .compatible = "fsl,ls1028a-pcie", .data = &layerscape_drvdata },
-	{ .compatible = "fsl,ls1043a-pcie", .data = &ls1021a_drvdata },
+	{ .compatible = "fsl,ls1043a-pcie", .data = &ls1043a_drvdata },
 	{ .compatible = "fsl,ls1046a-pcie", .data = &layerscape_drvdata },
 	{ .compatible = "fsl,ls2080a-pcie", .data = &layerscape_drvdata },
 	{ .compatible = "fsl,ls2085a-pcie", .data = &layerscape_drvdata },
-- 
2.34.1