Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp1157933rdb; Fri, 1 Dec 2023 08:23:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IFSWFDlXB9DYBvCWnIiFagpFPKISTU5cjqpjhLVf2jWvf2SRzGHPsVcjlW84kQv8ZuAulAj X-Received: by 2002:a05:6a20:5491:b0:18c:5e1:77b8 with SMTP id i17-20020a056a20549100b0018c05e177b8mr26654224pzk.58.1701447806722; Fri, 01 Dec 2023 08:23:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701447806; cv=none; d=google.com; s=arc-20160816; b=n36X2Z8iARLT7JjZ6P9Y8soTfVy94+C1SFmEJS6R9TbOCMlz/9jAsZKN+qaxmupEu4 1xBgDuoWp2K4Jb5KMY1cegNMwF1h6Gx+n5VkxppJJLNKmKbqMGoZ/5Lsv1ERLwbG66Uc EmMBhfywp2dG+WqHbLfRaUd0qL9o9q/Vls0tjPb062hS3NgpOx/UYQC4I8g8emnOCZ4W 4IDc/DOlhRBqUslNchHmaK9hzU8EiA8O4Xm6/sm0Uq5lfFFv48F/6tzSbaJLuaTm+XSj wjFnN6c0dIp3Tc5FnbwjyHQVgjGfoOKf2Tb6CVtGhdXQxB5Wn9rZYK6fl2yksP46GMoS NpFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=tGkPDvYD9S5sLT7Aa1dWWIatfoZPwy76iMxxH8+zUTM=; fh=stOPHmVAFr/XRPUEilp8rbwaXNdU0YC5moHCEH0Pp74=; b=AwmzDpkk3P176jpxW3/v4j7sxgWR0JXy1OOWxjrqnQKEK6vMJpdv3T1kubvjTzixdp z5Ie13e9llEzAMXJ/c8FH31WeyyTva6H1/8v0/bAUumgLkNJLE6K4qR8j49434I0nYFF bv/WxqmbUPsCL6kGSk3SIXQSQePZLuvDDcrujbZpwMss5ztIB6+ug5vmNCr1IQ6BRxLH XnareVM3HCedWqX4Hrv9tWTg6ONyJ5SxHCC6cxSKH5QG28LB+9URnHfuBqiFXIF6ZX2n mqOeIFHq5eYfT0URyWF6oCxMKcu33U08IUJPKPTnqhbCixe66SpS9Zr/Ik1FO1qi5Mzq Wkqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Zn6nBJb8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id ch4-20020a056a0208c400b005be03f0da78si3893632pgb.157.2023.12.01.08.23.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 08:23:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Zn6nBJb8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id B8FDC826ECB1; Fri, 1 Dec 2023 08:23:17 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229674AbjLAQXF (ORCPT + 99 others); Fri, 1 Dec 2023 11:23:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229594AbjLAQXE (ORCPT ); Fri, 1 Dec 2023 11:23:04 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EBE999 for ; Fri, 1 Dec 2023 08:23:11 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57517C433C9; Fri, 1 Dec 2023 16:23:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701447790; bh=VqD6tqAKvBli0h35Lj6ytxi1kUwFp8UhPyDk4jHxCVY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Zn6nBJb88f438PDuNJ2l8qSmfontxShAiF6h1RwXvJ7Q60gMerp/4QmQpqNNvmFEd q+r5m4IAcYgnodZUUIzO+PcIpEBlO5smp4dS0GGGlJWLVBvwzkXinFTHV4nxkGyRch iwD0lTtYmlZ0PwvJR4+QnDXMnkwa/OSY0rgSR3qMDH42od2ijJrvUxvBn/kdMQ8aaE bj0IeTRCjS4+0ABevO6F//NRmMI1vr71mF97PLV2ezUnBcDxU52nCrQc8+JVT79LTg IYNKXxCNW8GMZcXDq7Sx4MaLfckZMjGRFRUeMlci0jQTB3jFnLelcp+5z5iSFiBR3I 0TxAdNDAAW4+w== Date: Fri, 1 Dec 2023 16:23:06 +0000 From: Mark Brown To: Andy Shevchenko Cc: Jan =?iso-8859-1?Q?Kundr=E1t?= , Cosmin Tanislav , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tty: max310x: work around regmap->regcache data corruption Message-ID: <6986fb70-bc99-4210-a622-16f0d0303d27@sirena.org.uk> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="qdnQx0uLPm9zl6Yh" Content-Disposition: inline In-Reply-To: X-Cookie: The early worm gets the late bird. X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Fri, 01 Dec 2023 08:23:17 -0800 (PST) --qdnQx0uLPm9zl6Yh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Dec 01, 2023 at 06:14:02PM +0200, Andy Shevchenko wrote: > > + }; > > + spi_sync_transfer(to_spi_device(port->dev), xfer, ARRAY_SIZE(xfer)); > Can you add a comment like FIXME explaining why regmap is not used > here, otherwise I will expect some clever guy to "fix" this again. Or just do the fix in the right place rather than throwing a bodge about... --qdnQx0uLPm9zl6Yh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmVqCGkACgkQJNaLcl1U h9Dtqwf/T8oP4v0AyPIKO1zvOA+lyfyHC9EWOqm1zbfbKYha19ktbkao6KGFdodN 61bbwqOhNGeQ0JdyStJZsYAep4253CjTZ1yfTI5KhB17w1+JGVCxio7wAibun4le TTNJ3WsJvFBZMw9IsFfycyzUBm5YJ63jZefVmoBXyW7o48XYJw3YlhRY5BSxENYZ +xROEb9n/gEOcmSdL6Cwts2AkBnBgi2bMsVFJ0oBSXus8SwjzsEReWjtSlwTFI7S YuaAgciYaqPIbbfM4Lo5DWJ1vUfmK4DgN9Dxc2q9gIROidRekmvaU8D1BvKoPmz4 P2HHb61PkD301vrZ2Nza0Wn7qW/5Cg== =0qNi -----END PGP SIGNATURE----- --qdnQx0uLPm9zl6Yh--