Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Fri, 1 Dec 2023 12:06:48 -0500
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Jeffrey Hugo <quic_jhugo@quicinc.com>
Cc:     Krishna chaitanya chundru <quic_krichai@quicinc.com>,
        "Manivannan Sadhasivam" <mani@kernel.org>,
        "Masami Hiramatsu" <mhiramat@kernel.org>,
        <linux-kernel@vger.kernel.org>, <mhi@lists.linux.dev>,
        <linux-arm-msm@vger.kernel.org>,
        <linux-trace-kernel@vger.kernel.org>, <quic_vbadigan@quicinc.com>,
        <quic_ramkri@quicinc.com>, <quic_nitegupt@quicinc.com>,
        <quic_skananth@quicinc.com>, <quic_parass@quicinc.com>
Subject: Re: [PATCH v5] bus: mhi: host: Add tracing support
Message-ID: <20231201120648.795ea00c@gandalf.local.home>
In-Reply-To: <15c0130a-1a4b-c08b-714b-05166f48d23b@quicinc.com>
References: <20231127-ftrace_support-v5-1-eb67daead4f1@quicinc.com>
        <15c0130a-1a4b-c08b-714b-05166f48d23b@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 1 Dec 2023 10:01:33 -0700
Jeffrey Hugo <quic_jhugo@quicinc.com> wrote:

> > +DECLARE_EVENT_CLASS(mhi_process_event_ring,
> > +
> > +	TP_PROTO(const char *name, void *rp, __le64 ptr,
> > +		 __le32 dword0, __le32 dword1),
> > +
> > +	TP_ARGS(name, rp, ptr, dword0, dword1),
> > +
> > +	TP_STRUCT__entry(
> > +		__string(name, name)
> > +		__field(__le32, dword0)
> > +		__field(__le32, dword1)
> > +		__field(int, state)
> > +		__field(__le64, ptr)
> > +		__field(void *, rp)
> > +	),
> > +
> > +	TP_fast_assign(
> > +		__assign_str(name, name);
> > +		__entry->rp = rp;
> > +		__entry->ptr = ptr;
> > +		__entry->dword0 = dword0;
> > +		__entry->dword1 = dword1;
> > +		__entry->state = MHI_TRE_GET_EV_STATE((struct mhi_ring_element *)entry->rp);  
> 
> "entry"?
> Also, you have the "rp" that was passed into the trace, why not just 
> directly use that?

Agreed.

-- Steve