Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Subject: RE: [PATCH 0/2] KVM: xen: update shared_info when long_mode is set
Thread-Topic: [PATCH 0/2] KVM: xen: update shared_info when long_mode is set
From:   "Durrant, Paul" <pdurrant@amazon.co.uk>
To:     Sean Christopherson <seanjc@google.com>,
        Paul Durrant <paul@xen.org>
CC:     David Woodhouse <dwmw2@infradead.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "x86@kernel.org" <x86@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Thread-Index: AQHaJEOuWnzn0NGSpk+GH7VJCEKIN7CUozuAgAAF5dA=
Date:   Fri, 1 Dec 2023 17:08:32 +0000
Message-ID: <a0c99edd584b47ce8f9f8aff86b2a568@amazon.co.uk>
References: <20231201104536.947-1-paul@xen.org> <ZWoNzzYiZtloNQiv@google.com>
In-Reply-To: <ZWoNzzYiZtloNQiv@google.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Precedence: bulk

> -----Original Message-----
> From: Sean Christopherson <seanjc@google.com>
> Sent: 01 December 2023 16:46
> To: Paul Durrant <paul@xen.org>
> Cc: David Woodhouse <dwmw2@infradead.org>; Paolo Bonzini <pbonzini@redhat=
.com>; Thomas Gleixner
> <tglx@linutronix.de>; Ingo Molnar <mingo@redhat.com>; Borislav Petkov <bp=
@alien8.de>; Dave Hansen
> <dave.hansen@linux.intel.com>; x86@kernel.org; H. Peter Anvin <hpa@zytor.=
com>; kvm@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Subject: RE: [EXTERNAL] [PATCH 0/2] KVM: xen: update shared_info when lon=
g_mode is set
>=20
> CAUTION: This email originated from outside of the organization. Do not c=
lick links or open
> attachments unless you can confirm the sender and know the content is saf=
e.
>=20
>=20
>=20
> On Fri, Dec 01, 2023, Paul Durrant wrote:
> > From: Paul Durrant <pdurrant@amazon.com>
> >
> > This series is based on my v9 of my "update shared_info and vcpu_info
> > handling" series [1] and fixes an issue that was latent before the
> > "allow shared_info to be mapped by fixed HVA" patch of that series allo=
wed
> > a VMM to set up shared_info before the VM booted and then leave it alon=
e.
>=20
> Uh, what?   If this is fixing an existing bug then it really shouldn't ta=
ke a
> dependency on a rather large and non-trivial series.  If the bug can only=
 manifest
> as a result of said series, then the fix absolutely belongs in that serie=
s.
>=20

There's been radio silence on that series for a while so I was unsure of th=
e status.

> This change from patch 1 in particular:
>=20
>  -static int kvm_xen_shared_info_init(struct kvm *kvm, u64 addr, bool add=
r_is_gfn)
>  +static int kvm_xen_shared_info_init(struct kvm *kvm)
>=20
> practically screams for inclusion in that series which does:
>=20
>  -static int kvm_xen_shared_info_init(struct kvm *kvm, gfn_t gfn)
>  +static int kvm_xen_shared_info_init(struct kvm *kvm, u64 addr, bool add=
r_is_gfn)
>=20
> Why not get the code right the first time instead of fixing it up in a co=
mpletely
> different series?

Sure, I can fold it in.

  Paul