Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp1209933rdb; Fri, 1 Dec 2023 09:38:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IGV1Zhs0pvtpPtX7lBSXFwASYj6H/h8yIuPOUtElcej20xbVrrWWmZIrJRtCWTlKK4TRDJG X-Received: by 2002:a05:6a20:12c7:b0:187:4329:f06d with SMTP id v7-20020a056a2012c700b001874329f06dmr35910706pzg.31.1701452310097; Fri, 01 Dec 2023 09:38:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701452310; cv=none; d=google.com; s=arc-20160816; b=G7FjV5+gendVYWO1GxULlOEWxp615dW3teVuxQLE08tj9g2EtPfvc2/K5neK/llJx8 TmeumfEqNL1MEQ7czjaS/r3QiSIEd0qVaymY7AyyVUdJEwzKpK5uWJ3soyLbqYke741J HlnVjTzh2kJxVNcIT9jvMMPHml8tHonnQSbW6cCf0Ual5gIAXMzGjP2qCk+V6cR3oyIa de6PaLi/uGV7IUYSfQQWHTFsC4+PzvZbrEf2huAQooShNDdNbrVzaO1XoQPBJVRBOUo0 FvP7MhFsL1Dd/2iHkJ51ZPg7W7+m52uHGqeUIfRNZjZYufqgHraBjTe1kgGvVMgqrQSy Ia2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=mIN6tLPw09H9zOs4zuK0VfA5bwhOPcu5mP00NJGpiN4=; fh=IM3McWsM9WPthTZ9Z7peQVvYux4QqEk9HMDjS1JrRmU=; b=Hh614VSxJWRx/4+7UewZQyYG2GI3virYyrkgHStK0a28R45ZRQ3NQPj7/INnHNmXqG vUoGywkFLkJlft6CXqG8VaPl7XVsUwzUjS4o5gp+sEID7o7Rc/k8aAGRqxHXIu+20i3X GLXn2jh79Eg+2tQJRwI+BZ8eBQ3YIUsAn/4gePcaUZBdHvV4+8grOAi9UcWnnaIau1kf PScdZF8Z6CZvsR/T3aocdVLb4id7Q6QZ1tPDBNbQyPep14UdJ50A2hD8jzDXxwMjpkHv z6bjLV0oGFjOanrud+PxMZwL8A+aaCrBIB/3dAhyzus1OYw0dV6ZE/L8noOx7voic6U3 ASJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=D9iiemAJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id bd5-20020a656e05000000b005bddca8236dsi4112125pgb.699.2023.12.01.09.38.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 09:38:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=D9iiemAJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 60EFF837A4C3; Fri, 1 Dec 2023 09:38:27 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230186AbjLARiO (ORCPT + 99 others); Fri, 1 Dec 2023 12:38:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232043AbjLARiK (ORCPT ); Fri, 1 Dec 2023 12:38:10 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE10426B7 for ; Fri, 1 Dec 2023 09:27:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701451645; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mIN6tLPw09H9zOs4zuK0VfA5bwhOPcu5mP00NJGpiN4=; b=D9iiemAJnlkecMtuYTcYE5hGz8GXsbcRCLf8HAVECjzbxTPDW15zFHXv5n8B9FeSFp+32c NSi+WJo4TkILcJ7R9SmOqNG2FPX4nkP08o8lUkWajf6l4JSRfO0RBSlzU/KBIL8IwHeQqk lyIwTGIW1sz1KXwczwSTqzQSjDH2Dqg= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-568-eD3LDQIjMwmrsUndj-JnrQ-1; Fri, 01 Dec 2023 12:27:19 -0500 X-MC-Unique: eD3LDQIjMwmrsUndj-JnrQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4735B3804528; Fri, 1 Dec 2023 17:27:19 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.39.193.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id 362E22026D4C; Fri, 1 Dec 2023 17:27:17 +0000 (UTC) From: Jose Ignacio Tornos Martinez To: stern@rowland.harvard.edu Cc: davem@davemloft.net, edumazet@google.com, greg@kroah.com, jtornosm@redhat.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org, oneukum@suse.com, pabeni@redhat.com, stable@vger.kernel.org Subject: Re: [PATCH v3] net: usb: ax88179_178a: avoid failed operations when device is disconnected Date: Fri, 1 Dec 2023 18:27:14 +0100 Message-ID: <20231201172716.182693-1-jtornosm@redhat.com> In-Reply-To: <140e912f-8702-4e85-8d6c-ef0255e718f8@rowland.harvard.edu> References: <140e912f-8702-4e85-8d6c-ef0255e718f8@rowland.harvard.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 01 Dec 2023 09:38:27 -0800 (PST) Hi Alan, > Would it be good enough just to check for ret != -ENODEV and not do the > stopping_unbinding check at all? I thought about that but if possible, I would like to ignore the failed operation messages only under a controlled and expected situation. I think that if there is a problem with the device it will be easier to analyze it later with all the possible information. But this is my opinion ... Thank you Best regards José Ignacio