Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp1216683rdb; Fri, 1 Dec 2023 09:49:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IF34kL3+KrD88v4uHWjk7phALdCDfEVjrMQCjZmWczwZBjXW5yM0VQNeLOKa5wP5Na+Z9kQ X-Received: by 2002:a17:90b:1a88:b0:286:60c:349c with SMTP id ng8-20020a17090b1a8800b00286060c349cmr12652119pjb.11.1701452982510; Fri, 01 Dec 2023 09:49:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701452982; cv=none; d=google.com; s=arc-20160816; b=eMzVormI6IVKPaXCnK9N2g59Vf0yGQ7liwsD/eEdu7svqb73f9HH0ETEUDc6SlB1Hf 1rKCBhl0hrx5PZUrikcNGVghIQlisxsBwM9VcKBKgcmsSqQuKwiDjcDDfTaZrKa3ncvQ vkA+RfrIb/cuHuptLPPJpD/TVqjwSniXvP3XV/2s8K15uiipGwXYEnfePTz6FhXz3LeL RLdQYVQgZC45soeULxdspE381FP5HC0qDJLPWzAWJBkNJNuZBeA+Irod92wg9VHtl7Nr Mi+iLgyOD/kP3cX2hoAc5FJ3Lf37BF9I4rLZCucQY6sk9L4lw6O9T6rc6GlWB0P/7XD3 KMiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=c3XtzzjFOgOD7S4u56J6oC5ewGwOzGezjwSu4l5fq5g=; fh=rb5sR2rQa902X84yik1TqLU5qpRkQt89dLyRG+6e3gw=; b=ZWyRMZb02yFdw7Hd8SJsFBZq6q9PqK5Vy3OkF2pqCoebjEf1rLK47cfn020fYIoz6w K78QYN5UCg4AVjp7UMq9Ni7k/etWpOd6J6yZLQNikJl2CvIzsciD02RCOWVQXqBLvZzS qn1ZKPGrig+3TZ/WbZkq00Wx92rHBmO5Vg/gnrwtOz4osGSLFlQVHMuMN1A7/PUVlrMl c43BJE0e97MLm5ul1c+Ruh8LhPv3BF7Z4SqOvqH8blr2sAULWLdLuxjzKRVWXV2fV98z uT4tWjxmT4Yj3lrZcbNu918hrUAQprTc63Frozwcz67+TFxJJjma1qyR7ScTyDecBfwJ +ARQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=sm4ZZFq9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id hk12-20020a17090b224c00b002865ac7e2d1si515146pjb.1.2023.12.01.09.49.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 09:49:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=sm4ZZFq9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 15680812AD3C; Fri, 1 Dec 2023 09:49:41 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378938AbjLARtb (ORCPT + 99 others); Fri, 1 Dec 2023 12:49:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230147AbjLARta (ORCPT ); Fri, 1 Dec 2023 12:49:30 -0500 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97C09AC for ; Fri, 1 Dec 2023 09:49:36 -0800 (PST) Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-40838915cecso22932245e9.2 for ; Fri, 01 Dec 2023 09:49:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701452975; x=1702057775; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=c3XtzzjFOgOD7S4u56J6oC5ewGwOzGezjwSu4l5fq5g=; b=sm4ZZFq91CY8lte9F47e4X3zAOAXsm8t0eBH4BO5uNmn8snvKeCbHYnHIAp2JWAAtW MG1DDiYdDAIvxQp1y8Ld80lV3YYSKMR+bpPEsVMn9dXe0Q+9XYux5wRuMRhegWh5xNAa Ymii+///SgDCozKE9LYdr+r3o2yQYeU72SualleKfb84fsqpEK0U209KwA5StV97OF6W 2I59evkBsqq3QaEOQE/U755uBLCo9YjoqiZFYbPK1sBGmD1yhSi5lkD+sGMN256xQctB l9thj3vJV+iz5nuJZZ1YmWWNpzdJSLQBC5gBoz+sGNvw9xUUSqxawKIhECfZ0C3XKYbL c9Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701452975; x=1702057775; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=c3XtzzjFOgOD7S4u56J6oC5ewGwOzGezjwSu4l5fq5g=; b=jgKTP7kKrcTX6Z6pAUBfigKwPMwKUzFqL1g+UoQVHoPDlhrikcgS4j5rGPnWaRXCA/ Nv9wxHln9TDZHp1UvOlfDEFmerM9JHF36zy/FF8RkzUAOBj3R+3rS+iz3SDK64siXdsh gzd6M7o667xSNMC6WbTS1LiHXT8k2d7xwLBwdwDpzvN3QjI2prr+qQ9w7NC/A0m5xsib HgPQHpw1r9MBtZZu5/ffM3Anh7VHdRqoWF87GcKTKOgfFuU385k/crkbp3vp821WYy15 +0nsDjGngvva5sZGiqpLKZ3XrXD0/8POLeNwBCVZyw+jACVB4r9SfK/EcJOl7fyuhxPD yaYw== X-Gm-Message-State: AOJu0Yy8skMu3CDcs1Wso7b0hOto6dXzYtwE1ljAB/BDtASKrSI1Xk6i SmcJozmTHB6t9Zd9W8qU2VGY9A== X-Received: by 2002:a05:600c:4f03:b0:40b:2a15:9b30 with SMTP id l3-20020a05600c4f0300b0040b2a159b30mr447078wmq.1.1701452975070; Fri, 01 Dec 2023 09:49:35 -0800 (PST) Received: from linaro.org ([82.77.85.67]) by smtp.gmail.com with ESMTPSA id dl17-20020a0560000b9100b003316debbde4sm4777931wrb.48.2023.12.01.09.49.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 09:49:34 -0800 (PST) Date: Fri, 1 Dec 2023 19:49:32 +0200 From: Abel Vesa To: Manivannan Sadhasivam Cc: martin.petersen@oracle.com, jejb@linux.ibm.com, andersson@kernel.org, konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, quic_cang@quicinc.com Subject: Re: [PATCH 02/13] scsi: ufs: qcom: Fix the return value of ufs_qcom_ice_program_key() Message-ID: References: <20231201151417.65500-1-manivannan.sadhasivam@linaro.org> <20231201151417.65500-3-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231201151417.65500-3-manivannan.sadhasivam@linaro.org> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 01 Dec 2023 09:49:41 -0800 (PST) On 23-12-01 20:44:06, Manivannan Sadhasivam wrote: > Currently, the function returns -EINVAL if algorithm other than AES-256-XTS > is requested. But the correct error code is -EOPNOTSUPP. Fix it! > > Cc: Abel Vesa > Fixes: 56541c7c4468 ("scsi: ufs: ufs-qcom: Switch to the new ICE API") > Signed-off-by: Manivannan Sadhasivam LGTM. Reviewed-by: Abel Vesa > --- > drivers/ufs/host/ufs-qcom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c > index cbb6a696cd97..852179e456f2 100644 > --- a/drivers/ufs/host/ufs-qcom.c > +++ b/drivers/ufs/host/ufs-qcom.c > @@ -158,7 +158,7 @@ static int ufs_qcom_ice_program_key(struct ufs_hba *hba, > cap = hba->crypto_cap_array[cfg->crypto_cap_idx]; > if (cap.algorithm_id != UFS_CRYPTO_ALG_AES_XTS || > cap.key_size != UFS_CRYPTO_KEY_SIZE_256) > - return -EINVAL; > + return -EOPNOTSUPP; > > if (config_enable) > return qcom_ice_program_key(host->ice, > -- > 2.25.1 >