Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp1238911rdb; Fri, 1 Dec 2023 10:20:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IEcG2wLMgBkaY25wQTk89s+nbWtlZ0rx+r4ONGYprnJhnNAUnM8hSAyuZwkqHSdEXsHP2QI X-Received: by 2002:a17:902:c794:b0:1d0:58ae:8994 with SMTP id w20-20020a170902c79400b001d058ae8994mr1726438pla.29.1701454842696; Fri, 01 Dec 2023 10:20:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701454842; cv=none; d=google.com; s=arc-20160816; b=Q1Fk6gOHjic47qlRn5MKtsEybJueQVdFEN/xqiKDqVwV+pOIA4w+ummH6T/W7YfYIE PEuG6THfpdusgQSlgz5jvUWAzoobuUrkH9ACqzvGFba6T5EMLUCP+63fpWgkZSsqqHrB xz/Mv0vNOzkbqmi548IMRjoiM6g8Ut8yhbrtSz/HLEhUpgcNGe5YzNKt3a/7QHco8vPp h2Ylk0PceSARwGYCQ8u/0XJ8BIZXKmGJoRDPsmbFr62mK95bHOdVSehOg+CuaPgdumE8 zr7U0/AAXpGCt4nbXyB5fJ5m8msNZ9Mcw+Q/quFXXinwqstwJ7NXvTMbGfyDEHQvmnTc 4kzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=6FH0TcrjcnuCcZhjexfAuu7+PxcUWEk5ugjeQLcg8YU=; fh=pG4Snjkux9G1ZZpPyGb8q1uzixjNgUlg3BO7DougVcE=; b=JRqHoErMZv5JcsDPFreD4Qdr7VARWCCgZ5rye0XTZjBg2H5Gm3iwJYEySocYQHA2UJ wfKEs6RsJU2qYbH6iWW5BEjjE0nCIAyl8/gvdqh0yhH01Bf7dkXUUq02li2WVUewsFlG D7qlWjYESVce/g+VoVMn0lsBnK9+qfqLrYJ4XLHMJPGKcbiF0gIj9o4wZ0o2KvAGiOzJ Q4dTaIhJcpcjvtj/ltSp680f2gqrIfaSLdnTKL87cLtKXdVv8vtPUQY3Fa6jA5cvq88d jFIOLdvUOWC6Ec3GIVMug/oiVW21tV6BAqY/SBoISY5L6qrK4XlU2eYp3K8bheNOIvz6 wCcQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="Yi1v/4Xg"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id y3-20020a170902ed4300b001cfb52ebfdbsi3507408plb.152.2023.12.01.10.20.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 10:20:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="Yi1v/4Xg"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 0AD1C832CBEF; Fri, 1 Dec 2023 10:20:39 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379178AbjLASUZ (ORCPT + 99 others); Fri, 1 Dec 2023 13:20:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229468AbjLASUY (ORCPT ); Fri, 1 Dec 2023 13:20:24 -0500 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02219106 for ; Fri, 1 Dec 2023 10:20:31 -0800 (PST) Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-6cdfee14c24so862975b3a.2 for ; Fri, 01 Dec 2023 10:20:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1701454830; x=1702059630; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6FH0TcrjcnuCcZhjexfAuu7+PxcUWEk5ugjeQLcg8YU=; b=Yi1v/4XgjPjmzmxX7Ay50OHL2ufSIr+m2qFwG91eDb22CI/nQjeOaJe23mZI0FvMmR nOxZ2BUhBobhumC0YMGvBAcy13YAECeX5iOWfPhKl3S4Je8GOH3tS5yUZ7Xxr1WOP0mp wL4pZgma2yqC7I2XBVd2PtEzVhYKySm0Nev08= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701454830; x=1702059630; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6FH0TcrjcnuCcZhjexfAuu7+PxcUWEk5ugjeQLcg8YU=; b=X28HwDBMLDfbF9rVzy1KwYSk7qBg1dI4abYXva+FPXiRexsLLZan0BLjdyU1Gc9Crb UDE66bX81YORo8NVV6Ba98otiI79zg+kQvDB19zjxwINVlpl46OG58tzTxezOlLL94Ii PiyiBue0kxlF0nBfCVyMpP61JbwC4W/CFofFrVicz1F3P5QKjV+ZjsBqDJ99erYiCcvo OtTiItXM60bqvsk82DZaPCevPwbGGZuFjX+c6EH/DVSlC/6m4AIHKBL+ukdHba4ksnaS 2ZmZRz6bUYtaCYG5yOMvUguf92Dvl+LwpeFDMvmd27Lyums3zJtyKkw9iir0qqHWgE8O hdDQ== X-Gm-Message-State: AOJu0Yw+cfeR9F5m0gTdHxXf0cITpdNl6WTEmOWhqkxoxlf/Gp7W7vxX d+Ma/28s9Pg8fVLmFqp0hDwJsQ== X-Received: by 2002:a05:6a00:2293:b0:6ce:d04:2b46 with SMTP id f19-20020a056a00229300b006ce0d042b46mr1441149pfe.25.1701454830520; Fri, 01 Dec 2023 10:20:30 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id k18-20020a6568d2000000b005c1ae0b5440sm3011950pgt.74.2023.12.01.10.20.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 10:20:30 -0800 (PST) Date: Fri, 1 Dec 2023 10:20:29 -0800 From: Kees Cook To: Jakub Kicinski Cc: Shay Agroskin , Arthur Kiyanovski , David Arinzon , Noam Dagan , Saeed Bishara , "David S. Miller" , Eric Dumazet , Paolo Abeni , Justin Stitt , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] net: ena: replace deprecated strncpy with strscpy Message-ID: <202312011019.A40455F@keescook> References: <20231005-strncpy-drivers-net-ethernet-amazon-ena-ena_netdev-c-v1-1-ba4879974160@google.com> <170138158571.3648714.3841499997574845448.b4-ty@chromium.org> <20231130224134.73652d71@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231130224134.73652d71@kernel.org> X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 01 Dec 2023 10:20:39 -0800 (PST) On Thu, Nov 30, 2023 at 10:41:34PM -0800, Jakub Kicinski wrote: > On Thu, 30 Nov 2023 13:59:48 -0800 Kees Cook wrote: > > [1/1] net: ena: replace deprecated strncpy with strscpy > > https://git.kernel.org/kees/c/111f5a435d33 > > Again, please drop, Arthur requested for the commit message > to be changed. Dropped, though I did change the commit message in the pulled commit. Justin, can you send a v2 with the commit change? Then it can go through regular netdev machinery? -- Kees Cook