Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
MIME-Version: 1.0
References: <CAMVG2stxMYZbDoAHeVQjgJ7f+Td7+VJrLNRbY8au68ZVkzhb0g@mail.gmail.com>
 <20231201032548.5y3lafkwamlhruqs@moria.home.lan> <20231201052701.jrxwpjte4htzn6wo@moria.home.lan>
In-Reply-To: <20231201052701.jrxwpjte4htzn6wo@moria.home.lan>
From:   Daniel J Blueman <daniel@quora.org>
Date:   Fri, 1 Dec 2023 13:45:45 -0500
Message-ID: <CAMVG2ssNi_otD9tjobdCVFn6RivojzvKGqS7b6k+aPrvk-7JQA@mail.gmail.com>
Subject: Re: bcachefs page fault oops after device evacuate/remove and unmount
To:     Kent Overstreet <kent.overstreet@linux.dev>
Cc:     linux-bcachefs@vger.kernel.org,
        Linux Kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, 1 Dec 2023 at 00:27, Kent Overstreet <kent.overstreet@linux.dev> wrote:
> On Thu, Nov 30, 2023 at 10:25:48PM -0500, Kent Overstreet wrote:
> > On Thu, Nov 30, 2023 at 08:47:33PM -0500, Daniel J Blueman wrote:
> > > Hi Kent et al,
> > >
> > > On upstream bcachefs (master @ evilpiepirate.org/git/bcachefs.git) SHA
> > > f8a1ba26, I was able to develop a minimal reproducer [1] for a page
> > > not present oops I can provoke [2]. It appears we need further
> > > synchronisation during unmount.
> > >
> > > Let me know when there is a patch I can test, or for debug.
> > >
> > > Thanks,
> > >   Dan
> > >
> > > -- [1]
> > >
> > > modprobe brd rd_size=536870912 rd_nr=2
> > > bcachefs format -f /dev/ram0 /dev/ram1
> > > mount -t bcachefs /dev/ram0:/dev/ram1 /mnt
> > > fio --group_reporting --ioengine=io_uring --directory=/mnt --size=16m
> > > --time_based --runtime=60s --iodepth=256 --verify_async=8 --bs=4k-64k
> > > --norandommap --random_distribution=zipf:0.5 --numjobs=16 --rw=randrw
> > > --name=A --direct=1 --name=B --direct=0 >/dev/null &
> > > bcachefs device evacuate /dev/ram0
> > > bcachefs device remove --force --force-metadata /dev/ram1
> > > bcachefs device remove --force --force-metadata /dev/ram1
> > > kill %1
> > > wait
> > > umount /mnt
> >
> > The remove fails for me with DEVICE_SET_STATE_NOT_ALLOWED - evacuate set
> > ram0 to ro, we can't remove our last rw dev.
>
> Got it to repro, just had to ignore those errors - there's now a ktest
> test for it, and the fix is in master :)

Fine work Kent! The fix is good from further testing here.

Tested-by: Daniel J Blueman <daniel@quora.org>

Thanks again,
  Dan
--
Daniel J Blueman