Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp1297185rdb; Fri, 1 Dec 2023 12:05:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IF502GQKO7vtx/5ZfkQ28Axuj9F5IjMkJJBn89fT97wFikphKmkACiGkEsyXIOCpPdZLFgA X-Received: by 2002:a17:902:b087:b0:1d0:6ffd:6e84 with SMTP id p7-20020a170902b08700b001d06ffd6e84mr24106plr.124.1701461126063; Fri, 01 Dec 2023 12:05:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701461126; cv=none; d=google.com; s=arc-20160816; b=a9sir+edC5FYcMn6VbHcR3zCNBNd5xPqx3aT2rdtJ0TSZGBdYaCvVdiOKYGzpZbmh+ IaFpr03VKUcJbfpu71Ob+CErcDl3PvJG5dV3RML77+2SfvG/Fb5SQ4mUcMG5SMK3kMlI WJD4VQcYe8hREnvkOeXGqy1m1SN2S5DHkkxq5qrSZdlh6zZ14Dp8sczqPZRDiSCd1eQX 1/b+p/IxnYuEIWZfuWkNHP3m/nFnI21hAlj1SKMwtVF4P39+2C+M5Rq/XJYwhZaysaLe uHwoPDOi09X1hM72gkOnPigAcg2VM3gih393EqnomH1aZiV6/MwaYYwvNmpk1Y5/uyHw yI9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=vRrCOWPZzGmxVxBA/IcQl+VJirpmKWXzqC5hzXbpGCk=; fh=UT8689VZ8AhOsC/4BFrPkkRkb9XQnUYKnqw3X/XG/7k=; b=wsJxuH6dtMejNag5aixNNyyiRkE/l2HYj4O/kxpV5C/Ao8PCdL6FqrG8Ust2Bg8bI5 EXw1kyVS5IDn0M6cBUbJiEUn2ARKN3kchX0SX6tLK0jELNFO1AKfkIzJ9D07xD0oN+L6 +h80D5TnbDo5GabUkGwoBLIrkYJXpgBWr7IeYdHYhiz9yeycxiuFzpGcenItpEPHCMZu SiNU/1VeF6LX/TADydluIrM5mF2Ld+nw4lz6dI/Fh+J0eUWKgKPLfAZmkxhIpckG/T+K SgymF8AVsSpqk1Y5KMjzZxGvjbE7u/iVh3u+G2kudZ6oa+8HDRl3fHoEHnxbaOYsBB7c vBtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CJ1WjZYZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id w11-20020a17090a8a0b00b0028590df178esi3774258pjn.158.2023.12.01.12.05.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 12:05:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CJ1WjZYZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 4D68E80CF557; Fri, 1 Dec 2023 12:05:23 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379579AbjLAUFH (ORCPT + 99 others); Fri, 1 Dec 2023 15:05:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379559AbjLAUFG (ORCPT ); Fri, 1 Dec 2023 15:05:06 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C85B810F4 for ; Fri, 1 Dec 2023 12:05:12 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6952FC433C8; Fri, 1 Dec 2023 20:04:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701461112; bh=VZNoAqDPTg8yDoctRcEB3F3opYWUlSBiujMwK2WyTQk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CJ1WjZYZ+qso1UgSidqe3y+J/eJKvHShQw2R3MIzQEk70r87eQP1DebG3EQAiSLIj IUqhHtHkfHjsuBzdihsJ/ioN6yOXRd3wk9v9HE6RTary1ugjedS5FIL4PVk+6wU/ez g9DPCfWdfABoNpMiyisxXIZsO0px3oHHZYB77AAaBAGg1g+WXNqe/+ZY/8Xs6oj+ud LBLNz8APsX4gnPGHkBG46TW0JkbA7erLdKsm+gCXkSOaxRnSHnSGmTAZx6/Eo8gWe0 0lOj7Mfj5wmuVLHJTKpo4wPE5uVmAJClr6yxMBQ67sBDQKBPKWsKgwaxLyKpz+g8rk EBv4asusLbiFg== Date: Fri, 1 Dec 2023 12:04:42 -0800 From: Josh Poimboeuf To: Andrew Cooper Cc: Pawan Gupta , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Peter Zijlstra , Andy Lutomirski , Jonathan Corbet , Sean Christopherson , Paolo Bonzini , tony.luck@intel.com, ak@linux.intel.com, tim.c.chen@linux.intel.com, Nikolay Borisov , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, Alyssa Milburn , Daniel Sneddon , antonio.gomez.iglesias@linux.intel.com, Greg Kroah-Hartman , Alyssa Milburn Subject: Re: [PATCH v4 1/6] x86/bugs: Add asm helpers for executing VERW Message-ID: <20231201200442.lvyep5uqc6oa7kwj@treble> References: <20231027-delay-verw-v4-0-9a3622d4bcf7@linux.intel.com> <20231027-delay-verw-v4-1-9a3622d4bcf7@linux.intel.com> <20231201193657.mvzslo4nlcbuv2q4@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Fri, 01 Dec 2023 12:05:23 -0800 (PST) On Fri, Dec 01, 2023 at 07:39:05PM +0000, Andrew Cooper wrote: > On 01/12/2023 7:36 pm, Josh Poimboeuf wrote: > > On Fri, Oct 27, 2023 at 07:38:40AM -0700, Pawan Gupta wrote: > >> +.pushsection .entry.text, "ax" > >> + > >> +.align L1_CACHE_BYTES, 0xcc > >> +SYM_CODE_START_NOALIGN(mds_verw_sel) > >> + UNWIND_HINT_UNDEFINED > >> + ANNOTATE_NOENDBR > >> + .word __KERNEL_DS > >> +.align L1_CACHE_BYTES, 0xcc > >> +SYM_CODE_END(mds_verw_sel); > >> +/* For KVM */ > >> +EXPORT_SYMBOL_GPL(mds_verw_sel); > >> + > >> +.popsection > > This is data, so why is it "CODE" in .entry.text? > > Because KPTI. Urgh... Pawan please add a comment. -- Josh