Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754146AbXLANOB (ORCPT ); Sat, 1 Dec 2007 08:14:01 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751938AbXLANNv (ORCPT ); Sat, 1 Dec 2007 08:13:51 -0500 Received: from rtr.ca ([76.10.145.34]:4012 "EHLO mail.rtr.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751439AbXLANNu (ORCPT ); Sat, 1 Dec 2007 08:13:50 -0500 Message-ID: <47515E0C.9010405@rtr.ca> Date: Sat, 01 Dec 2007 08:13:48 -0500 From: Mark Lord User-Agent: Thunderbird 2.0.0.9 (X11/20071031) MIME-Version: 1.0 To: "Eric W. Biederman" Cc: Greg Kroah-Hartman , Greg KH , Tejun Heo , Linux Containers , netdev@vger.kernel.org, cornelia.huck@de.ibm.com, stern@rowland.harvard.edu, kay.sievers@vrfy.org, linux-kernel@vger.kernel.org, Andrew Morton , Herbert Xu , David Miller , Linus Torvalds Subject: Re: namespace support requires network modules to say "GPL" References: <47515D39.9030900@rtr.ca> In-Reply-To: <47515D39.9030900@rtr.ca> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1425 Lines: 37 Mark Lord wrote: >> Now that we have network namespace support merged it is time to >> revisit the sysfs support so we can remove the dependency on !SYSFS. > ... > Now that the namespace updates are part of 2.6.24, > there is a major inconsistency in network EXPORT_SYMBOLs. > > It used to be that an external network module could get away without > having to add a MODULE_LICENSE("GPL*") line to the source. > > In support of that, common networking functions (still) use EXPORT_SYMBOL() > rather than the more restrictive EXPORT_SYMBOL_GPL(). > > Eg. register_netdev(), sk_alloc(), __dev_get_by_name(). > > But now, none of those three are actually usable by default, > because they all require "init_net", which is EXPORT_SYMBOL_GPL(). > > So.. It appears that one of three things should really happen next: > > 1) Change the other exports to also be EXPORT_SYMBOL_GPL. > > 2) Have register_netdev, sk_alloc, and __dev_get_by_name default > to using init_net when NULL is specified in the namespace field. > > or > 3) Change init_net to be EXPORT_SYMBOL_GPL. .. Obviously that should instead say: 3) Change init_net to be EXPORT_SYMBOL instead of EXPORT_SYMBOL_GPL. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/